commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1764274 - /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcBlock.java
Date Tue, 11 Oct 2016 15:50:18 GMT
Author: sebb
Date: Tue Oct 11 15:50:18 2016
New Revision: 1764274

URL: http://svn.apache.org/viewvc?rev=1764274&view=rev
Log:
Oops - the class is used in public parameter types

Modified:
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcBlock.java

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcBlock.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcBlock.java?rev=1764274&r1=1764273&r2=1764274&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcBlock.java
(original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcBlock.java
Tue Oct 11 15:50:18 2016
@@ -19,19 +19,21 @@ package org.apache.commons.imaging.forma
 /**
  * Represents an IPTC block, a set of key-value pairs of Photoshop IPTC data.
  */
-class IptcBlock {
+public class IptcBlock {
+    // N.B. The class is used in public API parameter types
+
     public final int blockType;
     //  Only currently used by classes in the package
     final byte[] blockNameBytes; // TODO make private and provide getter?
     final byte[] blockData; // TODO make private and provide getter?
 
-    IptcBlock(final int blockType, final byte[] blockNameBytes, final byte[] blockData) {
+    public IptcBlock(final int blockType, final byte[] blockNameBytes, final byte[] blockData)
{
         this.blockData = blockData;
         this.blockNameBytes = blockNameBytes;
         this.blockType = blockType;
     }
 
-    boolean isIPTCBlock() {
+    public boolean isIPTCBlock() {
         return blockType == IptcConstants.IMAGE_RESOURCE_BLOCK_IPTC_DATA;
     }
 }



Mime
View raw message