commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brit...@apache.org
Subject [lang] LANG-1259: JavaDoc for ArrayUtils.isNotEmpty() is slightly misleading. Thanks to Dominik Stadler.
Date Fri, 19 Aug 2016 07:50:04 GMT
Repository: commons-lang
Updated Branches:
  refs/heads/master eaa9269ac -> 4a26a86d0


LANG-1259: JavaDoc for ArrayUtils.isNotEmpty() is slightly misleading. Thanks to Dominik Stadler.


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/4a26a86d
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/4a26a86d
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/4a26a86d

Branch: refs/heads/master
Commit: 4a26a86d0c0d9a72a0505ceedc7f1e39b984c302
Parents: eaa9269
Author: Benedikt Ritter <beneritter@gmail.com>
Authored: Fri Aug 19 09:49:51 2016 +0200
Committer: Benedikt Ritter <beneritter@gmail.com>
Committed: Fri Aug 19 09:49:51 2016 +0200

----------------------------------------------------------------------
 src/changes/changes.xml                         |  1 +
 .../org/apache/commons/lang3/ArrayUtils.java    | 36 ++++++++++----------
 2 files changed, 19 insertions(+), 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/4a26a86d/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index dcb4885..c89b9fc 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
   <body>
 
   <release version="3.5" date="tba" description="tba">
+    <action issue="LANG-1259" type="update" dev="britter" due-to="Dominik Stadler">JavaDoc
for ArrayUtils.isNotEmpty() is slightly misleading</action>
     <action issue="LANG-1257" type="add" dev="ggregory" due-to="Gary Gregory">Add APIs
StringUtils.wrapIfMissing(String, char|String)</action>
     <action issue="LANG-1190" type="fix" dev="pschumacher" due-to="pschumacher">TypeUtils.isAssignable
throws NullPointerException when fromType has type variables and toType generic superclass
specifies type variable</action>
     <action issue="LANG-1226" type="fix" dev="pschumacher" due-to="pschumacher">StringUtils#normalizeSpace
does not trim the string anymore</action>

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/4a26a86d/src/main/java/org/apache/commons/lang3/ArrayUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/ArrayUtils.java b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
index 4df4290..1d33fcf 100644
--- a/src/main/java/org/apache/commons/lang3/ArrayUtils.java
+++ b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
@@ -4894,11 +4894,11 @@ public class ArrayUtils {
 
     // ----------------------------------------------------------------------
     /**
-     * <p>Checks if an array of Objects is not empty or not {@code null}.
+     * <p>Checks if an array of Objects is not empty and not {@code null}.
      *
      * @param <T> the component type of the array
      * @param array  the array to test
-     * @return {@code true} if the array is not empty or not {@code null}
+     * @return {@code true} if the array is not empty and not {@code null}
      * @since 2.5
      */
      public static <T> boolean isNotEmpty(final T[] array) {
@@ -4906,10 +4906,10 @@ public class ArrayUtils {
      }
 
     /**
-     * <p>Checks if an array of primitive longs is not empty or not {@code null}.
+     * <p>Checks if an array of primitive longs is not empty and not {@code null}.
      *
      * @param array  the array to test
-     * @return {@code true} if the array is not empty or not {@code null}
+     * @return {@code true} if the array is not empty and not {@code null}
      * @since 2.5
      */
     public static boolean isNotEmpty(final long[] array) {
@@ -4917,10 +4917,10 @@ public class ArrayUtils {
     }
 
     /**
-     * <p>Checks if an array of primitive ints is not empty or not {@code null}.
+     * <p>Checks if an array of primitive ints is not empty and not {@code null}.
      *
      * @param array  the array to test
-     * @return {@code true} if the array is not empty or not {@code null}
+     * @return {@code true} if the array is not empty and not {@code null}
      * @since 2.5
      */
     public static boolean isNotEmpty(final int[] array) {
@@ -4928,10 +4928,10 @@ public class ArrayUtils {
     }
 
     /**
-     * <p>Checks if an array of primitive shorts is not empty or not {@code null}.
+     * <p>Checks if an array of primitive shorts is not empty and not {@code null}.
      *
      * @param array  the array to test
-     * @return {@code true} if the array is not empty or not {@code null}
+     * @return {@code true} if the array is not empty and not {@code null}
      * @since 2.5
      */
     public static boolean isNotEmpty(final short[] array) {
@@ -4939,10 +4939,10 @@ public class ArrayUtils {
     }
 
     /**
-     * <p>Checks if an array of primitive chars is not empty or not {@code null}.
+     * <p>Checks if an array of primitive chars is not empty and not {@code null}.
      *
      * @param array  the array to test
-     * @return {@code true} if the array is not empty or not {@code null}
+     * @return {@code true} if the array is not empty and not {@code null}
      * @since 2.5
      */
     public static boolean isNotEmpty(final char[] array) {
@@ -4950,10 +4950,10 @@ public class ArrayUtils {
     }
 
     /**
-     * <p>Checks if an array of primitive bytes is not empty or not {@code null}.
+     * <p>Checks if an array of primitive bytes is not empty and not {@code null}.
      *
      * @param array  the array to test
-     * @return {@code true} if the array is not empty or not {@code null}
+     * @return {@code true} if the array is not empty and not {@code null}
      * @since 2.5
      */
     public static boolean isNotEmpty(final byte[] array) {
@@ -4961,10 +4961,10 @@ public class ArrayUtils {
     }
 
     /**
-     * <p>Checks if an array of primitive doubles is not empty or not {@code null}.
+     * <p>Checks if an array of primitive doubles is not empty and not {@code null}.
      *
      * @param array  the array to test
-     * @return {@code true} if the array is not empty or not {@code null}
+     * @return {@code true} if the array is not empty and not {@code null}
      * @since 2.5
      */
     public static boolean isNotEmpty(final double[] array) {
@@ -4972,10 +4972,10 @@ public class ArrayUtils {
     }
 
     /**
-     * <p>Checks if an array of primitive floats is not empty or not {@code null}.
+     * <p>Checks if an array of primitive floats is not empty and not {@code null}.
      *
      * @param array  the array to test
-     * @return {@code true} if the array is not empty or not {@code null}
+     * @return {@code true} if the array is not empty and not {@code null}
      * @since 2.5
      */
     public static boolean isNotEmpty(final float[] array) {
@@ -4983,10 +4983,10 @@ public class ArrayUtils {
     }
 
     /**
-     * <p>Checks if an array of primitive booleans is not empty or not {@code null}.
+     * <p>Checks if an array of primitive booleans is not empty and not {@code null}.
      *
      * @param array  the array to test
-     * @return {@code true} if the array is not empty or not {@code null}
+     * @return {@code true} if the array is not empty and not {@code null}
      * @since 2.5
      */
     public static boolean isNotEmpty(final boolean[] array) {


Mime
View raw message