commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1746378 [3/13] - in /commons/proper/bcel/trunk/src: main/java/org/apache/commons/bcel6/ main/java/org/apache/commons/bcel6/classfile/ main/java/org/apache/commons/bcel6/generic/ main/java/org/apache/commons/bcel6/util/ main/java/org/apache...
Date Wed, 01 Jun 2016 04:25:32 GMT
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Field.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Field.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Field.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Field.java Wed Jun  1 04:25:27 2016
@@ -35,7 +35,7 @@ public final class Field extends FieldOr
     private static BCELComparator _cmp = new BCELComparator() {
 
         @Override
-        public boolean equals( Object o1, Object o2 ) {
+        public boolean equals( final Object o1, final Object o2 ) {
             Field THIS = (Field) o1;
             Field THAT = (Field) o2;
             return THIS.getName().equals(THAT.getName())
@@ -44,7 +44,7 @@ public final class Field extends FieldOr
 
 
         @Override
-        public int hashCode( Object o ) {
+        public int hashCode( final Object o ) {
             Field THIS = (Field) o;
             return THIS.getSignature().hashCode() ^ THIS.getName().hashCode();
         }
@@ -55,7 +55,7 @@ public final class Field extends FieldOr
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use clone() for a physical copy.
      */
-    public Field(Field c) {
+    public Field(final Field c) {
         super(c);
     }
 
@@ -64,7 +64,7 @@ public final class Field extends FieldOr
      * Construct object from file stream.
      * @param file Input stream
      */
-    Field(DataInput file, ConstantPool constant_pool) throws IOException,
+    Field(final DataInput file, final ConstantPool constant_pool) throws IOException,
             ClassFormatException {
         super(file, constant_pool);
     }
@@ -77,8 +77,8 @@ public final class Field extends FieldOr
      * @param attributes Collection of attributes
      * @param constant_pool Array of constants
      */
-    public Field(int access_flags, int name_index, int signature_index, Attribute[] attributes,
-            ConstantPool constant_pool) {
+    public Field(final int access_flags, final int name_index, final int signature_index, final Attribute[] attributes,
+            final ConstantPool constant_pool) {
         super(access_flags, name_index, signature_index, attributes, constant_pool);
     }
 
@@ -91,7 +91,7 @@ public final class Field extends FieldOr
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitField(this);
     }
 
@@ -144,7 +144,7 @@ public final class Field extends FieldOr
     /**
      * @return deep copy of this field
      */
-    public final Field copy( ConstantPool _constant_pool ) {
+    public final Field copy( final ConstantPool _constant_pool ) {
         return (Field) copy_(_constant_pool);
     }
 
@@ -168,7 +168,7 @@ public final class Field extends FieldOr
     /**
      * @param comparator Comparison strategy object
      */
-    public static void setComparator( BCELComparator comparator ) {
+    public static void setComparator( final BCELComparator comparator ) {
         _cmp = comparator;
     }
 
@@ -181,7 +181,7 @@ public final class Field extends FieldOr
      * @see java.lang.Object#equals(java.lang.Object)
      */
     @Override
-    public boolean equals( Object obj ) {
+    public boolean equals( final Object obj ) {
         return _cmp.equals(this, obj);
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/FieldOrMethod.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/FieldOrMethod.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/FieldOrMethod.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/FieldOrMethod.java Wed Jun  1 04:25:27 2016
@@ -75,7 +75,7 @@ public abstract class FieldOrMethod exte
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use clone() for a physical copy.
      */
-    protected FieldOrMethod(FieldOrMethod c) {
+    protected FieldOrMethod(final FieldOrMethod c) {
         this(c.getAccessFlags(), c.getNameIndex(), c.getSignatureIndex(), c.getAttributes(), c
                 .getConstantPool());
     }
@@ -88,7 +88,7 @@ public abstract class FieldOrMethod exte
      * @throws ClassFormatException
      * @deprecated Use {@link #FieldOrMethod(java.io.DataInput, ConstantPool)} instead.
      */
-    protected FieldOrMethod(DataInputStream file, ConstantPool constant_pool) throws IOException,
+    protected FieldOrMethod(final DataInputStream file, final ConstantPool constant_pool) throws IOException,
             ClassFormatException {
         this((DataInput) file, constant_pool);
     }
@@ -99,7 +99,7 @@ public abstract class FieldOrMethod exte
      * @throws IOException
      * @throws ClassFormatException
      */
-    protected FieldOrMethod(DataInput file, ConstantPool constant_pool) throws IOException, ClassFormatException {
+    protected FieldOrMethod(final DataInput file, final ConstantPool constant_pool) throws IOException, ClassFormatException {
         this(file.readUnsignedShort(), file.readUnsignedShort(), file.readUnsignedShort(), null,
                 constant_pool);
         int attributes_count = file.readUnsignedShort();
@@ -118,8 +118,8 @@ public abstract class FieldOrMethod exte
      * @param attributes Collection of attributes
      * @param constant_pool Array of constants
      */
-    protected FieldOrMethod(int access_flags, int name_index, int signature_index,
-            Attribute[] attributes, ConstantPool constant_pool) {
+    protected FieldOrMethod(final int access_flags, final int name_index, final int signature_index,
+            final Attribute[] attributes, final ConstantPool constant_pool) {
         super(access_flags);
         this.name_index = name_index;
         this.signature_index = signature_index;
@@ -134,7 +134,7 @@ public abstract class FieldOrMethod exte
      * @param file Output file stream
      * @throws IOException
      */
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         file.writeShort(super.getAccessFlags());
         file.writeShort(name_index);
         file.writeShort(signature_index);
@@ -156,7 +156,7 @@ public abstract class FieldOrMethod exte
     /**
      * @param attributes Collection of object attributes.
      */
-    public final void setAttributes( Attribute[] attributes ) {
+    public final void setAttributes( final Attribute[] attributes ) {
         this.attributes = attributes;
         this.attributes_count = attributes != null ? attributes.length : 0; // init deprecated field
     }
@@ -173,7 +173,7 @@ public abstract class FieldOrMethod exte
     /**
      * @param constant_pool Constant pool to be used for this object.
      */
-    public final void setConstantPool( ConstantPool constant_pool ) {
+    public final void setConstantPool( final ConstantPool constant_pool ) {
         this.constant_pool = constant_pool;
     }
 
@@ -189,7 +189,7 @@ public abstract class FieldOrMethod exte
     /**
      * @param name_index Index in constant pool of object's name.
      */
-    public final void setNameIndex( int name_index ) {
+    public final void setNameIndex( final int name_index ) {
         this.name_index = name_index;
     }
 
@@ -205,7 +205,7 @@ public abstract class FieldOrMethod exte
     /**
      * @param signature_index Index in constant pool of field signature.
      */
-    public final void setSignatureIndex( int signature_index ) {
+    public final void setSignatureIndex( final int signature_index ) {
         this.signature_index = signature_index;
     }
 
@@ -233,7 +233,7 @@ public abstract class FieldOrMethod exte
     /**
      * @return deep copy of this field
      */
-    protected FieldOrMethod copy_( ConstantPool _constant_pool ) {
+    protected FieldOrMethod copy_( final ConstantPool _constant_pool ) {
         FieldOrMethod c = null;
 
         try {

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClass.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClass.java Wed Jun  1 04:25:27 2016
@@ -42,7 +42,7 @@ public final class InnerClass implements
     /**
      * Initialize from another object.
      */
-    public InnerClass(InnerClass c) {
+    public InnerClass(final InnerClass c) {
         this(c.getInnerClassIndex(), c.getOuterClassIndex(), c.getInnerNameIndex(), c
                 .getInnerAccessFlags());
     }
@@ -53,7 +53,7 @@ public final class InnerClass implements
      * @param file Input stream
      * @throws IOException
      */
-    InnerClass(DataInput file) throws IOException {
+    InnerClass(final DataInput file) throws IOException {
         this(file.readUnsignedShort(), file.readUnsignedShort(), file.readUnsignedShort(), file
                 .readUnsignedShort());
     }
@@ -65,8 +65,8 @@ public final class InnerClass implements
      * @param inner_name_index  Name index in constant pool of inner class
      * @param inner_access_flags Access flags of inner class
      */
-    public InnerClass(int inner_class_index, int outer_class_index, int inner_name_index,
-            int inner_access_flags) {
+    public InnerClass(final int inner_class_index, final int outer_class_index, final int inner_name_index,
+            final int inner_access_flags) {
         this.inner_class_index = inner_class_index;
         this.outer_class_index = outer_class_index;
         this.inner_name_index = inner_name_index;
@@ -82,7 +82,7 @@ public final class InnerClass implements
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitInnerClass(this);
     }
 
@@ -93,7 +93,7 @@ public final class InnerClass implements
      * @param file Output file stream
      * @throws IOException
      */
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         file.writeShort(inner_class_index);
         file.writeShort(outer_class_index);
         file.writeShort(inner_name_index);
@@ -136,7 +136,7 @@ public final class InnerClass implements
     /**
      * @param inner_access_flags access flags for this inner class
      */
-    public final void setInnerAccessFlags( int inner_access_flags ) {
+    public final void setInnerAccessFlags( final int inner_access_flags ) {
         this.inner_access_flags = inner_access_flags;
     }
 
@@ -144,7 +144,7 @@ public final class InnerClass implements
     /**
      * @param inner_class_index index into the constant pool for this class
      */
-    public final void setInnerClassIndex( int inner_class_index ) {
+    public final void setInnerClassIndex( final int inner_class_index ) {
         this.inner_class_index = inner_class_index;
     }
 
@@ -152,7 +152,7 @@ public final class InnerClass implements
     /**
      * @param inner_name_index index into the constant pool for this class's name
      */
-    public final void setInnerNameIndex( int inner_name_index ) { // TODO unused
+    public final void setInnerNameIndex( final int inner_name_index ) { // TODO unused
         this.inner_name_index = inner_name_index;
     }
 
@@ -160,7 +160,7 @@ public final class InnerClass implements
     /**
      * @param outer_class_index index into the constant pool for the owning class
      */
-    public final void setOuterClassIndex( int outer_class_index ) { // TODO unused
+    public final void setOuterClassIndex( final int outer_class_index ) { // TODO unused
         this.outer_class_index = outer_class_index;
     }
 
@@ -178,7 +178,7 @@ public final class InnerClass implements
     /**
      * @return Resolved string representation
      */
-    public final String toString( ConstantPool constant_pool ) {
+    public final String toString( final ConstantPool constant_pool ) {
         String outer_class_name;
         String inner_name;
         String inner_class_name = constant_pool.getConstantString(inner_class_index,

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClasses.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClasses.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClasses.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/InnerClasses.java Wed Jun  1 04:25:27 2016
@@ -41,7 +41,7 @@ public final class InnerClasses extends
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use clone() for a physical copy.
      */
-    public InnerClasses(InnerClasses c) {
+    public InnerClasses(final InnerClasses c) {
         this(c.getNameIndex(), c.getLength(), c.getInnerClasses(), c.getConstantPool());
     }
 
@@ -52,8 +52,8 @@ public final class InnerClasses extends
      * @param inner_classes array of inner classes attributes
      * @param constant_pool Array of constants
      */
-    public InnerClasses(int name_index, int length, InnerClass[] inner_classes,
-            ConstantPool constant_pool) {
+    public InnerClasses(final int name_index, final int length, final InnerClass[] inner_classes,
+            final ConstantPool constant_pool) {
         super(Const.ATTR_INNER_CLASSES, name_index, length, constant_pool);
         this.inner_classes = inner_classes != null ? inner_classes : new InnerClass[0];
     }
@@ -68,7 +68,7 @@ public final class InnerClasses extends
      * @param constant_pool Array of constants
      * @throws IOException
      */
-    InnerClasses(int name_index, int length, DataInput input, ConstantPool constant_pool)
+    InnerClasses(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool)
             throws IOException {
         this(name_index, length, (InnerClass[]) null, constant_pool);
         int number_of_classes = input.readUnsignedShort();
@@ -87,7 +87,7 @@ public final class InnerClasses extends
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitInnerClasses(this);
     }
 
@@ -99,7 +99,7 @@ public final class InnerClasses extends
      * @throws IOException
      */
     @Override
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         super.dump(file);
         file.writeShort(inner_classes.length);
         for (InnerClass inner_class : inner_classes) {
@@ -119,7 +119,7 @@ public final class InnerClasses extends
     /**
      * @param inner_classes the array of inner classes
      */
-    public final void setInnerClasses( InnerClass[] inner_classes ) {
+    public final void setInnerClasses( final InnerClass[] inner_classes ) {
         this.inner_classes = inner_classes != null ? inner_classes : new InnerClass[0];
     }
 
@@ -144,7 +144,7 @@ public final class InnerClasses extends
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy( ConstantPool _constant_pool ) {
+    public Attribute copy( final ConstantPool _constant_pool ) {
         // TODO this could be recoded to use a lower level constructor after creating a copy of the inner classes
         InnerClasses c = (InnerClasses) clone();
         c.inner_classes = new InnerClass[inner_classes.length];

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java Wed Jun  1 04:25:27 2016
@@ -76,7 +76,7 @@ public class JavaClass extends AccessFla
     private static BCELComparator _cmp = new BCELComparator() {
 
         @Override
-        public boolean equals( Object o1, Object o2 ) {
+        public boolean equals( final Object o1, final Object o2 ) {
             JavaClass THIS = (JavaClass) o1;
             JavaClass THAT = (JavaClass) o2;
             return THIS.getClassName().equals(THAT.getClassName());
@@ -84,7 +84,7 @@ public class JavaClass extends AccessFla
 
 
         @Override
-        public int hashCode( Object o ) {
+        public int hashCode( final Object o ) {
             JavaClass THIS = (JavaClass) o;
             return THIS.getClassName().hashCode();
         }
@@ -116,9 +116,9 @@ public class JavaClass extends AccessFla
      * @param attributes Class attributes
      * @param source Read from file or generated in memory?
      */
-    public JavaClass(int class_name_index, int superclass_name_index, String file_name, int major,
-            int minor, int access_flags, ConstantPool constant_pool, int[] interfaces,
-            Field[] fields, Method[] methods, Attribute[] attributes, byte source) {
+    public JavaClass(final int class_name_index, final int superclass_name_index, final String file_name, final int major,
+            final int minor, final int access_flags, final ConstantPool constant_pool, int[] interfaces,
+            Field[] fields, Method[] methods, Attribute[] attributes, final byte source) {
         super(access_flags);
         if (interfaces == null) {
             interfaces = new int[0];
@@ -193,9 +193,9 @@ public class JavaClass extends AccessFla
      * @param methods Class methods
      * @param attributes Class attributes
      */
-    public JavaClass(int class_name_index, int superclass_name_index, String file_name, int major,
-            int minor, int access_flags, ConstantPool constant_pool, int[] interfaces,
-            Field[] fields, Method[] methods, Attribute[] attributes) {
+    public JavaClass(final int class_name_index, final int superclass_name_index, final String file_name, final int major,
+            final int minor, final int access_flags, final ConstantPool constant_pool, final int[] interfaces,
+            final Field[] fields, final Method[] methods, final Attribute[] attributes) {
         this(class_name_index, superclass_name_index, file_name, major, minor, access_flags,
                 constant_pool, interfaces, fields, methods, attributes, HEAP);
     }
@@ -209,14 +209,14 @@ public class JavaClass extends AccessFla
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitJavaClass(this);
     }
 
 
     /* Print debug information depending on `JavaClass.debug'
      */
-    static void Debug( String str ) {
+    static void Debug( final String str ) {
         if (debug) {
             System.out.println(str);
         }
@@ -229,7 +229,7 @@ public class JavaClass extends AccessFla
      * @param file Output file
      * @throws IOException
      */
-    public void dump( File file ) throws IOException {
+    public void dump( final File file ) throws IOException {
         String parent = file.getParent();
         if (parent != null) {
             File dir = new File(parent);
@@ -257,7 +257,7 @@ public class JavaClass extends AccessFla
      * @param _file_name Output file name
      * @exception IOException
      */
-    public void dump( String _file_name ) throws IOException {
+    public void dump( final String _file_name ) throws IOException {
         dump(new File(_file_name));
     }
 
@@ -289,7 +289,7 @@ public class JavaClass extends AccessFla
      * @param file Output stream
      * @exception IOException
      */
-    public void dump( OutputStream file ) throws IOException {
+    public void dump( final OutputStream file ) throws IOException {
         dump(new DataOutputStream(file));
     }
 
@@ -300,7 +300,7 @@ public class JavaClass extends AccessFla
      * @param file Output stream
      * @exception IOException
      */
-    public void dump( DataOutputStream file ) throws IOException {
+    public void dump( final DataOutputStream file ) throws IOException {
         file.writeInt(Const.JVM_CLASSFILE_MAGIC);
         file.writeShort(minor);
         file.writeShort(major);
@@ -437,7 +437,7 @@ public class JavaClass extends AccessFla
      * @return A {@link Method} corresponding to
      * java.lang.reflect.Method if any
      */
-    public Method getMethod( java.lang.reflect.Method m ) {
+    public Method getMethod( final java.lang.reflect.Method m ) {
         for (Method method : methods) {
             if (m.getName().equals(method.getName()) && (m.getModifiers() == method.getModifiers())
                     && Type.getSignature(m).equals(method.getSignature())) {
@@ -486,7 +486,7 @@ public class JavaClass extends AccessFla
     /**
      * @param attributes .
      */
-    public void setAttributes( Attribute[] attributes ) {
+    public void setAttributes( final Attribute[] attributes ) {
         this.attributes = attributes;
     }
 
@@ -494,7 +494,7 @@ public class JavaClass extends AccessFla
     /**
      * @param class_name .
      */
-    public void setClassName( String class_name ) {
+    public void setClassName( final String class_name ) {
         this.class_name = class_name;
     }
 
@@ -502,7 +502,7 @@ public class JavaClass extends AccessFla
     /**
      * @param class_name_index .
      */
-    public void setClassNameIndex( int class_name_index ) {
+    public void setClassNameIndex( final int class_name_index ) {
         this.class_name_index = class_name_index;
     }
 
@@ -510,7 +510,7 @@ public class JavaClass extends AccessFla
     /**
      * @param constant_pool .
      */
-    public void setConstantPool( ConstantPool constant_pool ) {
+    public void setConstantPool( final ConstantPool constant_pool ) {
         this.constant_pool = constant_pool;
     }
 
@@ -518,7 +518,7 @@ public class JavaClass extends AccessFla
     /**
      * @param fields .
      */
-    public void setFields( Field[] fields ) {
+    public void setFields( final Field[] fields ) {
         this.fields = fields;
     }
 
@@ -526,7 +526,7 @@ public class JavaClass extends AccessFla
     /**
      * Set File name of class, aka SourceFile attribute value
      */
-    public void setFileName( String file_name ) {
+    public void setFileName( final String file_name ) {
         this.file_name = file_name;
     }
 
@@ -534,7 +534,7 @@ public class JavaClass extends AccessFla
     /**
      * @param interface_names .
      */
-    public void setInterfaceNames( String[] interface_names ) {
+    public void setInterfaceNames( final String[] interface_names ) {
         this.interface_names = interface_names;
     }
 
@@ -542,7 +542,7 @@ public class JavaClass extends AccessFla
     /**
      * @param interfaces .
      */
-    public void setInterfaces( int[] interfaces ) {
+    public void setInterfaces( final int[] interfaces ) {
         this.interfaces = interfaces;
     }
 
@@ -550,7 +550,7 @@ public class JavaClass extends AccessFla
     /**
      * @param major .
      */
-    public void setMajor( int major ) {
+    public void setMajor( final int major ) {
         this.major = major;
     }
 
@@ -558,7 +558,7 @@ public class JavaClass extends AccessFla
     /**
      * @param methods .
      */
-    public void setMethods( Method[] methods ) {
+    public void setMethods( final Method[] methods ) {
         this.methods = methods;
     }
 
@@ -566,7 +566,7 @@ public class JavaClass extends AccessFla
     /**
      * @param minor .
      */
-    public void setMinor( int minor ) {
+    public void setMinor( final int minor ) {
         this.minor = minor;
     }
 
@@ -574,7 +574,7 @@ public class JavaClass extends AccessFla
     /**
      * Set absolute path to file this class was read from.
      */
-    public void setSourceFileName( String source_file_name ) {
+    public void setSourceFileName( final String source_file_name ) {
         this.source_file_name = source_file_name;
     }
 
@@ -582,7 +582,7 @@ public class JavaClass extends AccessFla
     /**
      * @param superclass_name .
      */
-    public void setSuperclassName( String superclass_name ) {
+    public void setSuperclassName( final String superclass_name ) {
         this.superclass_name = superclass_name;
     }
 
@@ -590,7 +590,7 @@ public class JavaClass extends AccessFla
     /**
      * @param superclass_name_index .
      */
-    public void setSuperclassNameIndex( int superclass_name_index ) {
+    public void setSuperclassNameIndex( final int superclass_name_index ) {
         this.superclass_name_index = superclass_name_index;
     }
 
@@ -652,7 +652,7 @@ public class JavaClass extends AccessFla
     }
 
 
-    private static String indent( Object obj ) {
+    private static String indent( final Object obj ) {
         StringTokenizer tok = new StringTokenizer(obj.toString(), "\n");
         StringBuilder buf = new StringBuilder();
         while (tok.hasMoreTokens()) {
@@ -765,7 +765,7 @@ public class JavaClass extends AccessFla
      * Sets the ClassRepository which loaded the JavaClass.
      * Should be called immediately after parsing is done.
      */
-    public void setRepository( org.apache.commons.bcel6.util.Repository repository ) { // TODO make protected?
+    public void setRepository( final org.apache.commons.bcel6.util.Repository repository ) { // TODO make protected?
         this.repository = repository;
     }
 
@@ -776,7 +776,7 @@ public class JavaClass extends AccessFla
      * @throws ClassNotFoundException if superclasses or superinterfaces
      *   of this object can't be found
      */
-    public final boolean instanceOf( JavaClass super_class ) throws ClassNotFoundException {
+    public final boolean instanceOf( final JavaClass super_class ) throws ClassNotFoundException {
         if (this.equals(super_class)) {
             return true;
         }
@@ -798,7 +798,7 @@ public class JavaClass extends AccessFla
      * @throws ClassNotFoundException if superclasses or superinterfaces
      *   of this class can't be found
      */
-    public boolean implementationOf( JavaClass inter ) throws ClassNotFoundException {
+    public boolean implementationOf( final JavaClass inter ) throws ClassNotFoundException {
         if (!inter.isInterface()) {
             throw new IllegalArgumentException(inter.getClassName() + " is no interface");
         }
@@ -893,7 +893,7 @@ public class JavaClass extends AccessFla
     /**
      * @param comparator Comparison strategy object
      */
-    public static void setComparator( BCELComparator comparator ) {
+    public static void setComparator( final BCELComparator comparator ) {
         _cmp = comparator;
     }
 
@@ -906,7 +906,7 @@ public class JavaClass extends AccessFla
      * @see java.lang.Object#equals(java.lang.Object)
      */
     @Override
-    public boolean equals( Object obj ) {
+    public boolean equals( final Object obj ) {
         return _cmp.equals(this, obj);
     }
 
@@ -917,7 +917,7 @@ public class JavaClass extends AccessFla
      * @since 6.0
      */
     @Override
-    public int compareTo( JavaClass obj ) {
+    public int compareTo( final JavaClass obj ) {
         return getClassName().compareTo(obj.getClassName());
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumber.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumber.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumber.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumber.java Wed Jun  1 04:25:27 2016
@@ -42,7 +42,7 @@ public final class LineNumber implements
      * 
      * @param c the object to copy
      */
-    public LineNumber(LineNumber c) {
+    public LineNumber(final LineNumber c) {
         this(c.getStartPC(), c.getLineNumber());
     }
 
@@ -53,7 +53,7 @@ public final class LineNumber implements
      * @param file Input stream
      * @throws IOEXception if an I/O Exception occurs in readUnsignedShort
      */
-    LineNumber(DataInput file) throws IOException {
+    LineNumber(final DataInput file) throws IOException {
         this(file.readUnsignedShort(), file.readUnsignedShort());
     }
 
@@ -62,7 +62,7 @@ public final class LineNumber implements
      * @param start_pc Program Counter (PC) corresponds to
      * @param line_number line number in source file
      */
-    public LineNumber(int start_pc, int line_number) {
+    public LineNumber(final int start_pc, final int line_number) {
         this.start_pc = (short) start_pc;
         this.line_number = (short)line_number;
     }
@@ -76,7 +76,7 @@ public final class LineNumber implements
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitLineNumber(this);
     }
 
@@ -87,7 +87,7 @@ public final class LineNumber implements
      * @param file Output file stream
      * @throws IOEXception if an I/O Exception occurs in writeShort
      */
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         file.writeShort(start_pc);
         file.writeShort(line_number);
     }
@@ -112,7 +112,7 @@ public final class LineNumber implements
     /**
      * @param line_number the source line number
      */
-    public final void setLineNumber( int line_number ) {
+    public final void setLineNumber( final int line_number ) {
         this.line_number = (short) line_number;
     }
 
@@ -120,7 +120,7 @@ public final class LineNumber implements
     /**
      * @param start_pc the pc for this line number
      */
-    public final void setStartPC( int start_pc ) {
+    public final void setStartPC( final int start_pc ) {
         this.start_pc = (short) start_pc;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumberTable.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumberTable.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumberTable.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LineNumberTable.java Wed Jun  1 04:25:27 2016
@@ -42,7 +42,7 @@ public final class LineNumberTable exten
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use copy() for a physical copy.
      */
-    public LineNumberTable(LineNumberTable c) {
+    public LineNumberTable(final LineNumberTable c) {
         this(c.getNameIndex(), c.getLength(), c.getLineNumberTable(), c.getConstantPool());
     }
 
@@ -53,8 +53,8 @@ public final class LineNumberTable exten
      * @param line_number_table Table of line/numbers pairs
      * @param constant_pool Array of constants
      */
-    public LineNumberTable(int name_index, int length, LineNumber[] line_number_table,
-            ConstantPool constant_pool) {
+    public LineNumberTable(final int name_index, final int length, final LineNumber[] line_number_table,
+            final ConstantPool constant_pool) {
         super(Const.ATTR_LINE_NUMBER_TABLE, name_index, length, constant_pool);
         this.line_number_table = line_number_table;
     }
@@ -68,7 +68,7 @@ public final class LineNumberTable exten
      * @param constant_pool Array of constants
      * @throws IOEXception if an I/O Exception occurs in readUnsignedShort
      */
-    LineNumberTable(int name_index, int length, DataInput input, ConstantPool constant_pool)
+    LineNumberTable(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool)
             throws IOException {
         this(name_index, length, (LineNumber[]) null, constant_pool);
         int line_number_table_length = input.readUnsignedShort();
@@ -87,7 +87,7 @@ public final class LineNumberTable exten
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitLineNumberTable(this);
     }
 
@@ -99,7 +99,7 @@ public final class LineNumberTable exten
      * @throws IOEXception if an I/O Exception occurs in writeShort
      */
     @Override
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         super.dump(file);
         file.writeShort(line_number_table.length);
         for (LineNumber lineNumber : line_number_table) {
@@ -119,7 +119,7 @@ public final class LineNumberTable exten
     /**
      * @param line_number_table the line number entries for this table
      */
-    public final void setLineNumberTable( LineNumber[] line_number_table ) {
+    public final void setLineNumberTable( final LineNumber[] line_number_table ) {
         this.line_number_table = line_number_table;
     }
 
@@ -154,7 +154,7 @@ public final class LineNumberTable exten
      * @param pos byte code offset
      * @return corresponding line in source code
      */
-    public int getSourceLine( int pos ) {
+    public int getSourceLine( final int pos ) {
         int l = 0;
         int r = line_number_table.length - 1;
         if (r < 0) {
@@ -197,7 +197,7 @@ public final class LineNumberTable exten
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy( ConstantPool _constant_pool ) {
+    public Attribute copy( final ConstantPool _constant_pool ) {
         // TODO could use the lower level constructor and thereby allow 
         // line_number_table to be made final
         LineNumberTable c = (LineNumberTable) clone();

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariable.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariable.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariable.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariable.java Wed Jun  1 04:25:27 2016
@@ -46,7 +46,7 @@ public final class LocalVariable impleme
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use copy() for a physical copy.
      */
-    public LocalVariable(LocalVariable c) {
+    public LocalVariable(final LocalVariable c) {
         this(c.getStartPC(), c.getLength(), c.getNameIndex(), c.getSignatureIndex(), c.getIndex(),
                 c.getConstantPool());
     }
@@ -57,7 +57,7 @@ public final class LocalVariable impleme
      * @param file Input stream
      * @throws IOException
      */
-    LocalVariable(DataInput file, ConstantPool constant_pool) throws IOException {
+    LocalVariable(final DataInput file, final ConstantPool constant_pool) throws IOException {
         this(file.readUnsignedShort(), file.readUnsignedShort(), file.readUnsignedShort(), file
                 .readUnsignedShort(), file.readUnsignedShort(), constant_pool);
     }
@@ -71,8 +71,8 @@ public final class LocalVariable impleme
      * @param index Variable is `index'th local variable on the method's frame
      * @param constant_pool Array of constants
      */
-    public LocalVariable(int start_pc, int length, int name_index, int signature_index, int index,
-            ConstantPool constant_pool) {
+    public LocalVariable(final int start_pc, final int length, final int name_index, final int signature_index, final int index,
+            final ConstantPool constant_pool) {
         this.start_pc = start_pc;
         this.length = length;
         this.name_index = name_index;
@@ -90,7 +90,7 @@ public final class LocalVariable impleme
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitLocalVariable(this);
     }
 
@@ -101,7 +101,7 @@ public final class LocalVariable impleme
      * @param file Output file stream
      * @throws IOException
      */
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         file.writeShort(start_pc);
         file.writeShort(length);
         file.writeShort(name_index);
@@ -181,7 +181,7 @@ public final class LocalVariable impleme
     /*
      * Helper method shared with LocalVariableTypeTable
      */
-    final String toStringShared( boolean typeTable ) {
+    final String toStringShared( final boolean typeTable ) {
         String name = getName();
         String signature = Utility.signatureToString(getSignature(), false);
         String label = "LocalVariable" + (typeTable ? "Types" : "" );
@@ -193,7 +193,7 @@ public final class LocalVariable impleme
     /**
      * @param constant_pool Constant pool to be used for this object.
      */
-    public final void setConstantPool( ConstantPool constant_pool ) {
+    public final void setConstantPool( final ConstantPool constant_pool ) {
         this.constant_pool = constant_pool;
     }
 
@@ -201,7 +201,7 @@ public final class LocalVariable impleme
     /**
      * @param length the length of this local variable
      */
-    public final void setLength( int length ) {
+    public final void setLength( final int length ) {
         this.length = length;
     }
 
@@ -209,7 +209,7 @@ public final class LocalVariable impleme
     /**
      * @param name_index the index into the constant pool for the name of this variable
      */
-    public final void setNameIndex( int name_index ) { // TODO unused
+    public final void setNameIndex( final int name_index ) { // TODO unused
         this.name_index = name_index;
     }
 
@@ -217,7 +217,7 @@ public final class LocalVariable impleme
     /**
      * @param signature_index the index into the constant pool for the signature of this variable
      */
-    public final void setSignatureIndex( int signature_index ) { // TODO unused
+    public final void setSignatureIndex( final int signature_index ) { // TODO unused
         this.signature_index = signature_index;
     }
 
@@ -225,7 +225,7 @@ public final class LocalVariable impleme
     /**
      * @param index the index in the local variable table of this variable
      */
-    public final void setIndex( int index ) { // TODO unused
+    public final void setIndex( final int index ) { // TODO unused
         this.index = index;
     }
 
@@ -233,7 +233,7 @@ public final class LocalVariable impleme
     /**
      * @param start_pc Specify range where the local variable is valid.
      */
-    public final void setStartPC( int start_pc ) { // TODO unused
+    public final void setStartPC( final int start_pc ) { // TODO unused
         this.start_pc = start_pc;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTable.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTable.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTable.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTable.java Wed Jun  1 04:25:27 2016
@@ -40,7 +40,7 @@ public class LocalVariableTable extends
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use copy() for a physical copy.
      */
-    public LocalVariableTable(LocalVariableTable c) {
+    public LocalVariableTable(final LocalVariableTable c) {
         this(c.getNameIndex(), c.getLength(), c.getLocalVariableTable(), c.getConstantPool());
     }
 
@@ -51,8 +51,8 @@ public class LocalVariableTable extends
      * @param local_variable_table Table of local variables
      * @param constant_pool Array of constants
      */
-    public LocalVariableTable(int name_index, int length, LocalVariable[] local_variable_table,
-            ConstantPool constant_pool) {
+    public LocalVariableTable(final int name_index, final int length, final LocalVariable[] local_variable_table,
+            final ConstantPool constant_pool) {
         super(Const.ATTR_LOCAL_VARIABLE_TABLE, name_index, length, constant_pool);
         this.local_variable_table = local_variable_table;
     }
@@ -66,7 +66,7 @@ public class LocalVariableTable extends
      * @param constant_pool Array of constants
      * @throws IOException
      */
-    LocalVariableTable(int name_index, int length, DataInput input, ConstantPool constant_pool)
+    LocalVariableTable(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool)
             throws IOException {
         this(name_index, length, (LocalVariable[]) null, constant_pool);
         int local_variable_table_length = input.readUnsignedShort();
@@ -85,7 +85,7 @@ public class LocalVariableTable extends
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitLocalVariableTable(this);
     }
 
@@ -97,7 +97,7 @@ public class LocalVariableTable extends
      * @throws IOException
      */
     @Override
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         super.dump(file);
         file.writeShort(local_variable_table.length);
         for (LocalVariable variable : local_variable_table) {
@@ -124,7 +124,7 @@ public class LocalVariableTable extends
      *             same slot, use getLocalVariable(int index, int pc) instead.
      */
     @java.lang.Deprecated
-    public final LocalVariable getLocalVariable( int index ) {
+    public final LocalVariable getLocalVariable( final int index ) {
         for (LocalVariable variable : local_variable_table) {
             if (variable.getIndex() == index) {
                 return variable;
@@ -141,7 +141,7 @@ public class LocalVariableTable extends
      * 
      * @return the LocalVariable that matches or null if not found
      */
-    public final LocalVariable getLocalVariable( int index, int pc ) {
+    public final LocalVariable getLocalVariable( final int index, final int pc ) {
         for (LocalVariable variable : local_variable_table) {
             if (variable.getIndex() == index) {
                 int start_pc = variable.getStartPC();
@@ -155,7 +155,7 @@ public class LocalVariableTable extends
     }
 
 
-    public final void setLocalVariableTable( LocalVariable[] local_variable_table ) {
+    public final void setLocalVariableTable( final LocalVariable[] local_variable_table ) {
         this.local_variable_table = local_variable_table;
     }
 
@@ -180,7 +180,7 @@ public class LocalVariableTable extends
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy( ConstantPool _constant_pool ) {
+    public Attribute copy( final ConstantPool _constant_pool ) {
         LocalVariableTable c = (LocalVariableTable) clone();
         c.local_variable_table = new LocalVariable[local_variable_table.length];
         for (int i = 0; i < local_variable_table.length; i++) {

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java Wed Jun  1 04:25:27 2016
@@ -58,16 +58,16 @@ public class LocalVariableTypeTable exte
 
     private LocalVariable[] local_variable_type_table;        // variables
 
-    public LocalVariableTypeTable(LocalVariableTypeTable c) {
+    public LocalVariableTypeTable(final LocalVariableTypeTable c) {
         this(c.getNameIndex(), c.getLength(), c.getLocalVariableTypeTable(), c.getConstantPool());
     }
 
-    public LocalVariableTypeTable(int name_index, int length, LocalVariable[] local_variable_table, ConstantPool constant_pool) {
+    public LocalVariableTypeTable(final int name_index, final int length, final LocalVariable[] local_variable_table, final ConstantPool constant_pool) {
         super(Const.ATTR_LOCAL_VARIABLE_TYPE_TABLE, name_index, length, constant_pool);
         this.local_variable_type_table = local_variable_table;
     }
 
-    LocalVariableTypeTable(int nameIdx, int len, DataInput input, ConstantPool cpool) throws IOException {
+    LocalVariableTypeTable(final int nameIdx, final int len, final DataInput input, final ConstantPool cpool) throws IOException {
         this(nameIdx, len, (LocalVariable[]) null, cpool);
 
         int local_variable_type_table_length = input.readUnsignedShort();
@@ -79,12 +79,12 @@ public class LocalVariableTypeTable exte
     }
 
     @Override
-    public void accept(Visitor v) {
+    public void accept(final Visitor v) {
         v.visitLocalVariableTypeTable(this);
     }
 
     @Override
-    public final void dump(DataOutputStream file) throws IOException {
+    public final void dump(final DataOutputStream file) throws IOException {
         super.dump(file);
         file.writeShort(local_variable_type_table.length);
         for (LocalVariable variable : local_variable_type_table) {
@@ -96,7 +96,7 @@ public class LocalVariableTypeTable exte
         return local_variable_type_table;
     }
 
-    public final LocalVariable getLocalVariable(int index) {
+    public final LocalVariable getLocalVariable(final int index) {
         for (LocalVariable variable : local_variable_type_table) {
             if (variable.getIndex() == index) {
                 return variable;
@@ -106,7 +106,7 @@ public class LocalVariableTypeTable exte
         return null;
     }
 
-    public final void setLocalVariableTable(LocalVariable[] local_variable_table) {
+    public final void setLocalVariableTable(final LocalVariable[] local_variable_table) {
         this.local_variable_type_table = local_variable_table;
     }
 
@@ -132,7 +132,7 @@ public class LocalVariableTypeTable exte
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy(ConstantPool constant_pool) {
+    public Attribute copy(final ConstantPool constant_pool) {
         LocalVariableTypeTable c = (LocalVariableTypeTable) clone();
 
         c.local_variable_type_table = new LocalVariable[local_variable_type_table.length];

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Method.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Method.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Method.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Method.java Wed Jun  1 04:25:27 2016
@@ -36,7 +36,7 @@ public final class Method extends FieldO
     private static BCELComparator _cmp = new BCELComparator() {
 
         @Override
-        public boolean equals( Object o1, Object o2 ) {
+        public boolean equals( final Object o1, final Object o2 ) {
             Method THIS = (Method) o1;
             Method THAT = (Method) o2;
             return THIS.getName().equals(THAT.getName())
@@ -45,7 +45,7 @@ public final class Method extends FieldO
 
 
         @Override
-        public int hashCode( Object o ) {
+        public int hashCode( final Object o ) {
             Method THIS = (Method) o;
             return THIS.getSignature().hashCode() ^ THIS.getName().hashCode();
         }
@@ -66,7 +66,7 @@ public final class Method extends FieldO
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use clone() for a physical copy.
      */
-    public Method(Method c) {
+    public Method(final Method c) {
         super(c);
     }
 
@@ -77,7 +77,7 @@ public final class Method extends FieldO
      * @throws IOException
      * @throws ClassFormatException
      */
-    Method(DataInput file, ConstantPool constant_pool) throws IOException,
+    Method(final DataInput file, final ConstantPool constant_pool) throws IOException,
             ClassFormatException {
         super(file, constant_pool);
     }
@@ -90,8 +90,8 @@ public final class Method extends FieldO
      * @param attributes Collection of attributes
      * @param constant_pool Array of constants
      */
-    public Method(int access_flags, int name_index, int signature_index, Attribute[] attributes,
-            ConstantPool constant_pool) {
+    public Method(final int access_flags, final int name_index, final int signature_index, final Attribute[] attributes,
+            final ConstantPool constant_pool) {
         super(access_flags, name_index, signature_index, attributes, constant_pool);
     }
 
@@ -104,7 +104,7 @@ public final class Method extends FieldO
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitMethod(this);
     }
 
@@ -196,7 +196,7 @@ public final class Method extends FieldO
     /**
      * @return deep copy of this method
      */
-    public final Method copy( ConstantPool _constant_pool ) {
+    public final Method copy( final ConstantPool _constant_pool ) {
         return (Method) copy_(_constant_pool);
     }
 
@@ -228,7 +228,7 @@ public final class Method extends FieldO
     /**
      * @param comparator Comparison strategy object
      */
-    public static void setComparator( BCELComparator comparator ) {
+    public static void setComparator( final BCELComparator comparator ) {
         _cmp = comparator;
     }
 
@@ -241,7 +241,7 @@ public final class Method extends FieldO
      * @see java.lang.Object#equals(java.lang.Object)
      */
     @Override
-    public boolean equals( Object obj ) {
+    public boolean equals( final Object obj ) {
         return _cmp.equals(this, obj);
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameter.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameter.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameter.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameter.java Wed Jun  1 04:25:27 2016
@@ -48,7 +48,7 @@ public class MethodParameter implements
      * @throws java.io.IOException
      * @throws ClassFormatException
      */
-    MethodParameter(DataInput input) throws IOException {
+    MethodParameter(final DataInput input) throws IOException {
         name_index = input.readUnsignedShort();
         access_flags = input.readUnsignedShort();
     }
@@ -57,14 +57,14 @@ public class MethodParameter implements
         return name_index;
     }
 
-    public void setNameIndex(int name_index) {
+    public void setNameIndex(final int name_index) {
         this.name_index = name_index;
     }
 
     /**
      * Returns the name of the parameter.
      */
-    public String getParameterName(ConstantPool constant_pool) {
+    public String getParameterName(final ConstantPool constant_pool) {
         if (name_index == 0) {
             return null;
         }
@@ -75,7 +75,7 @@ public class MethodParameter implements
         return access_flags;
     }
 
-    public void setAccessFlags(int access_flags) {
+    public void setAccessFlags(final int access_flags) {
         this.access_flags = access_flags;
     }
 
@@ -97,7 +97,7 @@ public class MethodParameter implements
      * @param file Output file stream
      * @throws IOException
      */
-    public final void dump(DataOutputStream file) throws IOException {
+    public final void dump(final DataOutputStream file) throws IOException {
         file.writeShort(name_index);
         file.writeShort(access_flags);
     }

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameters.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameters.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameters.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameters.java Wed Jun  1 04:25:27 2016
@@ -34,7 +34,7 @@ public class MethodParameters extends At
 
     private MethodParameter[] parameters = new MethodParameter[0];
 
-    MethodParameters(int name_index, int length, DataInput input, ConstantPool constant_pool) throws IOException {
+    MethodParameters(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool) throws IOException {
         super(Const.ATTR_METHOD_PARAMETERS, name_index, length, constant_pool);
 
         int parameters_count = input.readUnsignedByte();
@@ -48,17 +48,17 @@ public class MethodParameters extends At
         return parameters;
     }
 
-    public void setParameters(MethodParameter[] parameters) {
+    public void setParameters(final MethodParameter[] parameters) {
         this.parameters = parameters;
     }
 
     @Override
-    public void accept(Visitor v) {
+    public void accept(final Visitor v) {
         v.visitMethodParameters(this);
     }
 
     @Override
-    public Attribute copy(ConstantPool _constant_pool) {
+    public Attribute copy(final ConstantPool _constant_pool) {
         MethodParameters c = (MethodParameters) clone();
         c.parameters = new MethodParameter[parameters.length];
 
@@ -76,7 +76,7 @@ public class MethodParameters extends At
      * @throws IOException
      */
     @Override
-       public void dump(DataOutputStream file) throws IOException {
+       public void dump(final DataOutputStream file) throws IOException {
            super.dump(file);
            file.writeByte(parameters.length);
         for (MethodParameter parameter : parameters) {

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/PMGClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/PMGClass.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/PMGClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/PMGClass.java Wed Jun  1 04:25:27 2016
@@ -40,7 +40,7 @@ public final class PMGClass extends Attr
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use copy() for a physical copy.
      */
-    public PMGClass(PMGClass c) {
+    public PMGClass(final PMGClass c) {
         this(c.getNameIndex(), c.getLength(), c.getPMGIndex(), c.getPMGClassIndex(), c
                 .getConstantPool());
     }
@@ -54,7 +54,7 @@ public final class PMGClass extends Attr
      * @param constant_pool Array of constants
      * @throws IOException
      */
-    PMGClass(int name_index, int length, DataInput input, ConstantPool constant_pool)
+    PMGClass(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool)
             throws IOException {
         this(name_index, length, input.readUnsignedShort(), input.readUnsignedShort(), constant_pool);
     }
@@ -67,8 +67,8 @@ public final class PMGClass extends Attr
      * @param pmg_class_index Index in constant pool to CONSTANT_Utf8
      * @param constant_pool Array of constants
      */
-    public PMGClass(int name_index, int length, int pmg_index, int pmg_class_index,
-            ConstantPool constant_pool) {
+    public PMGClass(final int name_index, final int length, final int pmg_index, final int pmg_class_index,
+            final ConstantPool constant_pool) {
         super(Const.ATTR_PMG, name_index, length, constant_pool);
         this.pmg_index = pmg_index;
         this.pmg_class_index = pmg_class_index;
@@ -83,7 +83,7 @@ public final class PMGClass extends Attr
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         System.err.println("Visiting non-standard PMGClass object");
     }
 
@@ -95,7 +95,7 @@ public final class PMGClass extends Attr
      * @throws IOException
      */
     @Override
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         super.dump(file);
         file.writeShort(pmg_index);
         file.writeShort(pmg_class_index);
@@ -113,7 +113,7 @@ public final class PMGClass extends Attr
     /**
      * @param pmg_class_index
      */
-    public final void setPMGClassIndex( int pmg_class_index ) {
+    public final void setPMGClassIndex( final int pmg_class_index ) {
         this.pmg_class_index = pmg_class_index;
     }
 
@@ -129,7 +129,7 @@ public final class PMGClass extends Attr
     /**
      * @param pmg_index
      */
-    public final void setPMGIndex( int pmg_index ) {
+    public final void setPMGIndex( final int pmg_index ) {
         this.pmg_index = pmg_index;
     }
 
@@ -167,7 +167,7 @@ public final class PMGClass extends Attr
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy( ConstantPool _constant_pool ) {
+    public Attribute copy( final ConstantPool _constant_pool ) {
         return (Attribute) clone();
     }
 }

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotationEntry.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotationEntry.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotationEntry.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotationEntry.java Wed Jun  1 04:25:27 2016
@@ -41,7 +41,7 @@ public class ParameterAnnotationEntry im
      * @param input Input stream
      * @throws IOException
      */
-    ParameterAnnotationEntry(DataInput input, ConstantPool constant_pool) throws IOException {
+    ParameterAnnotationEntry(final DataInput input, final ConstantPool constant_pool) throws IOException {
         int annotation_table_length = input.readUnsignedShort();
         annotation_table = new AnnotationEntry[annotation_table_length];
         for (int i = 0; i < annotation_table_length; i++) {
@@ -59,7 +59,7 @@ public class ParameterAnnotationEntry im
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitParameterAnnotationEntry(this);
     }
 
@@ -70,14 +70,14 @@ public class ParameterAnnotationEntry im
         return annotation_table;
     }
 
-    public void dump(DataOutputStream dos) throws IOException {
+    public void dump(final DataOutputStream dos) throws IOException {
         dos.writeShort(annotation_table.length);
         for (AnnotationEntry entry : annotation_table) {
             entry.dump(dos);
         }
     }
 
-  public static ParameterAnnotationEntry[] createParameterAnnotationEntries(Attribute[] attrs) {
+  public static ParameterAnnotationEntry[] createParameterAnnotationEntries(final Attribute[] attrs) {
       // Find attributes that contain parameter annotation data
       List<ParameterAnnotationEntry> accumulatedAnnotations = new ArrayList<>(attrs.length);
       for (Attribute attribute : attrs) {

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java Wed Jun  1 04:25:27 2016
@@ -39,8 +39,8 @@ public abstract class ParameterAnnotatio
      * @param input Input stream
      * @param constant_pool Array of constants
      */
-    ParameterAnnotations(byte parameter_annotation_type, int name_index, int length,
-            DataInput input, ConstantPool constant_pool) throws IOException {
+    ParameterAnnotations(final byte parameter_annotation_type, final int name_index, final int length,
+            final DataInput input, final ConstantPool constant_pool) throws IOException {
         this(parameter_annotation_type, name_index, length, (ParameterAnnotationEntry[]) null,
                 constant_pool);
         int num_parameters = input.readUnsignedByte();
@@ -58,8 +58,8 @@ public abstract class ParameterAnnotatio
      * @param parameter_annotation_table the actual parameter annotations
      * @param constant_pool Array of constants
      */
-    public ParameterAnnotations(byte parameter_annotation_type, int name_index, int length,
-            ParameterAnnotationEntry[] parameter_annotation_table, ConstantPool constant_pool) {
+    public ParameterAnnotations(final byte parameter_annotation_type, final int name_index, final int length,
+            final ParameterAnnotationEntry[] parameter_annotation_table, final ConstantPool constant_pool) {
         super(parameter_annotation_type, name_index, length, constant_pool);
         this.parameter_annotation_table = parameter_annotation_table;
     }
@@ -73,7 +73,7 @@ public abstract class ParameterAnnotatio
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitParameterAnnotation(this);
     }
 
@@ -81,7 +81,7 @@ public abstract class ParameterAnnotatio
     /**
      * @param parameter_annotation_table the entries to set in this parameter annotation
      */
-    public final void setParameterAnnotationTable(ParameterAnnotationEntry[] parameter_annotation_table ) {
+    public final void setParameterAnnotationTable(final ParameterAnnotationEntry[] parameter_annotation_table ) {
         this.parameter_annotation_table = parameter_annotation_table;
     }
 
@@ -102,7 +102,7 @@ public abstract class ParameterAnnotatio
     }
 
     @Override
-    public void dump(DataOutputStream dos) throws IOException
+    public void dump(final DataOutputStream dos) throws IOException
     {
         super.dump(dos);
         dos.writeByte(parameter_annotation_table.length);
@@ -117,7 +117,7 @@ public abstract class ParameterAnnotatio
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy( ConstantPool constant_pool ) {
+    public Attribute copy( final ConstantPool constant_pool ) {
         return (Attribute) clone();
     }
 }

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleAnnotations.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleAnnotations.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleAnnotations.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleAnnotations.java Wed Jun  1 04:25:27 2016
@@ -42,7 +42,7 @@ public class RuntimeInvisibleAnnotations
      * @param constant_pool
      *            Array of constants
      */
-    public RuntimeInvisibleAnnotations(int name_index, int length, DataInput input, ConstantPool constant_pool)
+    public RuntimeInvisibleAnnotations(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool)
             throws IOException
     {
         super(Const.ATTR_RUNTIME_INVISIBLE_ANNOTATIONS, name_index, length, input, constant_pool, false);
@@ -52,13 +52,13 @@ public class RuntimeInvisibleAnnotations
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy(ConstantPool constant_pool)
+    public Attribute copy(final ConstantPool constant_pool)
     {
         return (Attribute) clone();
     }
 
     @Override
-    public final void dump(DataOutputStream dos) throws IOException
+    public final void dump(final DataOutputStream dos) throws IOException
     {
         super.dump(dos);
         writeAnnotations(dos);

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleParameterAnnotations.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleParameterAnnotations.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleParameterAnnotations.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleParameterAnnotations.java Wed Jun  1 04:25:27 2016
@@ -37,7 +37,7 @@ public class RuntimeInvisibleParameterAn
      * @param input Input stream
      * @param constant_pool Array of constants
      */
-    public RuntimeInvisibleParameterAnnotations(int name_index, int length, DataInput input, ConstantPool constant_pool)
+    public RuntimeInvisibleParameterAnnotations(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool)
             throws IOException {
         super(Const.ATTR_RUNTIME_INVISIBLE_PARAMETER_ANNOTATIONS, name_index, length, input, constant_pool);
     }

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeVisibleAnnotations.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeVisibleAnnotations.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeVisibleAnnotations.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeVisibleAnnotations.java Wed Jun  1 04:25:27 2016
@@ -42,7 +42,7 @@ public class RuntimeVisibleAnnotations e
      * @param constant_pool
      *            Array of constants
      */
-    public RuntimeVisibleAnnotations(int name_index, int length, DataInput input, ConstantPool constant_pool) throws IOException
+    public RuntimeVisibleAnnotations(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool) throws IOException
     {
         super(Const.ATTR_RUNTIME_VISIBLE_ANNOTATIONS, name_index, length, input, constant_pool, true);
     }
@@ -51,13 +51,13 @@ public class RuntimeVisibleAnnotations e
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy(ConstantPool constant_pool)
+    public Attribute copy(final ConstantPool constant_pool)
     {
         return (Attribute) clone();
     }
 
     @Override
-    public final void dump(DataOutputStream dos) throws IOException
+    public final void dump(final DataOutputStream dos) throws IOException
     {
         super.dump(dos);
         writeAnnotations(dos);

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeVisibleParameterAnnotations.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeVisibleParameterAnnotations.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeVisibleParameterAnnotations.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeVisibleParameterAnnotations.java Wed Jun  1 04:25:27 2016
@@ -37,7 +37,7 @@ public class RuntimeVisibleParameterAnno
      * @param input Input stream
      * @param constant_pool Array of constants
      */
-    public RuntimeVisibleParameterAnnotations(int name_index, int length, DataInput input, ConstantPool constant_pool)
+    public RuntimeVisibleParameterAnnotations(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool)
             throws IOException {
         super(Const.ATTR_RUNTIME_VISIBLE_PARAMETER_ANNOTATIONS, name_index, length, input, constant_pool);
     }

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java Wed Jun  1 04:25:27 2016
@@ -40,7 +40,7 @@ public final class Signature extends Att
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use clone() for a physical copy.
      */
-    public Signature(Signature c) {
+    public Signature(final Signature c) {
         this(c.getNameIndex(), c.getLength(), c.getSignatureIndex(), c.getConstantPool());
     }
 
@@ -53,7 +53,7 @@ public final class Signature extends Att
      * @param constant_pool Array of constants
      * @throws IOException
      */
-    Signature(int name_index, int length, DataInput input, ConstantPool constant_pool)
+    Signature(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool)
             throws IOException {
         this(name_index, length, input.readUnsignedShort(), constant_pool);
     }
@@ -65,7 +65,7 @@ public final class Signature extends Att
      * @param signature_index Index in constant pool to CONSTANT_Utf8
      * @param constant_pool Array of constants
      */
-    public Signature(int name_index, int length, int signature_index, ConstantPool constant_pool) {
+    public Signature(final int name_index, final int length, final int signature_index, final ConstantPool constant_pool) {
         super(Const.ATTR_SIGNATURE, name_index, length, constant_pool);
         this.signature_index = signature_index;
     }
@@ -79,7 +79,7 @@ public final class Signature extends Att
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         //System.err.println("Visiting non-standard Signature object");
         v.visitSignature(this);
     }
@@ -92,7 +92,7 @@ public final class Signature extends Att
      * @throws IOException
      */
     @Override
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         super.dump(file);
         file.writeShort(signature_index);
     }
@@ -109,7 +109,7 @@ public final class Signature extends Att
     /**
      * @param signature_index the index info the constant pool of this signature
      */
-    public final void setSignatureIndex( int signature_index ) {
+    public final void setSignatureIndex( final int signature_index ) {
         this.signature_index = signature_index;
     }
 
@@ -128,7 +128,7 @@ public final class Signature extends Att
      */
     private static final class MyByteArrayInputStream extends ByteArrayInputStream {
 
-        MyByteArrayInputStream(String data) {
+        MyByteArrayInputStream(final String data) {
             super(data.getBytes());
         }
 
@@ -146,12 +146,12 @@ public final class Signature extends Att
     }
 
 
-    private static boolean identStart( int ch ) {
+    private static boolean identStart( final int ch ) {
         return ch == 'T' || ch == 'L';
     }
 
 
-    private static void matchIdent( MyByteArrayInputStream in, StringBuilder buf ) {
+    private static void matchIdent( final MyByteArrayInputStream in, final StringBuilder buf ) {
         int ch;
         if ((ch = in.read()) == -1) {
             throw new RuntimeException("Illegal signature: " + in.getData()
@@ -194,7 +194,7 @@ public final class Signature extends Att
     }
 
 
-    private static void matchGJIdent( MyByteArrayInputStream in, StringBuilder buf ) {
+    private static void matchGJIdent( final MyByteArrayInputStream in, final StringBuilder buf ) {
         int ch;
         matchIdent(in, buf);
         ch = in.read();
@@ -230,7 +230,7 @@ public final class Signature extends Att
     }
 
 
-    public static String translate( String s ) {
+    public static String translate( final String s ) {
         //System.out.println("Sig:" + s);
         StringBuilder buf = new StringBuilder();
         matchGJIdent(new MyByteArrayInputStream(s), buf);
@@ -239,13 +239,13 @@ public final class Signature extends Att
 
 
     // @since 6.0 is no longer final
-    public static boolean isFormalParameterList( String s ) {
+    public static boolean isFormalParameterList( final String s ) {
         return s.startsWith("<") && (s.indexOf(':') > 0);
     }
 
 
     // @since 6.0 is no longer final
-    public static boolean isActualParameterList( String s ) {
+    public static boolean isActualParameterList( final String s ) {
         return s.startsWith("L") && s.endsWith(">;");
     }
 
@@ -264,7 +264,7 @@ public final class Signature extends Att
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy( ConstantPool _constant_pool ) {
+    public Attribute copy( final ConstantPool _constant_pool ) {
         return (Attribute) clone();
     }
 }

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SimpleElementValue.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SimpleElementValue.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SimpleElementValue.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SimpleElementValue.java Wed Jun  1 04:25:27 2016
@@ -29,7 +29,7 @@ public class SimpleElementValue extends
 {
     private int index;
 
-    public SimpleElementValue(int type, int index, ConstantPool cpool)
+    public SimpleElementValue(final int type, final int index, final ConstantPool cpool)
     {
         super(type, cpool);
         this.index = index;
@@ -43,7 +43,7 @@ public class SimpleElementValue extends
         return index;
     }
 
-    public void setIndex(int index)
+    public void setIndex(final int index)
     {
         this.index = index;
     }
@@ -201,7 +201,7 @@ public class SimpleElementValue extends
     }
 
     @Override
-    public void dump(DataOutputStream dos) throws IOException
+    public void dump(final DataOutputStream dos) throws IOException
     {
         final int _type = super.getType();
         dos.writeByte(_type); // u1 kind of value

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SourceFile.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SourceFile.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SourceFile.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SourceFile.java Wed Jun  1 04:25:27 2016
@@ -41,7 +41,7 @@ public final class SourceFile extends At
      * Initialize from another object. Note that both objects use the same
      * references (shallow copy). Use clone() for a physical copy.
      */
-    public SourceFile(SourceFile c) {
+    public SourceFile(final SourceFile c) {
         this(c.getNameIndex(), c.getLength(), c.getSourceFileIndex(), c.getConstantPool());
     }
 
@@ -54,7 +54,7 @@ public final class SourceFile extends At
      * @param constant_pool Array of constants
      * @throws IOException
      */
-    SourceFile(int name_index, int length, DataInput input, ConstantPool constant_pool)
+    SourceFile(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool)
             throws IOException {
         this(name_index, length, input.readUnsignedShort(), constant_pool);
     }
@@ -73,7 +73,7 @@ public final class SourceFile extends At
      * information has to be supplied the consumer of this attribute - in
      * many cases, the JVM.
      */
-    public SourceFile(int name_index, int length, int sourcefile_index, ConstantPool constant_pool) {
+    public SourceFile(final int name_index, final int length, final int sourcefile_index, final ConstantPool constant_pool) {
         super(Const.ATTR_SOURCE_FILE, name_index, length, constant_pool);
         this.sourcefile_index = sourcefile_index;
     }
@@ -87,7 +87,7 @@ public final class SourceFile extends At
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitSourceFile(this);
     }
 
@@ -99,7 +99,7 @@ public final class SourceFile extends At
      * @throws IOException
      */
     @Override
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         super.dump(file);
         file.writeShort(sourcefile_index);
     }
@@ -116,7 +116,7 @@ public final class SourceFile extends At
     /**
      * @param sourcefile_index
      */
-    public final void setSourceFileIndex( int sourcefile_index ) {
+    public final void setSourceFileIndex( final int sourcefile_index ) {
         this.sourcefile_index = sourcefile_index;
     }
 
@@ -144,7 +144,7 @@ public final class SourceFile extends At
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy( ConstantPool _constant_pool ) {
+    public Attribute copy( final ConstantPool _constant_pool ) {
         return (Attribute) clone();
     }
 }

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMap.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMap.java?rev=1746378&r1=1746377&r2=1746378&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMap.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMap.java Wed Jun  1 04:25:27 2016
@@ -48,7 +48,7 @@ public final class StackMap extends Attr
      * @param map Table of stack map entries
      * @param constant_pool Array of constants
      */
-    public StackMap(int name_index, int length, StackMapEntry[] map, ConstantPool constant_pool) {
+    public StackMap(final int name_index, final int length, final StackMapEntry[] map, final ConstantPool constant_pool) {
         super(Const.ATTR_STACK_MAP, name_index, length, constant_pool);
         this.map = map;
     }
@@ -63,7 +63,7 @@ public final class StackMap extends Attr
      * @param constant_pool Array of constants
      * @throws IOException
      */
-    StackMap(int name_index, int length, DataInput input, ConstantPool constant_pool) throws IOException {
+    StackMap(final int name_index, final int length, final DataInput input, final ConstantPool constant_pool) throws IOException {
         this(name_index, length, (StackMapEntry[]) null, constant_pool);
         int map_length = input.readUnsignedShort();
         map = new StackMapEntry[map_length];
@@ -80,7 +80,7 @@ public final class StackMap extends Attr
      * @throws IOException
      */
     @Override
-    public final void dump( DataOutputStream file ) throws IOException {
+    public final void dump( final DataOutputStream file ) throws IOException {
         super.dump(file);
         file.writeShort(map.length);
         for (StackMapEntry entry : map) {
@@ -100,7 +100,7 @@ public final class StackMap extends Attr
     /**
      * @param map Array of stack map entries
      */
-    public final void setStackMap( StackMapEntry[] map ) {
+    public final void setStackMap( final StackMapEntry[] map ) {
         this.map = map;
         int len = 2; // Length of 'number_of_entries' field prior to the array of stack maps
         for (int i = 0; i < map.length; i++) {
@@ -131,7 +131,7 @@ public final class StackMap extends Attr
      * @return deep copy of this attribute
      */
     @Override
-    public Attribute copy( ConstantPool _constant_pool ) {
+    public Attribute copy( final ConstantPool _constant_pool ) {
         StackMap c = (StackMap) clone();
         c.map = new StackMapEntry[map.length];
         for (int i = 0; i < map.length; i++) {
@@ -150,7 +150,7 @@ public final class StackMap extends Attr
      * @param v Visitor object
      */
     @Override
-    public void accept( Visitor v ) {
+    public void accept( final Visitor v ) {
         v.visitStackMap(this);
     }
 



Mime
View raw message