Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8F3A7200B35 for ; Tue, 31 May 2016 02:48:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8DC9B160A19; Tue, 31 May 2016 00:48:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D18FD160A3C for ; Tue, 31 May 2016 02:48:20 +0200 (CEST) Received: (qmail 85559 invoked by uid 500); 31 May 2016 00:48:19 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 85401 invoked by uid 99); 31 May 2016 00:48:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2016 00:48:19 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B167BE0252; Tue, 31 May 2016 00:48:19 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: erans@apache.org To: commits@commons.apache.org Date: Tue, 31 May 2016 00:48:20 -0000 Message-Id: <59e29e7f99724272a4fb9cffaa8d11ca@git.apache.org> In-Reply-To: <64bcf350d0d744db82eb7594cc824aaa@git.apache.org> References: <64bcf350d0d744db82eb7594cc824aaa@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/3] [math] Unnecessary String creation. archived-at: Tue, 31 May 2016 00:48:21 -0000 Unnecessary String creation. Thanks to Dave Brosius. Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/362ab2bc Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/362ab2bc Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/362ab2bc Branch: refs/heads/develop Commit: 362ab2bc41697980391c4a61c23cb3ef6bce740c Parents: 633de29 Author: Gilles Authored: Tue May 31 02:30:47 2016 +0200 Committer: Gilles Committed: Tue May 31 02:30:47 2016 +0200 ---------------------------------------------------------------------- .../math4/stat/descriptive/MultivariateSummaryStatistics.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-math/blob/362ab2bc/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java b/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java index eb1642c..39083d0 100644 --- a/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java +++ b/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java @@ -319,8 +319,8 @@ public class MultivariateSummaryStatistics final String separator = ", "; final String suffix = System.getProperty("line.separator"); StringBuilder outBuffer = new StringBuilder(); - outBuffer.append("MultivariateSummaryStatistics:" + suffix); - outBuffer.append("n: " + getN() + suffix); + outBuffer.append("MultivariateSummaryStatistics:").append(suffix); + outBuffer.append("n: ").append(getN()).append(suffix); append(outBuffer, getMin(), "min: ", separator, suffix); append(outBuffer, getMax(), "max: ", separator, suffix); append(outBuffer, getMean(), "mean: ", separator, suffix); @@ -328,7 +328,7 @@ public class MultivariateSummaryStatistics append(outBuffer, getSumSq(), "sum of squares: ", separator, suffix); append(outBuffer, getSumLog(), "sum of logarithms: ", separator, suffix); append(outBuffer, getStandardDeviation(), "standard deviation: ", separator, suffix); - outBuffer.append("covariance: " + getCovariance().toString() + suffix); + outBuffer.append("covariance: ").append(getCovariance()).append(suffix); return outBuffer.toString(); }