commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1744568 - in /commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest: DigestUtilsTest.java HmacUtilsTest.java
Date Thu, 19 May 2016 13:19:53 GMT
Author: sebb
Date: Thu May 19 13:19:52 2016
New Revision: 1744568

URL: http://svn.apache.org/viewvc?rev=1744568&view=rev
Log:
Does not make sense to test construction of a utility class

Modified:
    commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/DigestUtilsTest.java
    commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacUtilsTest.java

Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/DigestUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/DigestUtilsTest.java?rev=1744568&r1=1744567&r2=1744568&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/DigestUtilsTest.java
(original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/DigestUtilsTest.java
Thu May 19 13:19:52 2016
@@ -19,7 +19,6 @@ package org.apache.commons.codec.digest;
 
 import static org.apache.commons.codec.binary.StringUtils.getBytesUtf8;
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
 
 import java.io.ByteArrayInputStream;
 import java.io.File;
@@ -77,11 +76,6 @@ public class DigestUtilsTest {
         }
     }
 
-    @Test
-    public void testConstructable() {
-        assertNotNull(new DigestUtils());
-    }
-
     @Test(expected=IllegalArgumentException.class)
     public void testInternalNoSuchAlgorithmException() {
         DigestUtils.getDigest("Bogus Bogus");

Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacUtilsTest.java?rev=1744568&r1=1744567&r2=1744568&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacUtilsTest.java
(original)
+++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/digest/HmacUtilsTest.java
Thu May 19 13:19:52 2016
@@ -17,7 +17,6 @@
 package org.apache.commons.codec.digest;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
@@ -37,10 +36,6 @@ import org.junit.Test;
  */
 @SuppressWarnings("deprecation") // temporarily ignore that HmacUtils is deprecated
 public class HmacUtilsTest {
-    @Test
-    public void testConstructor() {
-        assertNotNull(new HmacUtils());
-    }
 
     @Test(expected = IllegalArgumentException.class)
     public void testEmptyKey() {



Mime
View raw message