commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1697032 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
Date Fri, 21 Aug 2015 17:54:12 GMT
Author: sebb
Date: Fri Aug 21 17:54:11 2015
New Revision: 1697032

URL: http://svn.apache.org/r1697032
Log:
FindBugs: String append in a loop

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java?rev=1697032&r1=1697031&r2=1697032&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
Fri Aug 21 17:54:11 2015
@@ -864,15 +864,15 @@ public abstract class Utility {
 
                     // we have TypeArguments; build up partial result
                     // as we recurse for each TypeArgument
-                    String type = compactClassName(signature.substring(1, bracketIndex),
chopit) + "<";
+                    StringBuilder type = new StringBuilder(compactClassName(signature.substring(1,
bracketIndex), chopit)).append("<");
                     int consumed_chars = bracketIndex + 1; // Shadows global var
 
                     // check for wildcards
                     if (signature.charAt(consumed_chars) == '+') {
-                        type = type + "? extends ";
+                        type.append("? extends ");
                         consumed_chars++;
                     } else if (signature.charAt(consumed_chars) == '-') {
-                        type = type + "? super ";
+                        type.append("? super ");
                         consumed_chars++;
                     } else if (signature.charAt(consumed_chars) == '*') {
                         // must be at end of signature
@@ -887,14 +887,14 @@ public abstract class Utility {
                     }
 
                     // get the first TypeArgument
-                    type = type + signatureToString(signature.substring(consumed_chars),
chopit);
+                    type.append(signatureToString(signature.substring(consumed_chars), chopit));
                     // update our consumed count by the number of characters the for type
argument
                     consumed_chars = unwrap(Utility.consumed_chars) + consumed_chars;
                     wrap(Utility.consumed_chars, consumed_chars);
 
                     // are there more TypeArguments?
                     while (signature.charAt(consumed_chars) != '>') {
-                        type = type + ", " + signatureToString(signature.substring(consumed_chars),
chopit);
+                        type.append(", " + signatureToString(signature.substring(consumed_chars),
chopit));
                         // update our consumed count by the number of characters the for
type argument
                         consumed_chars = unwrap(Utility.consumed_chars) + consumed_chars;
                         wrap(Utility.consumed_chars, consumed_chars);
@@ -904,7 +904,7 @@ public abstract class Utility {
                         throw new ClassFormatException("Invalid signature: " + signature);
                     }
                     wrap(Utility.consumed_chars, consumed_chars + 2); // remove final ">;"
-                    return type + ">";
+                    return type.append(">").toString();
                 }
                 case 'S':
                     return "short";



Mime
View raw message