commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1696349 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/
Date Mon, 17 Aug 2015 22:43:35 GMT
Author: sebb
Date: Mon Aug 17 22:43:35 2015
New Revision: 1696349

URL: http://svn.apache.org/r1696349
Log:
Remove inaccurate TODOs

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGen.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/CodeExceptionGen.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGen.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableGen.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java?rev=1696349&r1=1696348&r2=1696349&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
Mon Aug 17 22:43:35 2015
@@ -74,7 +74,7 @@ public class JavaClass extends AccessFla
     static boolean debug = false; // Debugging on/off
     final static char sep = File.separatorChar; // directory separator
     
-    private static final BCELComparator _cmp = new BCELComparator() { // TODO could be final
(setter unused)
+    private static final BCELComparator _cmp = new BCELComparator() {
 
         @Override
         public boolean equals( Object o1, Object o2 ) {

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java?rev=1696349&r1=1696348&r2=1696349&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java
Mon Aug 17 22:43:35 2015
@@ -91,7 +91,7 @@ public final class BranchHandle extends
     /**
      * Pass new target to instruction.
      */
-    public void setTarget( InstructionHandle ih ) { // TODO unused
+    public void setTarget( InstructionHandle ih ) {
         bi.setTarget(ih);
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGen.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGen.java?rev=1696349&r1=1696348&r2=1696349&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGen.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/ClassGen.java
Mon Aug 17 22:43:35 2015
@@ -417,13 +417,13 @@ public class ClassGen extends AccessFlag
     }
 
 
-    public void setClassName( String name ) { // TODO unused
+    public void setClassName( String name ) {
         class_name = name.replace('/', '.');
         class_name_index = cp.addClass(name);
     }
 
 
-    public void setSuperclassName( String name ) { // TODO unused
+    public void setSuperclassName( String name ) {
         super_class_name = name.replace('/', '.');
         superclass_name_index = cp.addClass(name);
     }
@@ -434,7 +434,7 @@ public class ClassGen extends AccessFlag
     }
 
 
-    public void setMethods( Method[] methods ) { // TODO unused
+    public void setMethods( Method[] methods ) {
         method_vec.clear();
         for (Method method : methods) {
             addMethod(method);
@@ -442,7 +442,7 @@ public class ClassGen extends AccessFlag
     }
 
 
-    public void setMethodAt( Method method, int pos ) { // TODO unused
+    public void setMethodAt( Method method, int pos ) {
         method_vec.set(pos, method);
     }
 
@@ -490,19 +490,19 @@ public class ClassGen extends AccessFlag
     }
 
 
-    public void setConstantPool( ConstantPoolGen constant_pool ) { // TODO unused
+    public void setConstantPool( ConstantPoolGen constant_pool ) {
         cp = constant_pool;
     }
 
 
-    public void setClassNameIndex( int class_name_index ) { // TODO unused
+    public void setClassNameIndex( int class_name_index ) {
         this.class_name_index = class_name_index;
         class_name = cp.getConstantPool().getConstantString(class_name_index,
                 Constants.CONSTANT_Class).replace('/', '.');
     }
 
 
-    public void setSuperclassNameIndex( int superclass_name_index ) { // TODO unused
+    public void setSuperclassNameIndex( int superclass_name_index ) {
         this.superclass_name_index = superclass_name_index;
         super_class_name = cp.getConstantPool().getConstantString(superclass_name_index,
                 Constants.CONSTANT_Class).replace('/', '.');

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/CodeExceptionGen.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/CodeExceptionGen.java?rev=1696349&r1=1696348&r2=1696349&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/CodeExceptionGen.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/CodeExceptionGen.java
Mon Aug 17 22:43:35 2015
@@ -139,7 +139,7 @@ public final class CodeExceptionGen impl
 
 
     /** Sets the type of the Exception to catch. Set 'null' for ANY. */
-    public void setCatchType( ObjectType catch_type ) { // TODO unused
+    public void setCatchType( ObjectType catch_type ) {
         this.catch_type = catch_type;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGen.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGen.java?rev=1696349&r1=1696348&r2=1696349&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGen.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGen.java
Mon Aug 17 22:43:35 2015
@@ -125,7 +125,7 @@ public class FieldGen extends FieldGenOr
     }
 
 
-    public void setInitValue( long l ) { // TODO unused
+    public void setInitValue( long l ) {
         checkType(Type.LONG);
         if (l != 0L) {
             value = new Long(l);
@@ -133,7 +133,7 @@ public class FieldGen extends FieldGenOr
     }
 
 
-    public void setInitValue( int i ) { // TODO unused
+    public void setInitValue( int i ) {
         checkType(Type.INT);
         if (i != 0) {
             value = Integer.valueOf(i);
@@ -141,7 +141,7 @@ public class FieldGen extends FieldGenOr
     }
 
 
-    public void setInitValue( short s ) { // TODO unused
+    public void setInitValue( short s ) {
         checkType(Type.SHORT);
         if (s != 0) {
             value = Integer.valueOf(s);
@@ -149,7 +149,7 @@ public class FieldGen extends FieldGenOr
     }
 
 
-    public void setInitValue( char c ) { // TODO unused
+    public void setInitValue( char c ) {
         checkType(Type.CHAR);
         if (c != 0) {
             value = Integer.valueOf(c);
@@ -157,7 +157,7 @@ public class FieldGen extends FieldGenOr
     }
 
 
-    public void setInitValue( byte b ) { // TODO unused
+    public void setInitValue( byte b ) {
         checkType(Type.BYTE);
         if (b != 0) {
             value = Integer.valueOf(b);
@@ -165,7 +165,7 @@ public class FieldGen extends FieldGenOr
     }
 
 
-    public void setInitValue( boolean b ) { // TODO unused
+    public void setInitValue( boolean b ) {
         checkType(Type.BOOLEAN);
         if (b) {
             value = Integer.valueOf(1);
@@ -173,7 +173,7 @@ public class FieldGen extends FieldGenOr
     }
 
 
-    public void setInitValue( float f ) { // TODO unused
+    public void setInitValue( float f ) {
         checkType(Type.FLOAT);
         if (f != 0.0) {
             value = new Float(f);
@@ -181,7 +181,7 @@ public class FieldGen extends FieldGenOr
     }
 
 
-    public void setInitValue( double d ) { // TODO unused
+    public void setInitValue( double d ) {
         checkType(Type.DOUBLE);
         if (d != 0.0) {
             value = new Double(d);
@@ -191,7 +191,7 @@ public class FieldGen extends FieldGenOr
 
     /** Remove any initial value.
      */
-    public void cancelInitValue() { // TODO unused
+    public void cancelInitValue() {
         value = null;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java?rev=1696349&r1=1696348&r2=1696349&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionFactory.java
Mon Aug 17 22:43:35 2015
@@ -745,7 +745,7 @@ public class InstructionFactory implemen
     }
 
 
-    public void setClassGen( ClassGen c ) { // TODO unused
+    public void setClassGen( ClassGen c ) {
         cg = c;
     }
 
@@ -755,7 +755,7 @@ public class InstructionFactory implemen
     }
 
 
-    public void setConstantPool( ConstantPoolGen c ) { // TODO unused
+    public void setConstantPool( ConstantPoolGen c ) {
         cp = c;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableGen.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableGen.java?rev=1696349&r1=1696348&r2=1696349&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableGen.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableGen.java
Mon Aug 17 22:43:35 2015
@@ -94,7 +94,7 @@ public class LocalVariableGen implements
     }
 
 
-    public void setIndex( int index ) { // TODO unused
+    public void setIndex( int index ) {
         this.index = index;
     }
 
@@ -105,7 +105,7 @@ public class LocalVariableGen implements
 
 
     @Override
-    public void setName( String name ) { // TODO unused
+    public void setName( String name ) {
         this.name = name;
     }
 
@@ -117,7 +117,7 @@ public class LocalVariableGen implements
 
 
     @Override
-    public void setType( Type type ) { // TODO unused
+    public void setType( Type type ) {
         this.type = type;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java?rev=1696349&r1=1696348&r2=1696349&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/MethodGen.java
Mon Aug 17 22:43:35 2015
@@ -753,7 +753,7 @@ public class MethodGen extends FieldGenO
     }
 
 
-    public void setReturnType( Type return_type ) { // TODO unused
+    public void setReturnType( Type return_type ) {
         setType(return_type);
     }
 
@@ -763,7 +763,7 @@ public class MethodGen extends FieldGenO
     }
 
 
-    public void setArgumentTypes( Type[] arg_types ) { // TODO could be package-protected?
+    public void setArgumentTypes( Type[] arg_types ) {
         this.arg_types = arg_types;
     }
 
@@ -773,7 +773,7 @@ public class MethodGen extends FieldGenO
     }
 
 
-    public void setArgumentType( int i, Type type ) { // TODO unused
+    public void setArgumentType( int i, Type type ) {
         arg_types[i] = type;
     }
 
@@ -783,7 +783,7 @@ public class MethodGen extends FieldGenO
     }
 
 
-    public void setArgumentNames( String[] arg_names ) { // TODO could be package-protected?
+    public void setArgumentNames( String[] arg_names ) {
         this.arg_names = arg_names;
     }
 
@@ -793,7 +793,7 @@ public class MethodGen extends FieldGenO
     }
 
 
-    public void setArgumentName( int i, String name ) { // TODO unused
+    public void setArgumentName( int i, String name ) {
         arg_names[i] = name;
     }
 



Mime
View raw message