commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1695678 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/JavaClass.java generic/BranchHandle.java generic/InstructionHandle.java
Date Thu, 13 Aug 2015 11:36:51 GMT
Author: sebb
Date: Thu Aug 13 11:36:50 2015
New Revision: 1695678

URL: http://svn.apache.org/r1695678
Log:
TODO

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionHandle.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java?rev=1695678&r1=1695677&r2=1695678&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
Thu Aug 13 11:36:50 2015
@@ -645,7 +645,7 @@ public class JavaClass extends AccessFla
      * Sets the ClassRepository which loaded the JavaClass.
      * Should be called immediately after parsing is done.
      */
-    public void setRepository( org.apache.commons.bcel6.util.Repository repository ) {
+    public void setRepository( org.apache.commons.bcel6.util.Repository repository ) { //
TODO make protected?
         this.repository = repository;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java?rev=1695678&r1=1695677&r2=1695678&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/BranchHandle.java
Thu Aug 13 11:36:50 2015
@@ -91,7 +91,7 @@ public final class BranchHandle extends
     /**
      * Pass new target to instruction.
      */
-    public void setTarget( InstructionHandle ih ) {
+    public void setTarget( InstructionHandle ih ) { // TODO unused
         bi.setTarget(ih);
     }
 
@@ -116,7 +116,7 @@ public final class BranchHandle extends
      * Set new contents. Old instruction is disposed and may not be used anymore.
      */
     @Override
-    public void setInstruction( Instruction i ) {
+    public void setInstruction( Instruction i ) { // TODO could be package-protected?
         super.setInstruction(i);
         if (!(i instanceof BranchInstruction)) {
             throw new ClassGenException("Assigning " + i

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionHandle.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionHandle.java?rev=1695678&r1=1695677&r2=1695678&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionHandle.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionHandle.java
Thu Aug 13 11:36:50 2015
@@ -71,7 +71,7 @@ public class InstructionHandle implement
      * Replace current instruction contained in this handle.
      * Old instruction is disposed using Instruction.dispose().
      */
-    public void setInstruction( Instruction i ) { // Overridden in BranchHandle
+    public void setInstruction( Instruction i ) { // Overridden in BranchHandle TODO could
be package-protected?
         if (i == null) {
             throw new ClassGenException("Assigning null to handle");
         }



Mime
View raw message