commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1695120 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile: BootstrapMethod.java BootstrapMethods.java
Date Mon, 10 Aug 2015 15:43:32 GMT
Author: sebb
Date: Mon Aug 10 15:43:32 2015
New Revision: 1695120

URL: http://svn.apache.org/r1695120
Log:
TODOs

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethod.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethods.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethod.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethod.java?rev=1695120&r1=1695119&r2=1695120&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethod.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethod.java
Mon Aug 10 15:43:32 2015
@@ -37,12 +37,12 @@ public class BootstrapMethod implements
     private static final long serialVersionUID = -4517534834047695344L;
 
     /** Index of the CONSTANT_MethodHandle_info structure in the constant_pool table */
-    private int bootstrap_method_ref;
+    private int bootstrap_method_ref; // TODO this could be made final (setter is not used)
 
-    private int num_bootstrap_arguments;
+    private final int num_bootstrap_arguments;
 
     /** Array of references to the constant_pool table */
-    private int[] bootstrap_arguments;
+    private int[] bootstrap_arguments; // TODO this could be made final (setter is not used)
 
 
     /**

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethods.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethods.java?rev=1695120&r1=1695119&r2=1695120&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethods.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/BootstrapMethods.java
Mon Aug 10 15:43:32 2015
@@ -33,7 +33,7 @@ public class BootstrapMethods extends At
 
     private static final long serialVersionUID = -2169230245012340809L;
 
-    private BootstrapMethod[] bootstrap_methods;
+    private BootstrapMethod[] bootstrap_methods;  // TODO this could be made final (setter
is not used)
 
     /**
      * Initialize from another object. Note that both objects use the same



Mime
View raw message