commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1695115 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Annotations.java
Date Mon, 10 Aug 2015 15:25:53 GMT
Author: sebb
Date: Mon Aug 10 15:25:53 2015
New Revision: 1695115

URL: http://svn.apache.org/r1695115
Log:
Don't call overrideable methods from a constructor

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Annotations.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Annotations.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Annotations.java?rev=1695115&r1=1695114&r2=1695115&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Annotations.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Annotations.java
Mon Aug 10 15:25:53 2015
@@ -32,7 +32,7 @@ public abstract class Annotations extend
 
     private static final long serialVersionUID = 1L;
 
-    private AnnotationEntry[] annotation_table;
+    private AnnotationEntry[] annotation_table; // TODO could this be final?
     private final boolean isRuntimeVisible;
 
     /**
@@ -60,7 +60,7 @@ public abstract class Annotations extend
      */
     public Annotations(byte annotation_type, int name_index, int length, AnnotationEntry[]
annotation_table, ConstantPool constant_pool, boolean isRuntimeVisible) {
         super(annotation_type, name_index, length, constant_pool);
-        setAnnotationTable(annotation_table);
+        this.annotation_table = annotation_table;
         this.isRuntimeVisible = isRuntimeVisible;
     }
 



Mime
View raw message