commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1686261 - /commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/FTPClientConfigTest.java
Date Thu, 18 Jun 2015 15:59:02 GMT
Author: sebb
Date: Thu Jun 18 15:59:02 2015
New Revision: 1686261

URL: http://svn.apache.org/r1686261
Log:
No need for fields to be mutable or package-visible

Modified:
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/FTPClientConfigTest.java

Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/FTPClientConfigTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/FTPClientConfigTest.java?rev=1686261&r1=1686260&r2=1686261&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/FTPClientConfigTest.java
(original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/FTPClientConfigTest.java
Thu Jun 18 15:59:02 2015
@@ -39,12 +39,12 @@ public class FTPClientConfigTest extends
         assertNull(config.getServerLanguageCode());
     }
 
-    String A = "A";
-    String B = "B";
-    String C = "C";
-    String D = "D";
-    String E = "E";
-    String F = "F";
+    private static final String A = "A";
+    private static final String B = "B";
+    private static final String C = "C";
+    private static final String D = "D";
+    private static final String E = "E";
+    private static final String F = "F";
 
     /*
      * Class under test for void FTPClientConfig(String, String, String, String, String,
String)
@@ -61,10 +61,10 @@ public class FTPClientConfigTest extends
     }
 
 
-    String badDelim = "jan,feb,mar,apr,may,jun,jul,aug.sep,oct,nov,dec";
-    String tooLong =  "jan|feb|mar|apr|may|jun|jul|aug|sep|oct|nov|dec|jan";
-    String tooShort = "jan|feb|mar|apr|may|jun|jul|aug|sep|oct|nov";
-    String fakeLang = "abc|def|ghi|jkl|mno|pqr|stu|vwx|yza|bcd|efg|hij";
+    private static final String badDelim = "jan,feb,mar,apr,may,jun,jul,aug.sep,oct,nov,dec";
+    private static final String tooLong =  "jan|feb|mar|apr|may|jun|jul|aug|sep|oct|nov|dec|jan";
+    private static final String tooShort = "jan|feb|mar|apr|may|jun|jul|aug|sep|oct|nov";
+    private static final String fakeLang = "abc|def|ghi|jkl|mno|pqr|stu|vwx|yza|bcd|efg|hij";
 
     public void testSetShortMonthNames() {
     }



Mime
View raw message