commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brit...@apache.org
Subject svn commit: r1680739 - /commons/proper/io/trunk/src/test/java/org/apache/commons/io/filefilter/IOFileFilterAbstractTestCase.java
Date Thu, 21 May 2015 06:28:37 GMT
Author: britter
Date: Thu May 21 06:28:37 2015
New Revision: 1680739

URL: http://svn.apache.org/r1680739
Log:
Remove irrelevant return statements

Modified:
    commons/proper/io/trunk/src/test/java/org/apache/commons/io/filefilter/IOFileFilterAbstractTestCase.java

Modified: commons/proper/io/trunk/src/test/java/org/apache/commons/io/filefilter/IOFileFilterAbstractTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/filefilter/IOFileFilterAbstractTestCase.java?rev=1680739&r1=1680738&r2=1680739&view=diff
==============================================================================
--- commons/proper/io/trunk/src/test/java/org/apache/commons/io/filefilter/IOFileFilterAbstractTestCase.java
(original)
+++ commons/proper/io/trunk/src/test/java/org/apache/commons/io/filefilter/IOFileFilterAbstractTestCase.java
Thu May 21 06:28:37 2015
@@ -26,21 +26,19 @@ public abstract class IOFileFilterAbstra
         super(name);
     }
 
-    public boolean assertFileFiltering(final int testNumber, final IOFileFilter filter, final
File file, final boolean expected)
+    public void assertFileFiltering(final int testNumber, final IOFileFilter filter, final
File file, final boolean expected)
             throws Exception {
         assertEquals(
                 "test " + testNumber + " Filter(File) " + filter.getClass().getName() + "
not " + expected + " for " + file,
                 expected, filter.accept(file));
-        return true; // return is irrelevant
     }
 
-    public boolean assertFilenameFiltering(final int testNumber, final IOFileFilter filter,
final File file, final boolean expected)
+    public void assertFilenameFiltering(final int testNumber, final IOFileFilter filter,
final File file, final boolean expected)
             throws Exception {
         // Assumes file has parent and is not passed as null
         assertEquals(
                 "test " + testNumber + " Filter(File, String) " + filter.getClass().getName()
+ " not " + expected + " for " + file,
                 expected, filter.accept(file.getParentFile(), file.getName()));
-        return true; // return is irrelevant
     }
 
     public void assertFiltering(final int testNumber, final IOFileFilter filter, final File
file, final boolean expected)



Mime
View raw message