commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brit...@apache.org
Subject svn commit: r1671628 - /commons/proper/lang/trunk/findbugs-exclude-filter.xml
Date Mon, 06 Apr 2015 18:16:38 GMT
Author: britter
Date: Mon Apr  6 18:16:37 2015
New Revision: 1671628

URL: http://svn.apache.org/r1671628
Log:
Define Findbugs exlucde for internally used map key class

Modified:
    commons/proper/lang/trunk/findbugs-exclude-filter.xml

Modified: commons/proper/lang/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/findbugs-exclude-filter.xml?rev=1671628&r1=1671627&r2=1671628&view=diff
==============================================================================
--- commons/proper/lang/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/lang/trunk/findbugs-exclude-filter.xml Mon Apr  6 18:16:37 2015
@@ -141,4 +141,17 @@
     <Bug pattern="SF_SWITCH_NO_DEFAULT" />
   </Match>
 
+  <!-- Reason: Internal class that is used only as a key for an internal FormatCache.
For this reason we can
+   be sure, that equals will never be called with null or types other than MultipartKey.
+  -->
+  <Match>
+    <Class name="org.apache.commons.lang3.time.FormatCache$MultipartKey" />
+    <Method name="equals" />
+    <Bug pattern="BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.lang3.time.FormatCache$MultipartKey" />
+    <Method name="equals" />
+    <Bug pattern="NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT" />
+  </Match>
 </FindBugsFilter>



Mime
View raw message