Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B7E751006F for ; Sat, 28 Mar 2015 15:05:04 +0000 (UTC) Received: (qmail 41446 invoked by uid 500); 28 Mar 2015 15:05:04 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 41385 invoked by uid 500); 28 Mar 2015 15:05:04 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 41376 invoked by uid 99); 28 Mar 2015 15:05:04 -0000 Received: from eris.apache.org (HELO hades.apache.org) (140.211.11.105) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Mar 2015 15:05:04 +0000 Received: from hades.apache.org (localhost [127.0.0.1]) by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id 6D31BAC0281 for ; Sat, 28 Mar 2015 15:05:04 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1669782 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java Date: Sat, 28 Mar 2015 15:05:04 -0000 To: commits@commons.apache.org From: britter@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20150328150504.6D31BAC0281@hades.apache.org> Author: britter Date: Sat Mar 28 15:05:04 2015 New Revision: 1669782 URL: http://svn.apache.org/r1669782 Log: FindBugs: Load of known null value. At this point if lhs is null, rhs will can not be null. So evaluating the line with lhs == null will result in rhs.equals(null) which should always be false. Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java?rev=1669782&r1=1669781&r2=1669782&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java Sat Mar 28 15:05:04 2015 @@ -882,7 +882,7 @@ public class DiffBuilder implements Buil } // Not array type - if (lhs != null ? lhs.equals(rhs) : rhs.equals(lhs)) { + if (lhs != null && lhs.equals(rhs)) { return this; }