Return-Path: 
 <commits-return-45377-apmail-commons-commits-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-commits-archive@minotaur.apache.org
Delivered-To: apmail-commons-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D692217E1E
	for <apmail-commons-commits-archive@minotaur.apache.org>;
 Tue, 13 Jan 2015 20:39:57 +0000 (UTC)
Received: (qmail 59584 invoked by uid 500); 13 Jan 2015 20:39:59 -0000
Delivered-To: apmail-commons-commits-archive@commons.apache.org
Received: (qmail 59502 invoked by uid 500); 13 Jan 2015 20:39:59 -0000
Mailing-List: contact commits-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@commons.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@commons.apache.org>
List-Post: <mailto:commits@commons.apache.org>
List-Id: <commits.commons.apache.org>
Reply-To: dev@commons.apache.org
Delivered-To: mailing list commits@commons.apache.org
Received: (qmail 59492 invoked by uid 99); 13 Jan 2015 20:39:59 -0000
Received: from eris.apache.org (HELO hades.apache.org) (140.211.11.105)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 20:39:59 +0000
Received: from hades.apache.org (localhost [127.0.0.1])
	by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id
 49AC8AC01D7;
	Tue, 13 Jan 2015 20:39:59 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1651480 -
 /commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/checkdigit/AbstractCheckDigitTest.java
Date: Tue, 13 Jan 2015 20:39:59 -0000
To: commits@commons.apache.org
From: britter@apache.org
X-Mailer: svnmailer-1.0.9
Message-Id: <20150113203959.49AC8AC01D7@hades.apache.org>

Author: britter
Date: Tue Jan 13 20:39:58 2015
New Revision: 1651480

URL: http://svn.apache.org/r1651480
Log:
Generics and enhanced for loop

Modified:
    commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/checkdigit/AbstractCheckDigitTest.java

Modified: commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/checkdigit/AbstractCheckDigitTest.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/checkdigit/AbstractCheckDigitTest.java?rev=1651480&r1=1651479&r2=1651480&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/checkdigit/AbstractCheckDigitTest.java (original)
+++ commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/checkdigit/AbstractCheckDigitTest.java Tue Jan 13 20:39:58 2015
@@ -286,21 +286,21 @@ public abstract class AbstractCheckDigit
      * @return Codes with invalid check digits
      */
     protected String[] createInvalidCodes(String[] codes) {
-        List list = new ArrayList();
+        List<String> list = new ArrayList<String>();
 
         // create invalid check digit values
-        for (int i = 0; i < codes.length; i++) {
-            String code = removeCheckDigit(codes[i]);
-            String check  = checkDigit(codes[i]);
+        for (String fullCode : codes) {
+            String code = removeCheckDigit(fullCode);
+            String check = checkDigit(fullCode);
             for (int j = 0; j < POSSIBLE_CHECK_DIGITS.length(); j++) {
-                String curr =  POSSIBLE_CHECK_DIGITS.substring(j, j+1);//"" + Character.forDigit(j, 10);
+                String curr = POSSIBLE_CHECK_DIGITS.substring(j, j + 1);//"" + Character.forDigit(j, 10);
                 if (!curr.equals(check)) {
                     list.add(code + curr);
                 }
             }
         }
         
-        return (String[])list.toArray(new String[list.size()]);
+        return list.toArray(new String[list.size()]);
     }
 
     /**