Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0687D10FEC for ; Fri, 2 Jan 2015 14:17:48 +0000 (UTC) Received: (qmail 39363 invoked by uid 500); 2 Jan 2015 14:17:49 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 39289 invoked by uid 500); 2 Jan 2015 14:17:49 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 39278 invoked by uid 99); 2 Jan 2015 14:17:49 -0000 Received: from eris.apache.org (HELO hades.apache.org) (140.211.11.105) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jan 2015 14:17:49 +0000 Received: from hades.apache.org (localhost [127.0.0.1]) by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id 0FAD1AC08CB; Fri, 2 Jan 2015 14:17:49 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1649038 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java Date: Fri, 02 Jan 2015 14:17:49 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20150102141749.0FAD1AC08CB@hades.apache.org> Author: sebb Date: Fri Jan 2 14:17:48 2015 New Revision: 1649038 URL: http://svn.apache.org/r1649038 Log: https://issues.apache.org/jira/browse/VALIDATOR-307 Replace String.isEmpty() with Java 1.4 compatible code Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java?rev=1649038&r1=1649037&r2=1649038&view=diff ============================================================================== --- commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java (original) +++ commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java Fri Jan 2 14:17:48 2015 @@ -82,7 +82,7 @@ public class InetAddressValidator implem // verify that address subgroups are legal for (int i = 0; i <= 3; i++) { String ipSegment = groups[i]; - if (ipSegment == null || ipSegment.isEmpty()) { + if (ipSegment == null || ipSegment.length() == 0) { return false; } @@ -139,7 +139,7 @@ public class InetAddressValidator implem int emptyOctets = 0; for (int index = 0; index < octets.length; index++) { String octet = (String) octets[index]; - if (octet.isEmpty()) { + if (octet.length() == 0) { emptyOctets++; if (emptyOctets > 1) { return false;