commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From krosenv...@apache.org
Subject svn commit: r1650794 - in /commons/proper/compress/trunk: findbugs-exclude-filter.xml src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java
Date Sat, 10 Jan 2015 19:00:32 GMT
Author: krosenvold
Date: Sat Jan 10 19:00:31 2015
New Revision: 1650794

URL: http://svn.apache.org/r1650794
Log:
Fixed one findbugs warning, ignored another

Modified:
    commons/proper/compress/trunk/findbugs-exclude-filter.xml
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java

Modified: commons/proper/compress/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/findbugs-exclude-filter.xml?rev=1650794&r1=1650793&r2=1650794&view=diff
==============================================================================
--- commons/proper/compress/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/compress/trunk/findbugs-exclude-filter.xml Sat Jan 10 19:00:31 2015
@@ -157,4 +157,12 @@
     <Method name="equals" />
     <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS" />
   </Match>
+  
+  <!-- Reason: failure to delete a file that may not exist. And we really don't care that
much either -->
+  <Match>
+    <Class name="org.apache.commons.compress.archivers.zip.FileBasedScatterGatherBackingStore"
/>
+    <Method name="close" />
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
+  </Match>
+
 </FindBugsFilter>

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java?rev=1650794&r1=1650793&r2=1650794&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java
(original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java
Sat Jan 10 19:00:31 2015
@@ -50,7 +50,7 @@ public abstract class StreamCompressor i
     private long sourcePayloadLength = 0;
     private long totalWrittenToOutputStream = 0;
 
-    private final int bufferSize = 4096;
+    private static final int bufferSize = 4096;
     private final byte[] outputBuffer = new byte[bufferSize];
     private final byte[] readerBuf = new byte[bufferSize];
 



Mime
View raw message