commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brit...@apache.org
Subject svn commit: r1649392 - in /commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif: MakerNoteFieldTest.java TextFieldTest.java
Date Sun, 04 Jan 2015 19:52:17 GMT
Author: britter
Date: Sun Jan  4 19:52:16 2015
New Revision: 1649392

URL: http://svn.apache.org/r1649392
Log:
Remove commented out code

Modified:
    commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java
    commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java

Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java?rev=1649392&r1=1649391&r2=1649392&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java
(original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/MakerNoteFieldTest.java
Sun Jan  4 19:52:16 2015
@@ -27,18 +27,11 @@ import org.apache.commons.imaging.format
 import org.apache.commons.imaging.util.Debug;
 
 public class MakerNoteFieldTest extends SpecificExifTagTest {
-    // public MakerNoteFieldTest(String name)
-    // {
-    // super(name);
-    // }
 
     @Override
     protected void checkField(final File imageFile, final TiffField field)
             throws IOException, ImageReadException, ImageWriteException {
         if (field.getTag() != ExifTagConstants.EXIF_TAG_MAKER_NOTE.tag) {
-            // if (field.tag == EXIF_TAG_EXIF_OFFSET.tag)
-            // ;
-            // else
             return;
         }
 
@@ -53,18 +46,7 @@ public class MakerNoteFieldTest extends
         // Debug.debug("field", Debug.getType(field));
         Debug.debug();
 
-        // try
-        // {
-        // Object userCommentValue = field.getValue();
-        // Debug.debug("Text field value(" + field.tagInfo.name + ")",
-        // userCommentValue);
-        // // Debug.debug("userCommentValue", Debug.getType(userCommentValue));
-        // }
-        // catch (ImageReadException e)
-        // {
-        // Debug.debug("imageFile", imageFile);
-        // Debug.debug(e);
-        // }
+        // TODO assert something
 
     }
 

Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java?rev=1649392&r1=1649391&r2=1649392&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java
(original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/TextFieldTest.java
Sun Jan  4 19:52:16 2015
@@ -30,46 +30,26 @@ import org.apache.commons.imaging.util.D
 import org.junit.Assert;
 
 public class TextFieldTest extends SpecificExifTagTest {
-    // public TextFieldTest(String name)
-    // {
-    // super(name);
-    // }
 
     @Override
     protected void checkField(final File imageFile, final TiffField field)
             throws IOException, ImageReadException, ImageWriteException {
-        if (field.getTag() == ExifTagConstants.EXIF_TAG_USER_COMMENT.tag) { /*
-                                                                        * do
-                                                                        * nothing
-                                                                        */
+        if (field.getTag() == ExifTagConstants.EXIF_TAG_USER_COMMENT.tag) {
+            // do nothing
         } else if (field.getTag() == GpsTagConstants.GPS_TAG_GPS_PROCESSING_METHOD.tag
-                && field.getDirectoryType() == TiffDirectoryType.EXIF_DIRECTORY_GPS.directoryType)
{ /*
-                                                                                        
        * do
-                                                                                        
        * nothing
-                                                                                        
        */
+                && field.getDirectoryType() == TiffDirectoryType.EXIF_DIRECTORY_GPS.directoryType)
{
+                // do nothing
         } else if (field.getTag() == GpsTagConstants.GPS_TAG_GPS_AREA_INFORMATION.tag
-                && field.getDirectoryType() == TiffDirectoryType.EXIF_DIRECTORY_GPS.directoryType)
{ /*
-                                                                                        
        * do
-                                                                                        
        * nothing
-                                                                                        
        */
+                && field.getDirectoryType() == TiffDirectoryType.EXIF_DIRECTORY_GPS.directoryType)
{
+                // do nothing
         } else {
             return;
         }
 
-        // Debug.debug("field", field);
-        // Debug.debug("field", Debug.getType(field));
-        //
-        // Debug.debug("field", field.tag);
-        // Debug.debug("field", field.tagInfo);
-        // Debug.debug("field", Debug.getType(field));
-
         try {
             final Object textFieldValue = field.getValue();
             Assert.assertNotNull(textFieldValue);
-            // Debug.debug("imageFile", imageFile.getAbsoluteFile());
-            // Debug.debug("Text field value(" + field.tagInfo.name + ")",
-            // textFieldValue);
-            // Debug.debug("userCommentValue", Debug.getType(userCommentValue));
+            // TODO what else to assert?
         } catch (final ImageReadException e) {
             Debug.debug("imageFile", imageFile.getAbsoluteFile());
             Debug.debug(e);



Mime
View raw message