commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brit...@apache.org
Subject svn commit: r1649139 - /commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/AsciiFieldTest.java
Date Fri, 02 Jan 2015 22:19:13 GMT
Author: britter
Date: Fri Jan  2 22:19:13 2015
New Revision: 1649139

URL: http://svn.apache.org/r1649139
Log:
Since we're testing against one specific image and we know this image contains Exif metadata
we can safely remove this early return.

Modified:
    commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/AsciiFieldTest.java

Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/AsciiFieldTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/AsciiFieldTest.java?rev=1649139&r1=1649138&r2=1649139&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/AsciiFieldTest.java
(original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/AsciiFieldTest.java
Fri Jan  2 22:19:13 2015
@@ -50,10 +50,6 @@ public class AsciiFieldTest extends Exif
 
         // note that exif might be null if no Exif metadata is found.
         final TiffImageMetadata exif = jpegMetadata.getExif();
-        if (null == exif) {
-            return;
-        }
-
         final List<TiffField> fields = exif.getAllFields();
         final Map<Integer,TiffField> fieldMap = new Hashtable<Integer,TiffField>();
         // Build a simplified field tag -> field map, ignoring directory



Mime
View raw message