Return-Path: 
 <commits-return-44320-apmail-commons-commits-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-commits-archive@minotaur.apache.org
Delivered-To: apmail-commons-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6D21910957
	for <apmail-commons-commits-archive@minotaur.apache.org>;
 Fri, 12 Dec 2014 21:15:22 +0000 (UTC)
Received: (qmail 15611 invoked by uid 500); 12 Dec 2014 21:15:22 -0000
Delivered-To: apmail-commons-commits-archive@commons.apache.org
Received: (qmail 15539 invoked by uid 500); 12 Dec 2014 21:15:21 -0000
Mailing-List: contact commits-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@commons.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@commons.apache.org>
List-Post: <mailto:commits@commons.apache.org>
List-Id: <commits.commons.apache.org>
Reply-To: dev@commons.apache.org
Delivered-To: mailing list commits@commons.apache.org
Received: (qmail 15529 invoked by uid 99); 12 Dec 2014 21:15:21 -0000
Received: from eris.apache.org (HELO hades.apache.org) (140.211.11.105)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Dec 2014 21:15:21 +0000
Received: from hades.apache.org (localhost [127.0.0.1])
	by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id
 DD44DAC094D;
	Fri, 12 Dec 2014 21:15:19 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1645076 - in /commons/proper/lang/trunk/src:
 main/java/org/apache/commons/lang3/math/NumberUtils.java
 test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
Date: Fri, 12 Dec 2014 21:15:19 -0000
To: commits@commons.apache.org
From: mbenson@apache.org
X-Mailer: svnmailer-1.0.9
Message-Id: <20141212211520.DD44DAC094D@hades.apache.org>

Author: mbenson
Date: Fri Dec 12 21:15:18 2014
New Revision: 1645076

URL: http://svn.apache.org/r1645076
Log:
clarify behavior of #isNumber() with blanks

Modified:
    commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java?rev=1645076&r1=1645075&r2=1645076&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java Fri Dec 12 21:15:18 2014
@@ -1344,7 +1344,7 @@ public class NumberUtils {
      * <code>false</code>, since <code>9</code> is not a valid octal value.
      * However, numbers beginning with {@code 0.} are treated as decimal.</p>
      *
-     * <p><code>Null</code> and empty String will return
+     * <p><code>null</code> and empty/blank {@code String} will return
      * <code>false</code>.</p>
      *
      * @param str  the <code>String</code> to check

Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java?rev=1645076&r1=1645075&r2=1645076&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java Fri Dec 12 21:15:18 2014
@@ -1199,6 +1199,8 @@ public class NumberUtilsTest {
 
         compareIsNumberWithCreateNumber(null, false);
         compareIsNumberWithCreateNumber("", false);
+        compareIsNumberWithCreateNumber(" ", false);
+        compareIsNumberWithCreateNumber("\r\n\t", false);
         compareIsNumberWithCreateNumber("--2.3", false);
         compareIsNumberWithCreateNumber(".12.3", false);
         compareIsNumberWithCreateNumber("-123E", false);