commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brit...@apache.org
Subject svn commit: r1648310 - in /commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats: bmp/BmpReadTest.java dcx/DcxReadTest.java
Date Mon, 29 Dec 2014 11:56:26 GMT
Author: britter
Date: Mon Dec 29 11:56:26 2014
New Revision: 1648310

URL: http://svn.apache.org/r1648310
Log:
Better add tests to ignore so that they show up in the surefire report instead of implementing
them empty which may make us forget about them.

Modified:
    commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java
    commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java

Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java?rev=1648310&r1=1648309&r2=1648310&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java
(original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/bmp/BmpReadTest.java
Mon Dec 29 11:56:26 2014
@@ -33,6 +33,7 @@ import org.apache.commons.imaging.ImageR
 import org.apache.commons.imaging.Imaging;
 import org.apache.commons.imaging.common.IImageMetadata;
 import org.apache.commons.imaging.util.Debug;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -59,8 +60,8 @@ public class BmpReadTest extends BmpBase
         // TODO assert more
     }
 
-    // TODO BmpImageParser doesn't support MetaData creation, however RoundtripTest has to
be refactored completely before the code can be changed
-    @Test//(expected = UnsupportedOperationException.class)
+    @Ignore(value = "RoundtripTest has to be fixed befor implementation can throw UnsupportedOperationException")
+    @Test(expected = UnsupportedOperationException.class)
     public void testMetaData() throws ImageReadException, IOException {
         Imaging.getMetadata(imageFile);
     }

Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java?rev=1648310&r1=1648309&r2=1648310&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java
(original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/dcx/DcxReadTest.java
Mon Dec 29 11:56:26 2014
@@ -27,6 +27,7 @@ import java.util.Collections;
 import org.apache.commons.imaging.ImageInfo;
 import org.apache.commons.imaging.Imaging;
 import org.apache.commons.imaging.common.IImageMetadata;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -45,18 +46,16 @@ public class DcxReadTest extends DcxBase
         this.imageFile = imageFile;
     }
 
-    // TODO this should throw USO, but Roundtrip test has to be refactored completely before
this can be changed
-    @Test//(expected = UnsupportedOperationException.class)
+    @Ignore(value = "RoundtripTest has to be fixed befor implementation can throw UnsupportedOperationException")
+    @Test(expected = UnsupportedOperationException.class)
     public void testImageMetadata() throws Exception {
-        final IImageMetadata metadata = Imaging.getMetadata(imageFile);
-        // assertNotNull(metadata);
+        Imaging.getMetadata(imageFile);
     }
 
-    // TODO this should throw USO, but Roundtrip test has to be refactored completely before
this can be changed
-    @Test//(expected = UnsupportedOperationException.class)
+    @Ignore(value = "RoundtripTest has to be fixed befor implementation can throw UnsupportedOperationException")
+    @Test(expected = UnsupportedOperationException.class)
     public void testImageInfo() throws Exception {
-        final ImageInfo imageInfo = Imaging.getImageInfo(imageFile, Collections.<String,
Object> emptyMap());
-        // assertNotNull(imageInfo);
+        Imaging.getImageInfo(imageFile, Collections.<String, Object> emptyMap());
     }
 
     @Test



Mime
View raw message