commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1632039 - /commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java
Date Wed, 15 Oct 2014 13:58:10 GMT
Author: ggregory
Date: Wed Oct 15 13:58:09 2014
New Revision: 1632039

URL: http://svn.apache.org/r1632039
Log:
Statement unnecessarily nested within else clause.

Modified:
    commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java

Modified: commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java?rev=1632039&r1=1632038&r2=1632039&view=diff
==============================================================================
--- commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java (original)
+++ commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java Wed Oct
15 13:58:09 2014
@@ -437,12 +437,9 @@ public class HtmlEmail extends MultiPart
             {
                 return ii.getCid();
             }
-            else
-            {
-                throw new EmailException("embedded DataSource '" + name
-                    + "' is already bound to name " + ii.getDataSource().toString()
-                    + "; existing names cannot be rebound");
-            }
+            throw new EmailException("embedded DataSource '" + name
+                + "' is already bound to name " + ii.getDataSource().toString()
+                + "; existing names cannot be rebound");
         }
 
         final String cid = EmailUtils.randomAlphabetic(HtmlEmail.CID_LENGTH).toLowerCase();



Mime
View raw message