commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ohe...@apache.org
Subject svn commit: r1614979 - in /commons/proper/configuration/trunk/src: main/java/org/apache/commons/configuration/ test/java/org/apache/commons/configuration/
Date Thu, 31 Jul 2014 20:05:34 GMT
Author: oheger
Date: Thu Jul 31 20:05:34 2014
New Revision: 1614979

URL: http://svn.apache.org/r1614979
Log:
Removed setRootNode() method from HierarchicalConfiguration interface.

Modified:
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/HierarchicalConfiguration.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractHierarchicalConfiguration.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestBaseHierarchicalConfigurationSynchronization.java

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/HierarchicalConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/HierarchicalConfiguration.java?rev=1614979&r1=1614978&r2=1614979&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/HierarchicalConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/HierarchicalConfiguration.java
Thu Jul 31 20:05:34 2014
@@ -53,13 +53,6 @@ public interface HierarchicalConfigurati
     T getRootNode();
 
     /**
-     * Sets the root node of this hierarchical configuration.
-     *
-     * @param rootNode the root node
-     */
-    void setRootNode(T rootNode);
-
-    /**
      * Sets the expression engine to be used by this configuration. All property
      * keys this configuration has to deal with will be interpreted by this
      * engine.

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractHierarchicalConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractHierarchicalConfiguration.java?rev=1614979&r1=1614978&r2=1614979&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractHierarchicalConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractHierarchicalConfiguration.java
Thu Jul 31 20:05:34 2014
@@ -73,20 +73,6 @@ public class TestAbstractHierarchicalCon
     }
 
     @Test
-    public void testSetRootNode()
-    {
-        ImmutableNode root = NodeStructureHelper.createNode("testNode", null);
-        config.setRootNode(root);
-        assertSame("Wrong root node", root, config.getRootNode());
-    }
-
-    @Test(expected = IllegalArgumentException.class)
-    public void testSetRootNodeNull()
-    {
-        config.setRootNode(null);
-    }
-
-    @Test
     public void testIsEmptyFalse()
     {
         assertFalse(config.isEmpty());

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestBaseHierarchicalConfigurationSynchronization.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestBaseHierarchicalConfigurationSynchronization.java?rev=1614979&r1=1614978&r2=1614979&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestBaseHierarchicalConfigurationSynchronization.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestBaseHierarchicalConfigurationSynchronization.java
Thu Jul 31 20:05:34 2014
@@ -126,16 +126,6 @@ public class TestBaseHierarchicalConfigu
     }
 
     /**
-     * Tests whether setRootNode() is correctly synchronized.
-     */
-    @Test
-    public void testSetRootNodeSynchronized()
-    {
-        config.setRootNode(NodeStructureHelper.createNode("testRoot", null));
-        sync.verify(Methods.BEGIN_WRITE, Methods.END_WRITE);
-    }
-
-    /**
      * Tests whether synchronization is performed when copying a configuration.
      */
     @Test



Mime
View raw message