commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1606482 - /commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
Date Sun, 29 Jun 2014 12:09:37 GMT
Author: ggregory
Date: Sun Jun 29 12:09:37 2014
New Revision: 1606482

URL: http://svn.apache.org/r1606482
Log:
Statement unnecessarily nested within else clause.

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java?rev=1606482&r1=1606481&r2=1606482&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
Sun Jun 29 12:09:37 2014
@@ -448,9 +448,7 @@ public class Subroutines{
                     if (instructions_assigned.contains(element)){
                         throw new StructuralCodeConstraintException("Instruction '"+element+"'
is part of more than one subroutine (or of the top level and a subroutine).");
                     }
-                    else{
-                        instructions_assigned.add(element);
-                    }
+                    instructions_assigned.add(element);
                 }
             }
             if (actual != all[0]){// If we don't deal with the top-level 'subroutine'



Mime
View raw message