commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1606481 - /commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
Date Sun, 29 Jun 2014 12:09:16 GMT
Author: ggregory
Date: Sun Jun 29 12:09:15 2014
New Revision: 1606481

URL: http://svn.apache.org/r1606481
Log:
Statement unnecessarily nested within else clause.

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java?rev=1606481&r1=1606480&r2=1606481&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
Sun Jun 29 12:09:15 2014
@@ -181,13 +181,11 @@ public class Subroutines{
             if (localVariable == UNSET){
                 throw new AssertionViolatedException("Set the localVariable first!");
             }
-            else{
-                // Something is wrong when an ASTORE is targeted that does not operate on
the same local variable than the rest of the
-                // JsrInstruction-targets and the RET.
-                // (We don't know out leader here so we cannot check if we're really targeted!)
-                if (localVariable != ((ASTORE) (((JsrInstruction) jsrInst.getInstruction()).getTarget().getInstruction())).getIndex()){
-                    throw new AssertionViolatedException("Setting a wrong JsrInstruction.");
-                }
+            // Something is wrong when an ASTORE is targeted that does not operate on the
same local variable than the rest of the
+            // JsrInstruction-targets and the RET.
+            // (We don't know out leader here so we cannot check if we're really targeted!)
+            if (localVariable != ((ASTORE) (((JsrInstruction) jsrInst.getInstruction()).getTarget().getInstruction())).getIndex()){
+                throw new AssertionViolatedException("Setting a wrong JsrInstruction.");
             }
             theJSRs.add(jsrInst);
         }



Mime
View raw message