commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1587001 - in /commons/proper/net/trunk/src/test/java/org/apache/commons/net: ftp/parser/MLSDComparison.java pop3/POP3ConstructorTest.java telnet/TelnetClientTest.java tftp/TFTPServer.java time/TimeTCPClientTest.java
Date Sun, 13 Apr 2014 14:17:12 GMT
Author: sebb
Date: Sun Apr 13 14:17:11 2014
New Revision: 1587001

URL: http://svn.apache.org/r1587001
Log:
Remove useless Javadoc (causes IDE Javadoc warnings)

Modified:
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/MLSDComparison.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/tftp/TFTPServer.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java

Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/MLSDComparison.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/MLSDComparison.java?rev=1587001&r1=1587000&r2=1587001&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/MLSDComparison.java
(original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/parser/MLSDComparison.java
Sun Apr 13 14:17:11 2014
@@ -137,8 +137,8 @@ public class MLSDComparison {
     /**
      * Compare two instances to see if they are the same,
      * ignoring any uninitialised fields.
-     *
-     * @param b
+     * @param a first instance 
+     * @param b second instance
      * @return true if the initialised fields are the same
      * @since 3.0
      */

Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java?rev=1587001&r1=1587000&r2=1587001&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java
(original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java
Sun Apr 13 14:17:11 2014
@@ -95,7 +95,7 @@ public class POP3ConstructorTest extends
         assertNotNull(pop._replyLines);
     }
 
-    /**
+    /*
      * Test the default constructor
      *
      */

Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java?rev=1587001&r1=1587000&r2=1587001&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java
(original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java
Sun Apr 13 14:17:11 2014
@@ -23,12 +23,12 @@ import java.io.OutputStream;
 import java.io.PipedInputStream;
 import java.io.PipedOutputStream;
 
-/***
+/**
  * JUnit test class for TelnetClient.s
  * Implements protocol compliance tests
  * <p>
  * @author Bruno D'Avanzo
- ***/
+ */
 public class TelnetClientTest
 extends TestCase implements TelnetNotificationHandler
 {
@@ -70,9 +70,9 @@ extends TestCase implements TelnetNotifi
     protected int numwill = 0;
     protected int numwont = 0;
 
-    /***
+    /*
      * open connections needed for the tests for the test.
-     ***/
+     */
     @Override
     protected void setUp() throws Exception
     {
@@ -166,9 +166,9 @@ extends TestCase implements TelnetNotifi
 
     }
 
-    /***
+    /*
      * tests the initial condition of the sessions
-     ***/
+     */
     public void testInitial() throws Exception
     {
         boolean connect1_ok = false;
@@ -248,9 +248,9 @@ extends TestCase implements TelnetNotifi
         assertTrue(add_invalid_ok2);
     }
 
-    /***
+    /*
      * protocol compliance test for option negotiation
-     ***/
+     */
     public void testOptionNegotiation() throws Exception
     {
         boolean negotiation1_ok = false;
@@ -431,9 +431,9 @@ extends TestCase implements TelnetNotifi
     }
 
 
-    /***
+    /*
      * protocol compliance test for option renegotiation
-     ***/
+     */
     public void testOptionRenegotiation() throws Exception
     {
         boolean negotiation1_ok = false;
@@ -504,9 +504,9 @@ extends TestCase implements TelnetNotifi
         assertTrue(!OPTIONS.client.getLocalOptionState(TelnetOption.ECHO));
     }
 
-    /***
+    /*
      * test of option negotiation notification
-     ***/
+     */
     public void testNotification() throws Exception
     {
         byte buffread1[] = new byte[6];
@@ -574,9 +574,9 @@ extends TestCase implements TelnetNotifi
     }
 
 
-    /***
+    /*
      * protocol compliance test in case of option handler removal
-     ***/
+     */
     public void testDeleteOptionHandler() throws Exception
     {
         boolean remove_ok = false;
@@ -649,9 +649,9 @@ extends TestCase implements TelnetNotifi
     }
 
 
-    /***
+    /*
      * test of AYT functionality
-     ***/
+     */
     public void testAYT() throws Exception
     {
         boolean ayt_true_ok = false;
@@ -692,9 +692,9 @@ extends TestCase implements TelnetNotifi
         assertTrue(ayt_false_ok);
     }
 
-    /***
+    /*
      * test of Spy functionality
-     ***/
+     */
     public void testSpy() throws Exception
     {
         boolean test1spy_ok = false;
@@ -759,9 +759,9 @@ extends TestCase implements TelnetNotifi
         pi.close();
     }
 
-    /***
+    /*
      * test of setReaderThread
-     ***/
+     */
     public void testSetReaderThread() throws Exception
     {
         boolean negotiation1_ok = false;
@@ -847,9 +847,9 @@ extends TestCase implements TelnetNotifi
     }
 
 
-    /***
+    /*
      * Helper method. compares two arrays of int
-     ***/
+     */
     protected boolean equalBytes(byte a1[], byte a2[])
     {
         if(a1.length != a2.length)
@@ -870,7 +870,7 @@ extends TestCase implements TelnetNotifi
         }
     }
 
-    /***
+    /*
      * Callback method called when TelnetClient receives an option
      * negotiation command.
      * <p>
@@ -879,7 +879,7 @@ extends TestCase implements TelnetNotifi
      * <p>
      * @param option_code - code of the option negotiated
      * <p>
-     ***/
+     */
 //    @Override
     public void receivedNegotiation(int negotiation_code, int option_code)
     {

Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/tftp/TFTPServer.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/tftp/TFTPServer.java?rev=1587001&r1=1587000&r2=1587001&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/tftp/TFTPServer.java (original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/tftp/TFTPServer.java Sun
Apr 13 14:17:11 2014
@@ -203,6 +203,7 @@ public class TFTPServer implements Runna
 
     /**
      * The current socket timeout used during transfers in milliseconds.
+     * @return the timeout value
      */
     public int getSocketTimeout()
     {

Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java?rev=1587001&r1=1587000&r2=1587001&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java
(original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java
Sun Apr 13 14:17:11 2014
@@ -61,9 +61,9 @@ public class TimeTCPClientTest extends T
         assertEquals(baseTime, -TimeTCPClient.SECONDS_1900_TO_1970);
     }
 
-    /***
+    /*
      * tests the times retrieved via the Time protocol implementation.
-     ***/
+     */
     public void testCompareTimes() throws Exception
     {
         openConnections();



Mime
View raw message