Return-Path: 
 <commits-return-39574-apmail-commons-commits-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-commits-archive@minotaur.apache.org
Delivered-To: apmail-commons-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1E47910796
	for <apmail-commons-commits-archive@minotaur.apache.org>;
 Thu, 13 Feb 2014 20:26:42 +0000 (UTC)
Received: (qmail 2584 invoked by uid 500); 13 Feb 2014 20:26:38 -0000
Delivered-To: apmail-commons-commits-archive@commons.apache.org
Received: (qmail 2458 invoked by uid 500); 13 Feb 2014 20:26:38 -0000
Mailing-List: contact commits-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@commons.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@commons.apache.org>
List-Post: <mailto:commits@commons.apache.org>
List-Id: <commits.commons.apache.org>
Reply-To: dev@commons.apache.org
Delivered-To: mailing list commits@commons.apache.org
Received: (qmail 2444 invoked by uid 99); 13 Feb 2014 20:26:38 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Feb 2014 20:26:38 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Feb 2014 20:26:34 +0000
Received: from eris.apache.org (localhost [127.0.0.1])
	by eris.apache.org (Postfix) with ESMTP id E5D0123889D5;
	Thu, 13 Feb 2014 20:26:12 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1568033 - in /commons/proper/weaver/trunk:
 ant/test/pom.xml
 example/pom.xml example/src/test/resources/java.policy
Date: Thu, 13 Feb 2014 20:26:12 -0000
To: commits@commons.apache.org
From: mbenson@apache.org
X-Mailer: svnmailer-1.0.9
Message-Id: <20140213202612.E5D0123889D5@eris.apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org

Author: mbenson
Date: Thu Feb 13 20:26:12 2014
New Revision: 1568033

URL: http://svn.apache.org/r1568033
Log:
filter java policy file to handle cross platform tomfoolery; ensure antlib test build is right

Modified:
    commons/proper/weaver/trunk/ant/test/pom.xml
    commons/proper/weaver/trunk/example/pom.xml
    commons/proper/weaver/trunk/example/src/test/resources/java.policy

Modified: commons/proper/weaver/trunk/ant/test/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/weaver/trunk/ant/test/pom.xml?rev=1568033&r1=1568032&r2=1568033&view=diff
==============================================================================
--- commons/proper/weaver/trunk/ant/test/pom.xml (original)
+++ commons/proper/weaver/trunk/ant/test/pom.xml Thu Feb 13 20:26:12 2014
@@ -36,11 +36,6 @@ under the License.
   <dependencies>
     <dependency>
       <groupId>org.apache.commons</groupId>
-      <artifactId>commons-weaver-example</artifactId>
-      <version>${project.version}</version>
-    </dependency>
-    <dependency>
-      <groupId>org.apache.commons</groupId>
       <artifactId>commons-weaver-privilizer</artifactId>
       <version>${project.version}</version>
       <scope>provided</scope>
@@ -58,23 +53,11 @@ under the License.
   </dependencies>
   <profiles>
     <profile>
-      <id>sec</id>
-      <build>
-        <plugins>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-surefire-plugin</artifactId>
-            <configuration>
-              <argLine>-Djava.security.manager -Djava.security.policy=${project.build.directory}/example-test-resources/java.policy</argLine>
-            </configuration>
-          </plugin>
-        </plugins>
-      </build>
-    </profile>
-    <profile>
       <id>antlib-test</id>
       <activation>
-        <activeByDefault>true</activeByDefault>
+        <property>
+          <name>!antlib-test-skip</name>
+        </property>
       </activation>
       <build>
         <plugins>
@@ -86,14 +69,19 @@ under the License.
                 <id>unpack-example-sources</id>
                 <phase>generate-sources</phase>
                 <goals>
-                  <goal>unpack-dependencies</goal>
+                  <goal>unpack</goal>
                 </goals>
                 <configuration>
-                  <classifier>sources</classifier>
-                  <includeGroupIds>org.apache.commons</includeGroupIds>
-                  <includeArtifactIds>commons-weaver-example</includeArtifactIds>
-                  <includes>**/*.java</includes>
-                  <outputDirectory>${project.build.directory}/example-sources</outputDirectory>
+                  <artifactItems>
+                    <artifactItems>
+                      <groupId>org.apache.commons</groupId>
+                      <artifactId>commons-weaver-example</artifactId>
+                      <version>${project.version}</version>
+                      <classifier>sources</classifier>
+                      <includes>**/*.java</includes>
+                      <outputDirectory>${project.build.directory}/example-sources</outputDirectory>
+                    </artifactItems>
+                  </artifactItems>
                 </configuration>
               </execution>
               <execution>
@@ -104,34 +92,45 @@ under the License.
                 </goals>
                 <configuration>
                   <outputDirectory>${project.build.directory}/compile-classpath</outputDirectory>
+                  <includeArtifactIds>commons-weaver-antlib,commons-weaver-privilizer,commons-weaver-privilizer-api,commons-io,asm,asm-commons,asm-tree,asm-util</includeArtifactIds>
                 </configuration>
               </execution>
               <execution>
                 <id>unpack-example-test-sources</id>
                 <phase>generate-test-sources</phase>
                 <goals>
-                  <goal>unpack-dependencies</goal>
+                  <goal>unpack</goal>
                 </goals>
                 <configuration>
-                  <classifier>test-sources</classifier>
-                  <includeGroupIds>org.apache.commons</includeGroupIds>
-                  <includeArtifactIds>commons-weaver-example</includeArtifactIds>
-                  <includes>**/*.java</includes>
-                  <outputDirectory>${project.build.directory}/example-test-sources</outputDirectory>
+                  <artifactItems>
+                    <artifactItems>
+                      <groupId>org.apache.commons</groupId>
+                      <artifactId>commons-weaver-example</artifactId>
+                      <version>${project.version}</version>
+                      <classifier>test-sources</classifier>
+                      <includes>**/*.java</includes>
+                      <outputDirectory>${project.build.directory}/example-test-sources</outputDirectory>
+                    </artifactItems>
+                  </artifactItems>
                 </configuration>
               </execution>
               <execution>
                 <id>unpack-example-test-resources</id>
                 <phase>generate-test-resources</phase>
                 <goals>
-                  <goal>unpack-dependencies</goal>
+                  <goal>unpack</goal>
                 </goals>
                 <configuration>
-                  <classifier>test-sources</classifier>
-                  <includeGroupIds>org.apache.commons</includeGroupIds>
-                  <includeArtifactIds>commons-weaver-example</includeArtifactIds>
-                  <includes>java.policy</includes>
-                  <outputDirectory>${project.build.directory}/example-test-resources</outputDirectory>
+                  <artifactItems>
+                    <artifactItems>
+                      <groupId>org.apache.commons</groupId>
+                      <artifactId>commons-weaver-example</artifactId>
+                      <version>${project.version}</version>
+                      <classifier>test-sources</classifier>
+                      <includes>java.policy</includes>
+                      <outputDirectory>${project.build.directory}/example-test-resources</outputDirectory>
+                    </artifactItems>
+                  </artifactItems>
                 </configuration>
               </execution>
             </executions>
@@ -156,11 +155,9 @@ under the License.
 
                       <cw:weave>
                         <cw:settings target="${project.build.outputDirectory}" classpathref="cp">
-                          <propertyset>
-                            <propertyref name="privilizer.policy" />
-                          </propertyset>
                           <properties>
-                            <privilizer.accessLevel>PRIVATE</privilizer.accessLevel>
+                            <privilizer.policy>${privilizer.policy}</privilizer.policy>
+                            <privilizer.accessLevel>PACKAGE</privilizer.accessLevel>
                           </properties>
                         </cw:settings>
                       </cw:weave>
@@ -169,6 +166,18 @@ under the License.
                 </configuration>
               </execution>
             </executions>
+            <dependencies>
+              <dependency>
+                <groupId>org.apache.commons</groupId>
+                <artifactId>commons-weaver-privilizer</artifactId>
+                <version>${project.version}</version>
+              </dependency>
+              <dependency>
+                <groupId>org.apache.ant</groupId>
+                <artifactId>ant</artifactId>
+                <version>${ant.version}</version>
+              </dependency>
+            </dependencies>
           </plugin>
           <plugin>
             <groupId>org.codehaus.mojo</groupId>
@@ -198,21 +207,60 @@ under the License.
                   </sources>
                 </configuration>
               </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+    <profile>
+      <id>sec</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-antrun-plugin</artifactId>
+            <executions>
               <execution>
-                <id>add-test-resources</id>
-                <phase>generate-test-resources</phase>
+                <id>filter-testResources</id>
+                <phase>process-test-resources</phase>
                 <goals>
-                  <goal>add-test-resource</goal>
+                  <goal>run</goal>
                 </goals>
                 <configuration>
-                  <resources>
-                    <resource>
-                      <directory>${project.build.directory}/example-test-resources</directory>
-                    </resource>
-                  </resources>
+                  <target>
+                    <mkdir dir="${project.build.testOutputDirectory}" />
+                    <condition property="slash" value="/" else="">
+                      <os family="windows" />
+                    </condition>
+                    <copy todir="${project.build.testOutputDirectory}" overwrite="true">
+                      <fileset dir="${project.build.directory}/example-test-resources" erroronmissingdir="false" />
+                      <filterchain>
+                        <expandproperties />
+                        <!-- append extra slash on windows only -->
+                        <replacestring from="file://" to="file://${slash}" />
+                        <replacestring from="${file.separator}" to="/" />
+                        <!-- preserve system-specific file separator -->
+                        <replacestring from="$${preserve.project.build.directory}" to="${project.build.directory}" />
+                      </filterchain>
+                    </copy>
+                  </target>
                 </configuration>
               </execution>
             </executions>
+            <dependencies>
+              <dependency>
+                <groupId>org.apache.ant</groupId>
+                <artifactId>ant</artifactId>
+                <version>${ant.version}</version>
+              </dependency>
+            </dependencies>
+          </plugin>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-surefire-plugin</artifactId>
+            <configuration>
+              <argLine>-Djava.security.manager -Djava.security.policy=${project.build.testOutputDirectory}/java.policy</argLine>
+            </configuration>
           </plugin>
         </plugins>
       </build>

Modified: commons/proper/weaver/trunk/example/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/weaver/trunk/example/pom.xml?rev=1568033&r1=1568032&r2=1568033&view=diff
==============================================================================
--- commons/proper/weaver/trunk/example/pom.xml (original)
+++ commons/proper/weaver/trunk/example/pom.xml Thu Feb 13 20:26:12 2014
@@ -109,6 +109,19 @@ under the License.
           <redirectTestOutputToFile>true</redirectTestOutputToFile>
         </configuration>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-resources-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>default-testResources</id>
+            <phase />
+            <goals>
+              <goal>testResources</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
 
     <pluginManagement>
@@ -128,9 +141,53 @@ under the License.
         <plugins>
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-antrun-plugin</artifactId>
+            <executions>
+              <execution>
+                <id>filter-testResources</id>
+                <phase>process-test-resources</phase>
+                <goals>
+                  <goal>run</goal>
+                </goals>
+                <configuration>
+                  <target>
+                    <mkdir dir="${project.build.testOutputDirectory}" />
+                    <condition property="slash" value="/" else="">
+                      <os family="windows" />
+                    </condition>
+                    <copy todir="${project.build.testOutputDirectory}" overwrite="true">
+                      <fileset dir="${project.basedir}/src/test/resources" erroronmissingdir="false" />
+                      <filterchain>
+                        <expandproperties />
+                        <!-- append extra slash on windows only -->
+                        <replacestring from="file://" to="file://${slash}" />
+                        <replacestring from="${file.separator}" to="/" />
+                        <!-- preserve system-specific file separator -->
+                        <expandproperties>
+                          <propertyset>
+                            <propertyref prefix="project." />
+                            <globmapper from="*" to="preserve.*" />
+                          </propertyset>
+                        </expandproperties>
+                      </filterchain>
+                    </copy>
+                  </target>
+                </configuration>
+              </execution>
+            </executions>
+            <dependencies>
+              <dependency>
+                <groupId>org.apache.ant</groupId>
+                <artifactId>ant</artifactId>
+                <version>1.8.4</version>
+              </dependency>
+            </dependencies>
+          </plugin>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-surefire-plugin</artifactId>
             <configuration>
-              <argLine>-Djava.security.manager -Djava.security.policy=${basedir}/src/test/resources/java.policy</argLine>
+              <argLine>-Djava.security.manager -Djava.security.policy=${project.build.testOutputDirectory}/java.policy</argLine>
             </configuration>
           </plugin>
         </plugins>

Modified: commons/proper/weaver/trunk/example/src/test/resources/java.policy
URL: http://svn.apache.org/viewvc/commons/proper/weaver/trunk/example/src/test/resources/java.policy?rev=1568033&r1=1568032&r2=1568033&view=diff
==============================================================================
--- commons/proper/weaver/trunk/example/src/test/resources/java.policy (original)
+++ commons/proper/weaver/trunk/example/src/test/resources/java.policy Thu Feb 13 20:26:12 2014
@@ -21,8 +21,7 @@
 grant
 {
   // let everyone read target dir
-  permission java.io.FilePermission "${user.dir}${/}target${/}-", "read";
-  permission java.security.AllPermission;
+  permission java.io.FilePermission "${preserve.project.build.directory}${/}-", "read";
 };
 
 // we don't care about the permissions of the testing infrastructure,
@@ -38,7 +37,14 @@ grant codeBase "file://${user.home}/.m2/
   permission java.security.AllPermission;
 };
 
-grant codeBase "file://${user.dir}/target/classes/-"
+// surefire booter;
+grant codeBase "file://${project.build.directory}/surefire/-"
+{
+  permission java.security.AllPermission;
+};
+
+// classes under test
+grant codeBase "file://${project.build.outputDirectory}/-"
 {
   permission java.util.PropertyPermission "foo", "read,write";
   permission java.util.PropertyPermission "bar", "read,write";