Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A78510F7C for ; Thu, 13 Feb 2014 11:46:07 +0000 (UTC) Received: (qmail 61019 invoked by uid 500); 13 Feb 2014 11:46:05 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 60707 invoked by uid 500); 13 Feb 2014 11:46:03 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 60679 invoked by uid 99); 13 Feb 2014 11:46:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Feb 2014 11:46:00 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Feb 2014 11:45:59 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id D4B6F238897A; Thu, 13 Feb 2014 11:45:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1567890 - /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java Date: Thu, 13 Feb 2014 11:45:39 -0000 To: commits@commons.apache.org From: markt@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140213114539.D4B6F238897A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: markt Date: Thu Feb 13 11:45:39 2014 New Revision: 1567890 URL: http://svn.apache.org/r1567890 Log: Add some JMX to this test so help with debugging Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java?rev=1567890&r1=1567889&r2=1567890&view=diff ============================================================================== --- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java (original) +++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java Thu Feb 13 11:45:39 2014 @@ -23,6 +23,7 @@ import java.sql.PreparedStatement; import java.sql.Statement; import java.sql.SQLException; +import javax.management.ObjectName; import javax.sql.DataSource; import junit.framework.Test; @@ -31,6 +32,7 @@ import junit.framework.TestSuite; import org.apache.commons.pool2.ObjectPool; import org.apache.commons.pool2.impl.GenericObjectPool; +import org.apache.commons.pool2.impl.GenericObjectPoolConfig; import org.junit.Assert; /** @@ -79,13 +81,19 @@ public class TestPStmtPooling extends Te ConnectionFactory connFactory = new DriverManagerConnectionFactory( "jdbc:apache:commons:testdriver","u1","p1"); + ObjectName oName = new ObjectName("UnitTests:DataSource=test"); PoolableConnectionFactory pcf = - new PoolableConnectionFactory(connFactory, null); + new PoolableConnectionFactory(connFactory, oName); pcf.setPoolStatements(true); pcf.setDefaultReadOnly(Boolean.FALSE); pcf.setDefaultAutoCommit(Boolean.TRUE); - ObjectPool connPool = new GenericObjectPool<>(pcf); + GenericObjectPoolConfig config = new GenericObjectPoolConfig(); + config.setJmxNameBase("UnitTests:DataSource=test,connectionpool=connections"); + config.setJmxNamePrefix(""); + ObjectPool connPool = + new GenericObjectPool<>(pcf, config); + pcf.setPool(connPool); DataSource ds = new PoolingDataSource<>(connPool);