commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1571766 - /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java
Date Tue, 25 Feb 2014 17:44:50 GMT
Author: ggregory
Date: Tue Feb 25 17:44:49 2014
New Revision: 1571766

URL: http://svn.apache.org/r1571766
Log:
Simplify: Statement unnecessarily nested within else clause. The corresponding then clause
does not complete normally.

Modified:
    commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java

Modified: commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java?rev=1571766&r1=1571765&r2=1571766&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java
(original)
+++ commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java
Tue Feb 25 17:44:49 2014
@@ -39,9 +39,8 @@ class PoolKey implements Serializable {
             PoolKey pk = (PoolKey)obj;
             return (null == datasourceName ? null == pk.datasourceName : datasourceName.equals(pk.datasourceName))
&&
                 (null == username ? null == pk.username : username.equals(pk.username));
-        } else {
-            return false;   
         }
+        return false;
     }
 
     @Override



Mime
View raw message