commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1571738 - in /commons/proper/configuration/trunk/src: main/java/org/apache/commons/configuration/ main/java/org/apache/commons/configuration/event/ main/java/org/apache/commons/configuration/interpol/ main/java/org/apache/commons/configura...
Date Tue, 25 Feb 2014 16:42:20 GMT
Author: ggregory
Date: Tue Feb 25 16:42:18 2014
New Revision: 1571738

URL: http://svn.apache.org/r1571738
Log:
Add final modifier to private fields.

Modified:
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/BaseHierarchicalConfiguration.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/CombinedConfiguration.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/ConfigurationMap.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DynamicCombinedConfiguration.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/JNDIConfiguration.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/PatternSubtreeConfigurationWrapper.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/SubnodeConfiguration.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/XMLConfiguration.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationErrorEvent.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationEvent.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/interpol/ConstantLookup.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/PropertyListConfiguration.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/XMLPropertyListConfiguration.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/ManagedReloadingDetector.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/VFSFileHandlerReloadingDetector.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/CatalogResolver.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/DefaultEntityResolver.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodeIteratorBase.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodePointer.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractConfigurationBasicFeatures.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfiguration.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfigurationNonStringProperties.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestEqualsProperty.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNonStringProperties.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNullCompositeConfiguration.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfiguration.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfigurationLayout.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestXMLConfiguration.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/beanutils/BeanCreationTestBeanWithListChild.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListConfiguration.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListParser.java
    commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/web/TestServletFilterConfiguration.java

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/BaseHierarchicalConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/BaseHierarchicalConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/BaseHierarchicalConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/BaseHierarchicalConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -1489,10 +1489,10 @@ public class BaseHierarchicalConfigurati
     class DefinedKeysVisitor extends ConfigurationNodeVisitorAdapter
     {
         /** Stores the list to be filled. */
-        private Set<String> keyList;
+        private final Set<String> keyList;
 
         /** A stack with the keys of the already processed nodes. */
-        private Stack<String> parentKeys;
+        private final Stack<String> parentKeys;
 
         /**
          * Default constructor.
@@ -1564,7 +1564,7 @@ public class BaseHierarchicalConfigurati
     static class CloneVisitor extends ConfigurationNodeVisitorAdapter
     {
         /** A stack with the actual object to be copied. */
-        private Stack<ConfigurationNode> copyStack;
+        private final Stack<ConfigurationNode> copyStack;
 
         /** Stores the result of the clone process. */
         private ConfigurationNode result;

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/CombinedConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/CombinedConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/CombinedConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/CombinedConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -955,16 +955,16 @@ public class CombinedConfiguration exten
     private class ConfigData
     {
         /** Stores a reference to the configuration. */
-        private Configuration configuration;
+        private final Configuration configuration;
 
         /** Stores the name under which the configuration is stored. */
-        private String name;
+        private final String name;
 
         /** Stores the at information as path of nodes. */
-        private Collection<String> atPath;
+        private final Collection<String> atPath;
 
         /** Stores the at string.*/
-        private String at;
+        private final String at;
 
         /** Stores the root node for this child configuration.*/
         private ConfigurationNode rootNode;

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/ConfigurationMap.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/ConfigurationMap.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/ConfigurationMap.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/ConfigurationMap.java
Tue Feb 25 16:42:18 2014
@@ -123,7 +123,7 @@ public class ConfigurationMap extends Ab
         private final class Entry implements Map.Entry<Object, Object>
         {
             /** The key of the map entry. */
-            private Object key;
+            private final Object key;
 
             private Entry(Object key)
             {

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DynamicCombinedConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DynamicCombinedConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DynamicCombinedConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DynamicCombinedConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -81,10 +81,10 @@ public class DynamicCombinedConfiguratio
             new ConcurrentHashMap<String, CombinedConfiguration>();
 
     /** Stores a list with the contained configurations. */
-    private List<ConfigData> configurations = new ArrayList<ConfigData>();
+    private final List<ConfigData> configurations = new ArrayList<ConfigData>();
 
     /** Stores a map with the named configurations. */
-    private Map<String, Configuration> namedConfigurations =
+    private final Map<String, Configuration> namedConfigurations =
             new HashMap<String, Configuration>();
 
     /** The key pattern for the CombinedConfiguration map */
@@ -1053,13 +1053,13 @@ public class DynamicCombinedConfiguratio
     static class ConfigData
     {
         /** Stores a reference to the configuration. */
-        private Configuration configuration;
+        private final Configuration configuration;
 
         /** Stores the name under which the configuration is stored. */
-        private String name;
+        private final String name;
 
         /** Stores the at string.*/
-        private String at;
+        private final String at;
 
         /**
          * Creates a new instance of {@code ConfigData} and initializes

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/JNDIConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/JNDIConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/JNDIConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/JNDIConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -56,7 +56,7 @@ public class JNDIConfiguration extends A
     private Context baseContext;
 
     /** The Set of keys that have been virtually cleared. */
-    private Set<String> clearedProperties = new HashSet<String>();
+    private final Set<String> clearedProperties = new HashSet<String>();
 
     /**
      * Creates a JNDIConfiguration using the default initial context as the

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/PatternSubtreeConfigurationWrapper.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/PatternSubtreeConfigurationWrapper.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/PatternSubtreeConfigurationWrapper.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/PatternSubtreeConfigurationWrapper.java
Tue Feb 25 16:42:18 2014
@@ -59,7 +59,7 @@ public class PatternSubtreeConfiguration
     private final boolean trailing;
 
     /** True if the constructor has finished */
-    private boolean init;
+    private final boolean init;
 
     /**
      * Constructor

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/SubnodeConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/SubnodeConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/SubnodeConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/SubnodeConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -137,7 +137,7 @@ public class SubnodeConfiguration extend
     private static final long serialVersionUID = 3105734147019386480L;
 
     /** Stores the parent configuration. */
-    private BaseHierarchicalConfiguration parent;
+    private final BaseHierarchicalConfiguration parent;
 
     /** Stores the key that was used to construct this configuration.*/
     private String subnodeKey;

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/XMLConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/XMLConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/XMLConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/XMLConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -1403,7 +1403,7 @@ public class XMLConfiguration extends Ba
     static class XMLBuilderVisitor extends BuilderVisitor
     {
         /** Stores the document to be constructed. */
-        private Document document;
+        private final Document document;
 
         /** Stores the list delimiter handler .*/
         private final ListDelimiterHandler listDelimiterHandler;

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationErrorEvent.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationErrorEvent.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationErrorEvent.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationErrorEvent.java
Tue Feb 25 16:42:18 2014
@@ -62,7 +62,7 @@ public class ConfigurationErrorEvent ext
     private static final long serialVersionUID = -7433184493062648409L;
 
     /** Stores the exception that caused this event. */
-    private Throwable cause;
+    private final Throwable cause;
 
     /**
      * Creates a new instance of {@code ConfigurationErrorEvent} and

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationEvent.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationEvent.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationEvent.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/event/ConfigurationEvent.java
Tue Feb 25 16:42:18 2014
@@ -83,16 +83,16 @@ public class ConfigurationEvent extends 
     private static final long serialVersionUID = 3277238219073504136L;
 
     /** Stores the event type. */
-    private int type;
+    private final int type;
 
     /** Stores the property name. */
-    private String propertyName;
+    private final String propertyName;
 
     /** Stores the property value. */
-    private Object propertyValue;
+    private final Object propertyValue;
 
     /** Stores the before update flag. */
-    private boolean beforeUpdate;
+    private final boolean beforeUpdate;
 
     /**
      * Creates a new instance of {@code ConfigurationEvent} and

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/interpol/ConstantLookup.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/interpol/ConstantLookup.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/interpol/ConstantLookup.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/interpol/ConstantLookup.java
Tue Feb 25 16:42:18 2014
@@ -60,7 +60,7 @@ public class ConstantLookup implements L
     private static Map<String, Object> constantCache = new HashMap<String, Object>();
 
     /** The logger. */
-    private Log log = LogFactory.getLog(getClass());
+    private final Log log = LogFactory.getLog(getClass());
 
     /**
      * Tries to resolve the specified variable. The passed in variable name is

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/PropertyListConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/PropertyListConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/PropertyListConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/PropertyListConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -538,13 +538,13 @@ public class PropertyListConfiguration e
     private static class DateFieldParser extends DateComponentParser
     {
         /** Stores the calendar field to be processed. */
-        private int calendarField;
+        private final int calendarField;
 
         /** Stores the length of this field. */
-        private int length;
+        private final int length;
 
         /** An optional offset to add to the calendar field. */
-        private int offset;
+        private final int offset;
 
         /**
          * Creates a new instance of {@code DateFieldParser}.
@@ -605,7 +605,7 @@ public class PropertyListConfiguration e
     private static class DateSeparatorParser extends DateComponentParser
     {
         /** Stores the separator. */
-        private String separator;
+        private final String separator;
 
         /**
          * Creates a new instance of {@code DateSeparatorParser} and sets

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/XMLPropertyListConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/XMLPropertyListConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/XMLPropertyListConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/plist/XMLPropertyListConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -445,10 +445,10 @@ public class XMLPropertyListConfiguratio
     private class XMLPropertyListHandler extends DefaultHandler
     {
         /** The buffer containing the text node being read */
-        private StringBuilder buffer = new StringBuilder();
+        private final StringBuilder buffer = new StringBuilder();
 
         /** The stack of configuration nodes */
-        private List<ConfigurationNode> stack = new ArrayList<ConfigurationNode>();
+        private final List<ConfigurationNode> stack = new ArrayList<ConfigurationNode>();
 
         public XMLPropertyListHandler(ConfigurationNode root)
         {
@@ -760,7 +760,7 @@ public class XMLPropertyListConfiguratio
         private static final long serialVersionUID = 5586544306664205835L;
 
         /** The list of values in the array. */
-        private List<Object> list = new ArrayList<Object>();
+        private final List<Object> list = new ArrayList<Object>();
 
         /**
          * Add an object to the array.

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/ManagedReloadingDetector.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/ManagedReloadingDetector.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/ManagedReloadingDetector.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/ManagedReloadingDetector.java
Tue Feb 25 16:42:18 2014
@@ -31,7 +31,7 @@ public class ManagedReloadingDetector im
         ManagedReloadingDetectorMBean
 {
     /** The logger. */
-    private Log log = LogFactory.getLog(ManagedReloadingDetector.class);
+    private final Log log = LogFactory.getLog(ManagedReloadingDetector.class);
 
     /** A flag whether a reload is required. */
     private volatile boolean reloadingRequired;

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/VFSFileHandlerReloadingDetector.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/VFSFileHandlerReloadingDetector.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/VFSFileHandlerReloadingDetector.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/reloading/VFSFileHandlerReloadingDetector.java
Tue Feb 25 16:42:18 2014
@@ -51,7 +51,7 @@ import org.apache.commons.vfs2.VFS;
 public class VFSFileHandlerReloadingDetector extends FileHandlerReloadingDetector
 {
     /** Stores the logger.*/
-    private Log log = LogFactory.getLog(getClass());
+    private final Log log = LogFactory.getLog(getClass());
 
     /**
      * Creates a new instance of {@code VFSFileHandlerReloadingDetector} and

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/CatalogResolver.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/CatalogResolver.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/CatalogResolver.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/CatalogResolver.java
Tue Feb 25 16:42:18 2014
@@ -65,7 +65,7 @@ public class CatalogResolver implements 
     /**
      * The CatalogManager
      */
-    private CatalogManager manager = new CatalogManager();
+    private final CatalogManager manager = new CatalogManager();
 
     /**
      * The FileSystem in use.
@@ -390,7 +390,7 @@ public class CatalogResolver implements 
         private FileSystem fs;
 
         /** FileNameMap to determine the mime type */
-        private FileNameMap fileNameMap = URLConnection.getFileNameMap();
+        private final FileNameMap fileNameMap = URLConnection.getFileNameMap();
 
         /**
          * Load the catalogs.

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/DefaultEntityResolver.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/DefaultEntityResolver.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/DefaultEntityResolver.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/resolver/DefaultEntityResolver.java
Tue Feb 25 16:42:18 2014
@@ -38,7 +38,7 @@ import org.xml.sax.SAXException;
 public class DefaultEntityResolver implements EntityResolver, EntityRegistry
 {
     /** Stores a map with the registered public IDs.*/
-    private Map<String, URL> registeredEntities = new HashMap<String, URL>();
+    private final Map<String, URL> registeredEntities = new HashMap<String, URL>();
 
     /**
      * <p>

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodeIteratorBase.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodeIteratorBase.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodeIteratorBase.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodeIteratorBase.java
Tue Feb 25 16:42:18 2014
@@ -41,7 +41,7 @@ import org.apache.commons.jxpath.ri.mode
 abstract class ConfigurationNodeIteratorBase implements NodeIterator
 {
     /** Stores the parent node pointer. */
-    private NodePointer parent;
+    private final NodePointer parent;
 
     /** Stores the list with the sub nodes. */
     private List<ConfigurationNode> subNodes;
@@ -53,7 +53,7 @@ abstract class ConfigurationNodeIterator
     private int startOffset;
 
     /** Stores the reverse flag. */
-    private boolean reverse;
+    private final boolean reverse;
 
     /**
      * Creates a new instance of {@code ConfigurationNodeIteratorBase}

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodePointer.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodePointer.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodePointer.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/tree/xpath/ConfigurationNodePointer.java
Tue Feb 25 16:42:18 2014
@@ -49,7 +49,7 @@ class ConfigurationNodePointer extends N
     private static final long serialVersionUID = -1087475639680007713L;
 
     /** Stores the associated configuration node. */
-    private ConfigurationNode node;
+    private final ConfigurationNode node;
 
     /**
      * Creates a new instance of {@code ConfigurationNodePointer}.

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractConfigurationBasicFeatures.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractConfigurationBasicFeatures.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractConfigurationBasicFeatures.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestAbstractConfigurationBasicFeatures.java
Tue Feb 25 16:42:18 2014
@@ -1052,7 +1052,7 @@ public class TestAbstractConfigurationBa
     static class TestConfigurationImpl extends AbstractConfiguration
     {
         /** Stores the underlying configuration. */
-        private AbstractConfiguration config;
+        private final AbstractConfiguration config;
 
         public AbstractConfiguration getUnderlyingConfiguration()
         {

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -63,9 +63,9 @@ public class TestCompositeConfiguration
     /**
      * The File that we test with
      */
-    private String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
-    private String testProperties2 = ConfigurationAssert.getTestFile("test2.properties").getAbsolutePath();
-    private String testPropertiesXML = ConfigurationAssert.getTestFile("test.xml").getAbsolutePath();
+    private final String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
+    private final String testProperties2 = ConfigurationAssert.getTestFile("test2.properties").getAbsolutePath();
+    private final String testPropertiesXML = ConfigurationAssert.getTestFile("test.xml").getAbsolutePath();
 
     @Before
     public void setUp() throws Exception

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfigurationNonStringProperties.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfigurationNonStringProperties.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfigurationNonStringProperties.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestCompositeConfigurationNonStringProperties.java
Tue Feb 25 16:42:18 2014
@@ -29,7 +29,7 @@ import org.junit.Before;
 public class TestCompositeConfigurationNonStringProperties extends BaseNonStringProperties
 {
     /** The File that we test with */
-    private String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
+    private final String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
 
     @Before
     public void setUp() throws Exception

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestEqualsProperty.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestEqualsProperty.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestEqualsProperty.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestEqualsProperty.java
Tue Feb 25 16:42:18 2014
@@ -30,7 +30,7 @@ import org.junit.Test;
 public class TestEqualsProperty
 {
     /** The File that we test with */
-    private String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
+    private final String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
 
     @Test
     public void testEquals() throws Exception

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNonStringProperties.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNonStringProperties.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNonStringProperties.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNonStringProperties.java
Tue Feb 25 16:42:18 2014
@@ -28,7 +28,7 @@ import org.junit.Before;
 public class TestNonStringProperties extends BaseNonStringProperties
 {
     /** The File that we test with */
-    private String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
+    private final String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
 
     @Before
     public void setUp() throws Exception

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNullCompositeConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNullCompositeConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNullCompositeConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestNullCompositeConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -47,9 +47,9 @@ public class TestNullCompositeConfigurat
     protected CompositeConfiguration cc;
 
     /** The File that we test with */
-    private String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
-    private String testProperties2 = ConfigurationAssert.getTestFile("test2.properties").getAbsolutePath();
-    private String testPropertiesXML = ConfigurationAssert.getTestFile("test.xml").getAbsolutePath();
+    private final String testProperties = ConfigurationAssert.getTestFile("test.properties").getAbsolutePath();
+    private final String testProperties2 = ConfigurationAssert.getTestFile("test2.properties").getAbsolutePath();
+    private final String testPropertiesXML = ConfigurationAssert.getTestFile("test.xml").getAbsolutePath();
 
     @Before
     public void setUp() throws Exception

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -1232,10 +1232,10 @@ public class TestPropertiesConfiguration
     static class MockHttpURLStreamHandler extends URLStreamHandler
     {
         /** Stores the response code.*/
-        private int responseCode;
+        private final int responseCode;
 
         /** Stores the output file.*/
-        private File outputFile;
+        private final File outputFile;
 
         /** Stores the connection.*/
         private MockHttpURLConnection connection;

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfigurationLayout.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfigurationLayout.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfigurationLayout.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestPropertiesConfigurationLayout.java
Tue Feb 25 16:42:18 2014
@@ -715,7 +715,7 @@ public class TestPropertiesConfiguration
     static class PropertiesBuilder
     {
         /** A buffer for storing the data. */
-        private StringBuilder buf = new StringBuilder();
+        private final StringBuilder buf = new StringBuilder();
 
         /** A counter for varying the comment character. */
         private int commentCounter;

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestXMLConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestXMLConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestXMLConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/TestXMLConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -88,11 +88,11 @@ public class TestXMLConfiguration
     static final String PROP_FACTORY = "javax.xml.transform.TransformerFactory";
 
     /** The File that we test with */
-    private String testProperties = ConfigurationAssert.getTestFile("test.xml").getAbsolutePath();
-    private String testProperties2 = ConfigurationAssert.getTestFile("testDigesterConfigurationInclude1.xml").getAbsolutePath();
-    private File testSaveConf = ConfigurationAssert.getOutFile("testsave.xml");
-    private File testSaveFile = ConfigurationAssert.getOutFile("testsample2.xml");
-    private String testFile2 = ConfigurationAssert.getTestFile("sample.xml").getAbsolutePath();
+    private final String testProperties = ConfigurationAssert.getTestFile("test.xml").getAbsolutePath();
+    private final String testProperties2 = ConfigurationAssert.getTestFile("testDigesterConfigurationInclude1.xml").getAbsolutePath();
+    private final File testSaveConf = ConfigurationAssert.getOutFile("testsave.xml");
+    private final File testSaveFile = ConfigurationAssert.getOutFile("testsample2.xml");
+    private final String testFile2 = ConfigurationAssert.getTestFile("sample.xml").getAbsolutePath();
 
     /** Constant for the number of test threads. */
     private static final int THREAD_COUNT = 5;

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/beanutils/BeanCreationTestBeanWithListChild.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/beanutils/BeanCreationTestBeanWithListChild.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/beanutils/BeanCreationTestBeanWithListChild.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/beanutils/BeanCreationTestBeanWithListChild.java
Tue Feb 25 16:42:18 2014
@@ -31,7 +31,7 @@ public class BeanCreationTestBeanWithLis
 
     private int intValue;
 
-    private List<BeanCreationTestBean> children = new ArrayList<BeanCreationTestBean>();
+    private final List<BeanCreationTestBean> children = new ArrayList<BeanCreationTestBean>();
 
     public List<BeanCreationTestBean> getChildren()
     {

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -58,7 +58,7 @@ public class TestPropertyListConfigurati
 
     private PropertyListConfiguration config;
 
-    private File testProperties = ConfigurationAssert.getTestFile("test.plist");
+    private final File testProperties = ConfigurationAssert.getTestFile("test.plist");
 
     @Before
     public void setUp() throws Exception

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListParser.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListParser.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListParser.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/plist/TestPropertyListParser.java
Tue Feb 25 16:42:18 2014
@@ -33,7 +33,7 @@ import org.junit.Test;
  */
 public class TestPropertyListParser
 {
-    private PropertyListParser parser = new PropertyListParser((Reader) null);
+    private final PropertyListParser parser = new PropertyListParser((Reader) null);
 
     @Test
     public void testRemoveQuotes()

Modified: commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/web/TestServletFilterConfiguration.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/web/TestServletFilterConfiguration.java?rev=1571738&r1=1571737&r2=1571738&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/web/TestServletFilterConfiguration.java
(original)
+++ commons/proper/configuration/trunk/src/test/java/org/apache/commons/configuration/web/TestServletFilterConfiguration.java
Tue Feb 25 16:42:18 2014
@@ -58,7 +58,7 @@ public class TestServletFilterConfigurat
 
     private class MockFilterConfig implements FilterConfig
     {
-        private Properties parameters = new Properties();
+        private final Properties parameters = new Properties();
 
         @Override
         public String getFilterName()



Mime
View raw message