Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4193310446 for ; Sat, 11 Jan 2014 11:57:02 +0000 (UTC) Received: (qmail 40804 invoked by uid 500); 11 Jan 2014 11:56:32 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 40776 invoked by uid 500); 11 Jan 2014 11:56:31 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 40736 invoked by uid 99); 11 Jan 2014 11:56:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jan 2014 11:56:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jan 2014 11:56:12 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 95B2A23888E2; Sat, 11 Jan 2014 11:55:51 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1557355 - /commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/CommandLine.java Date: Sat, 11 Jan 2014 11:55:51 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140111115551.95B2A23888E2@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Sat Jan 11 11:55:51 2014 New Revision: 1557355 URL: http://svn.apache.org/r1557355 Log: No point using Vector for a local variable Modified: commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/CommandLine.java Modified: commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/CommandLine.java URL: http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/CommandLine.java?rev=1557355&r1=1557354&r2=1557355&view=diff ============================================================================== --- commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/CommandLine.java (original) +++ commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/CommandLine.java Sat Jan 11 11:55:51 2014 @@ -19,6 +19,7 @@ package org.apache.commons.exec; import java.io.File; +import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; import java.util.Map; @@ -345,7 +346,7 @@ public class CommandLine { final int inDoubleQuote = 2; int state = normal; final StringTokenizer tok = new StringTokenizer(toProcess, "\"\' ", true); - final Vector v = new Vector(); + final ArrayList list = new ArrayList(); StringBuffer current = new StringBuffer(); boolean lastTokenHasBeenQuoted = false; @@ -375,7 +376,7 @@ public class CommandLine { state = inDoubleQuote; } else if (" ".equals(nextTok)) { if (lastTokenHasBeenQuoted || current.length() != 0) { - v.addElement(current.toString()); + list.add(current.toString()); current = new StringBuffer(); } } else { @@ -387,7 +388,7 @@ public class CommandLine { } if (lastTokenHasBeenQuoted || current.length() != 0) { - v.addElement(current.toString()); + list.add(current.toString()); } if (state == inQuote || state == inDoubleQuote) { @@ -395,9 +396,8 @@ public class CommandLine { + toProcess); } - final String[] args = new String[v.size()]; - v.copyInto(args); - return args; + final String[] args = new String[list.size()]; + return list.toArray(args); } /**