commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject svn commit: r1552755 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
Date Fri, 20 Dec 2013 17:36:32 GMT
Author: bodewig
Date: Fri Dec 20 17:36:32 2013
New Revision: 1552755

URL: http://svn.apache.org/r1552755
Log:
explain why JarArchiveEntry overrides equals/hashCode

Modified:
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java?rev=1552755&r1=1552754&r2=1552755&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
(original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
Fri Dec 20 17:36:32 2013
@@ -87,6 +87,12 @@ public class JarArchiveEntry extends Zip
         return null;
     }
 
+    /* 
+     * We can chose between Findbugs complaining about
+     * http://findbugs.sourceforge.net/bugDescriptions.html#EQ_DOESNT_OVERRIDE_EQUALS
+     * or PMD stating "Overriding method merely calls super" - so far
+     * the choice is to make Findbugs happy.
+     */
     @Override
     public boolean equals(Object o) {
         return super.equals(o);



Mime
View raw message