commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1549802 - /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DriverConnectionFactory.java
Date Tue, 10 Dec 2013 09:57:36 GMT
Author: markt
Date: Tue Dec 10 09:57:36 2013
New Revision: 1549802

URL: http://svn.apache.org/r1549802
Log:
Fix some easy TODOs

Modified:
    commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DriverConnectionFactory.java

Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DriverConnectionFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DriverConnectionFactory.java?rev=1549802&r1=1549801&r2=1549802&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DriverConnectionFactory.java
(original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DriverConnectionFactory.java
Tue Dec 10 09:57:36 2013
@@ -14,7 +14,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 package org.apache.commons.dbcp2;
 import java.sql.Connection;
 import java.sql.Driver;
@@ -39,12 +38,13 @@ public class DriverConnectionFactory imp
         return _driver.connect(_connectUri,_props);
     }
 
-    protected Driver _driver = null; // TODO make final and private
-    protected String _connectUri = null; // TODO make final and private
-    protected Properties _props = null; // TODO make final and private
+    private final Driver _driver;
+    private final String _connectUri;
+    private final Properties _props;
 
     @Override
     public String toString() {
-        return this.getClass().getName() + " [" + String.valueOf(_driver) + ";" + String.valueOf(_connectUri)
+ ";"  + String.valueOf(_props) + "]";
+        return this.getClass().getName() + " [" + String.valueOf(_driver) + ";" +
+                String.valueOf(_connectUri) + ";"  + String.valueOf(_props) + "]";
     }
 }



Mime
View raw message