commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1547586 - in /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2: DelegatingConnection.java PoolableConnection.java
Date Tue, 03 Dec 2013 20:50:07 GMT
Author: markt
Date: Tue Dec  3 20:50:06 2013
New Revision: 1547586

URL: http://svn.apache.org/r1547586
Log:
Fix a TODO

Modified:
    commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java
    commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnection.java

Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java?rev=1547586&r1=1547585&r2=1547586&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java
(original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java
Tue Dec  3 20:50:06 2013
@@ -73,7 +73,7 @@ public class DelegatingConnection extend
 /* JDBC_4_ANT_KEY_END */
 
     /** My delegate {@link Connection}. */
-    protected Connection _conn = null; // TODO make private and add getter/setter?
+    private Connection _conn = null;
 
     protected boolean _closed = false; // TODO make private and add getter/setter?
     

Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnection.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnection.java?rev=1547586&r1=1547585&r2=1547586&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnection.java (original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnection.java Tue
Dec  3 20:50:06 2013
@@ -60,7 +60,7 @@ public class PoolableConnection extends 
 
         boolean isUnderlyingConectionClosed;
         try {
-            isUnderlyingConectionClosed = _conn.isClosed();
+            isUnderlyingConectionClosed = getDelegateInternal().isClosed();
         } catch (SQLException e) {
             try {
                 _pool.invalidateObject(this); // XXX should be guarded to happen at most
once



Mime
View raw message