commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1547240 - in /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed: DataSourceXAConnectionFactory.java LocalXAConnectionFactory.java
Date Mon, 02 Dec 2013 23:31:43 GMT
Author: markt
Date: Mon Dec  2 23:31:42 2013
New Revision: 1547240

URL: http://svn.apache.org/r1547240
Log:
Fix DBCP-404 for the o.a.c.dbcp2.managed package

Modified:
    commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java
    commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java

Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java?rev=1547240&r1=1547239&r2=1547240&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java
(original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java
Mon Dec  2 23:31:42 2013
@@ -31,10 +31,10 @@ import java.sql.SQLException;
  * @version $Revision$
  */
 public class DataSourceXAConnectionFactory implements XAConnectionFactory {
-	protected TransactionRegistry transactionRegistry; // TODO make private?
-	protected XADataSource xaDataSource; // TODO make private?
+	private TransactionRegistry transactionRegistry;
+	private XADataSource xaDataSource;
     private String username;
-    protected String password; // TODO make private?
+    private String password;
 
     /**
      * Creates an DataSourceXAConnectionFactory which uses the specified XADataSource to
create database

Modified: commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java?rev=1547240&r1=1547239&r2=1547240&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java
(original)
+++ commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java
Mon Dec  2 23:31:42 2013
@@ -35,8 +35,8 @@ import java.sql.SQLException;
  * @version $Revision$
  */
 public class LocalXAConnectionFactory implements XAConnectionFactory {
-    protected TransactionRegistry transactionRegistry; // TODO make private?
-    protected ConnectionFactory connectionFactory; // TODO make private?
+    private TransactionRegistry transactionRegistry;
+    private ConnectionFactory connectionFactory;
 
     /**
      * Creates an LocalXAConnectionFactory which uses the specified connection factory to
create database



Mime
View raw message