commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject svn commit: r1545980 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
Date Wed, 27 Nov 2013 09:59:30 GMT
Author: bodewig
Date: Wed Nov 27 09:59:30 2013
New Revision: 1545980

URL: http://svn.apache.org/r1545980
Log:
add a comment explaining why there is a long and not an int

Modified:
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java?rev=1545980&r1=1545979&r2=1545980&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
(original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
Wed Nov 27 09:59:30 2013
@@ -895,6 +895,7 @@ public class SevenZFile {
     }
     
     private static long readUint64(final DataInput in) throws IOException {
+        // long rather than int as it might get shifted beyond the range of an int
         long firstByte = in.readUnsignedByte();
         int mask = 0x80;
         long value = 0;



Mime
View raw message