commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ebo...@apache.org
Subject svn commit: r1545182 - in /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging: ./ common/ formats/png/ formats/tiff/
Date Mon, 25 Nov 2013 09:06:04 GMT
Author: ebourg
Date: Mon Nov 25 09:06:04 2013
New Revision: 1545182

URL: http://svn.apache.org/r1545182
Log:
Static methods are for implicitly final

Modified:
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/ImageParser.java
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/BinaryInputStream.java
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumber.java
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumberUtilities.java
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java?rev=1545182&r1=1545181&r2=1545182&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java
(original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/FormatCompliance.java
Mon Nov 25 09:06:04 2013
@@ -42,7 +42,7 @@ public class FormatCompliance {
         this.failOnError = fail_on_error;
     }
 
-    public static final FormatCompliance getDefault() {
+    public static FormatCompliance getDefault() {
         return new FormatCompliance("ignore", false);
     }
 

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/ImageParser.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/ImageParser.java?rev=1545182&r1=1545181&r2=1545182&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/ImageParser.java
(original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/ImageParser.java
Mon Nov 25 09:06:04 2013
@@ -94,7 +94,7 @@ public abstract class ImageParser extend
      * Gets an array of new instances of all image parsers.
      * @return A valid array of image parsers
      */
-    public static final ImageParser[] getAllImageParsers() {
+    public static ImageParser[] getAllImageParsers() {
         final ImageParser result[] = {
                 new BmpImageParser(),
                 new DcxImageParser(),
@@ -996,7 +996,7 @@ public abstract class ImageParser extend
      * @return If the params specify strict format compliance, true;
      * otherwise, false.
      */
-    public static final boolean isStrict(final Map<String,Object> params) {
+    public static boolean isStrict(final Map<String,Object> params) {
         if (params == null || !params.containsKey(PARAM_KEY_STRICT)) {
             return false;
         }

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/BinaryInputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/BinaryInputStream.java?rev=1545182&r1=1545181&r2=1545182&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/BinaryInputStream.java
(original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/BinaryInputStream.java
Mon Nov 25 09:06:04 2013
@@ -182,7 +182,7 @@ public class BinaryInputStream extends I
         BinaryFunctions.printByteBits(msg, i);
     }
 
-    public final static int charsToQuad(final char c1, final char c2, final char c3, final
char c4) {
+    public static int charsToQuad(final char c1, final char c2, final char c3, final char
c4) {
         return BinaryFunctions.charsToQuad(c1, c2, c3, c4);
     }
 

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumber.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumber.java?rev=1545182&r1=1545181&r2=1545182&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumber.java
(original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumber.java
Mon Nov 25 09:06:04 2013
@@ -32,7 +32,7 @@ public class RationalNumber extends Numb
         this.divisor = divisor;
     }
 
-    public static final RationalNumber factoryMethod(long n, long d) {
+    public static RationalNumber factoryMethod(long n, long d) {
         // safer than constructor - handles values outside min/max range.
         // also does some simple finding of common denominators.
 

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumberUtilities.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumberUtilities.java?rev=1545182&r1=1545181&r2=1545182&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumberUtilities.java
(original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/common/RationalNumberUtilities.java
Mon Nov 25 09:06:04 2013
@@ -31,7 +31,7 @@ public abstract class RationalNumberUtil
             this.error = error;
         }
 
-        public static final Option factory(final RationalNumber rationalNumber,
+        public static Option factory(final RationalNumber rationalNumber,
                 final double value) {
             return new Option(rationalNumber, Math.abs(rationalNumber
                     .doubleValue() - value));
@@ -46,7 +46,7 @@ public abstract class RationalNumberUtil
     //
     // calculate rational number using successive approximations.
     //
-    public static final RationalNumber getRationalNumber(double value) {
+    public static RationalNumber getRationalNumber(double value) {
         if (value >= Integer.MAX_VALUE) {
             return new RationalNumber(Integer.MAX_VALUE, 1);
         } else if (value <= -Integer.MAX_VALUE) {

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java?rev=1545182&r1=1545181&r2=1545182&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
(original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
Mon Nov 25 09:06:04 2013
@@ -90,7 +90,7 @@ public class PngImageParser extends Imag
 
     // private final static int tRNS = CharsToQuad('t', 'R', 'N', 's');
 
-    public static final String getChunkTypeName(final int chunkType) {
+    public static String getChunkTypeName(final int chunkType) {
         final StringBuilder result = new StringBuilder();
         result.append((char) (0xff & (chunkType >> 24)));
         result.append((char) (0xff & (chunkType >> 16)));

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java?rev=1545182&r1=1545181&r2=1545182&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java
(original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffDirectory.java
Mon Nov 25 09:06:04 2013
@@ -92,7 +92,7 @@ public class TiffDirectory extends TiffE
         return result.toString();
     }
 
-    public static final String description(final int type) {
+    public static String description(final int type) {
         switch (type) {
         case TiffDirectoryConstants.DIRECTORY_TYPE_UNKNOWN:
             return "Unknown";



Mime
View raw message