commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pste...@apache.org
Subject svn commit: r1544940 - in /commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl: TestGenericKeyedObjectPool.java TestGenericKeyedObjectPoolFactory.java
Date Sun, 24 Nov 2013 08:37:33 GMT
Author: psteitz
Date: Sun Nov 24 08:37:32 2013
New Revision: 1544940

URL: http://svn.apache.org/r1544940
Log:
Fixed broken test due to behavior change partially backported (minIdle > maxIdle ignored).

Modified:
    commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
    commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java

Modified: commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java?rev=1544940&r1=1544939&r2=1544940&view=diff
==============================================================================
--- commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
(original)
+++ commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
Sun Nov 24 08:37:32 2013
@@ -1005,7 +1005,7 @@ public class TestGenericKeyedObjectPool 
         
         // Make constructor arguments all different from defaults
         int maxActive = 1;
-        int maxIdle = 2;
+        int maxIdle = 12;
         long maxWait = 3;
         int minIdle = 4;
         int maxTotal = 5;

Modified: commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java?rev=1544940&r1=1544939&r2=1544940&view=diff
==============================================================================
--- commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java
(original)
+++ commons/proper/pool/branches/1_5_RELEASE/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java
Sun Nov 24 08:37:32 2013
@@ -44,7 +44,7 @@ public class TestGenericKeyedObjectPoolF
 
         final GenericKeyedObjectPool.Config config = new GenericKeyedObjectPool.Config();
         config.maxActive = 1;
-        config.maxIdle = 2;
+        config.maxIdle = 12;
         config.maxWait = 3;
         config.minIdle = 4;
         config.minEvictableIdleTimeMillis = 5;
@@ -58,7 +58,7 @@ public class TestGenericKeyedObjectPoolF
         factory = new GenericKeyedObjectPoolFactory(createObjectFactory(), config);
         pool = (GenericKeyedObjectPool)factory.createPool();
         assertEquals(1, pool.getMaxActive());
-        assertEquals(2, pool.getMaxIdle());
+        assertEquals(12, pool.getMaxIdle());
         assertEquals(3, pool.getMaxWait());
         assertEquals(4, pool.getMinIdle());
         assertEquals(5, pool.getMinEvictableIdleTimeMillis());



Mime
View raw message