commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Damjan Jovanovic <dam...@apache.org>
Subject Re: svn commit: r1534322 - in /commons/proper/imaging/trunk/src: changes/changes.xml main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java main/java/org/apache/commons/imaging/formats/jpeg/segments/ComSegment.java
Date Tue, 22 Oct 2013 04:49:44 GMT
On Tue, Oct 22, 2013 at 3:02 AM, sebb <sebbaz@gmail.com> wrote:
>> +
>> +    public byte[] getComment() {
>> +        return comment;
>
> This is better, but the array can still be modified externally.
>
> Might make more sense to convert the array to a String and return that
> instead - Strings are immutable, but arrays are not.
> Otherwise perhaps return a copy.
>

The text encoding for the JPEG COM segment is unspecified, and can be
anything in practice, including binary data instead of text, so we
have to return a byte[].

I am concerned about the performance implications of copying data
around so much, but guess it's not much data.

Mime
View raw message