commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1537249 - in /commons/proper/pool/trunk: findbugs-exclude-filter.xml src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
Date Wed, 30 Oct 2013 19:10:31 GMT
Author: markt
Date: Wed Oct 30 19:10:31 2013
New Revision: 1537249

URL: http://svn.apache.org/r1537249
Log:
Filter out the last remaining FindBugs warning that didn't appear until I tweaked by IDE settings.
Expand that Javadoc comments to make the behaviour explicitly clear to users.

Modified:
    commons/proper/pool/trunk/findbugs-exclude-filter.xml
    commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java

Modified: commons/proper/pool/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/findbugs-exclude-filter.xml?rev=1537249&r1=1537248&r2=1537249&view=diff
==============================================================================
--- commons/proper/pool/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/pool/trunk/findbugs-exclude-filter.xml Wed Oct 30 19:10:31 2013
@@ -46,6 +46,12 @@
     <Bug code="REC" />
   </Match>
   <Match>
+    <!-- Use of default system encoding is deliberate design choice -->
+    <Class name="org.apache.commons.pool2.impl.AbandonedConfig" />
+    <Method name="&lt;init&gt;" />
+    <Bug pattern="DM_DEFAULT_ENCODING " />
+  </Match>
+  <Match>
     <!-- compareTo() method carries the appropriate warning -->
     <Class name="org.apache.commons.pool2.impl.DefaultPooledObject" />
     <Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS " />

Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java?rev=1537249&r1=1537248&r2=1537249&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
(original)
+++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
Wed Oct 30 19:10:31 2013
@@ -173,13 +173,14 @@ public class AbandonedConfig {
 
     /**
      * PrintWriter to use to log information on abandoned objects.
+     * Use of default system encoding is deliberate.
      */
     private PrintWriter logWriter = new PrintWriter(System.out);
 
     /**
      * Returns the log writer being used by this configuration to log
      * information on abandoned objects. If not set, a PrintWriter based on
-     * System.out is used.
+     * System.out with the system default encoding is used.
      *
      * @return log writer in use
      */



Mime
View raw message