commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1531897 - in /commons/proper/pool/trunk: findbugs-exclude-filter.xml src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java src/test/java/org/apache/commons/pool2/proxy/BaseTestProxiedObjectPool.java
Date Mon, 14 Oct 2013 13:48:36 GMT
Author: markt
Date: Mon Oct 14 13:48:35 2013
New Revision: 1531897

URL: http://svn.apache.org/r1531897
Log:
Fix some FindBugs warnings

Modified:
    commons/proper/pool/trunk/findbugs-exclude-filter.xml
    commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
    commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/proxy/BaseTestProxiedObjectPool.java

Modified: commons/proper/pool/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/findbugs-exclude-filter.xml?rev=1531897&r1=1531896&r2=1531897&view=diff
==============================================================================
--- commons/proper/pool/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/pool/trunk/findbugs-exclude-filter.xml Mon Oct 14 13:48:35 2013
@@ -100,4 +100,13 @@
     <Method name="testJavaBeanInstantiation" />
     <Bug pattern="ISC_INSTANTIATE_STATIC_CLASS" />
   </Match>
+  <Match>
+    <!-- Exceptions are deliberately ignored -->
+    <Or>
+      <Class name="org.apache.commons.pool2.impl.TestAbandonedObjectPool$ConcurrentBorrower"
/>
+      <Class name="org.apache.commons.pool2.impl.TestAbandonedObjectPool$ConcurrentReturner"
/>
+    </Or>
+    <Method name="run" />
+    <Bug pattern="DE_MIGHT_IGNORE" />
+  </Match>
 </FindBugsFilter>

Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java?rev=1531897&r1=1531896&r2=1531897&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
(original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
Mon Oct 14 13:48:35 2013
@@ -254,7 +254,7 @@ public class TestAbandonedObjectPool ext
         }
     }
 
-    class SimpleFactory implements PooledObjectFactory<PooledTestObject> {
+    private static class SimpleFactory implements PooledObjectFactory<PooledTestObject>
{
 
         private final long destroyLatency;
         private final long validateLatency;

Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/proxy/BaseTestProxiedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/proxy/BaseTestProxiedObjectPool.java?rev=1531897&r1=1531896&r2=1531897&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/proxy/BaseTestProxiedObjectPool.java
(original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/proxy/BaseTestProxiedObjectPool.java
Mon Oct 14 13:48:35 2013
@@ -42,7 +42,7 @@ public abstract class BaseTestProxiedObj
     private StringWriter log = null;
 
     @Before
-    public void setup() {
+    public void setUp() {
         log = new StringWriter();
 
         PrintWriter pw = new PrintWriter(log);



Mime
View raw message