commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1531872 - /commons/proper/pool/trunk/findbugs-exclude-filter.xml
Date Mon, 14 Oct 2013 12:16:24 GMT
Author: markt
Date: Mon Oct 14 12:16:24 2013
New Revision: 1531872

URL: http://svn.apache.org/r1531872
Log:
Move comments inside outer element so it is easier to see which comment applies to which exclusion.
Fix a couple of false positives.

Modified:
    commons/proper/pool/trunk/findbugs-exclude-filter.xml

Modified: commons/proper/pool/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/findbugs-exclude-filter.xml?rev=1531872&r1=1531871&r2=1531872&view=diff
==============================================================================
--- commons/proper/pool/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/pool/trunk/findbugs-exclude-filter.xml Mon Oct 14 12:16:24 2013
@@ -22,8 +22,13 @@
   put here to instruct Find Bugs to ignore them.
 -->
 <FindBugsFilter>
-  <!-- Swallowing exception is deliberate design choice -->
   <Match>
+    <!-- Class implements the generics based interface and does so correctly -->
+    <Class name="org.apache.commons.pool2.PooledObject" />
+    <Bug pattern="CO_ABSTRACT_SELF" />
+  </Match>
+  <Match>
+    <!-- Swallowing exception is deliberate design choice -->
     <Or>
       <Class name="org.apache.commons.pool2.PoolUtils$ErodingObjectPool" />
       <Class name="org.apache.commons.pool2.PoolUtils$ErodingKeyedObjectPool" />
@@ -34,28 +39,33 @@
     </Or>
     <Bug code="DE" />
   </Match>
-  <!-- Exception is thrown and need to be caught -->
   <Match>
+    <!-- Exception is thrown and need to be caught -->
     <Class name="org.apache.commons.pool2.PoolUtils$KeyedObjectPoolMinIdleTimerTask" />
     <Method name="run" />
     <Bug code="REC" />
   </Match>
-  <!-- Ignoring the exception is deliberate since an earlier exception is    -->
-  <!-- more important.                                                       -->
   <Match>
+    <!-- compareTo() method carries the appropriate warning -->
+    <Class name="org.apache.commons.pool2.impl.DefaultPooledObject" />
+    <Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS " />
+  </Match>
+  <Match>
+    <!-- Ignoring the exception is deliberate since an earlier exception is  -->
+    <!-- more important.                                                     -->
     <Class name="org.apache.commons.pool2.impl.GenericKeyedObjectPool" />
     <Method name="borrowObject" />
     <Bug code="DE" />
   </Match>
-  <!-- Ignoring the exception is deliberate since an earlier exception is    -->
-  <!-- more important.                                                       -->
   <Match>
+    <!-- Ignoring the exception is deliberate since an earlier exception is  -->
+    <!-- more important.                                                     -->
     <Class name="org.apache.commons.pool2.impl.GenericObjectPool" />
     <Method name="borrowObject" />
     <Bug code="DE" />
   </Match>
-    <!-- Swallowing exception is deliberate design choice -->
   <Match>
+    <!-- Swallowing exception is deliberate design choice -->
     <Class name="org.apache.commons.pool2.impl.SoftReferenceObjectPool" />
     <Or>
       <Method name="addObject" />



Mime
View raw message