Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 39ED9C75B for ; Tue, 18 Jun 2013 21:59:42 +0000 (UTC) Received: (qmail 42570 invoked by uid 500); 18 Jun 2013 21:59:41 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 42510 invoked by uid 500); 18 Jun 2013 21:59:41 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 42503 invoked by uid 99); 18 Jun 2013 21:59:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 21:59:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 21:59:40 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id B51AD2388A29; Tue, 18 Jun 2013 21:59:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1494333 - /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/iterators/LoopingListIterator.java Date: Tue, 18 Jun 2013 21:59:21 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130618215921.B51AD2388A29@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Tue Jun 18 21:59:21 2013 New Revision: 1494333 URL: http://svn.apache.org/r1494333 Log: Constructors must not invoke overrideable methods Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/iterators/LoopingListIterator.java Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/iterators/LoopingListIterator.java URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/iterators/LoopingListIterator.java?rev=1494333&r1=1494332&r2=1494333&view=diff ============================================================================== --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/iterators/LoopingListIterator.java (original) +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/iterators/LoopingListIterator.java Tue Jun 18 21:59:21 2013 @@ -59,7 +59,7 @@ public class LoopingListIterator impl throw new NullPointerException("The list must not be null"); } this.list = list; - reset(); + _reset(); } /** @@ -235,6 +235,10 @@ public class LoopingListIterator impl * Resets the iterator back to the start of the list. */ public void reset() { + _reset(); + } + + private void _reset() { iterator = list.listIterator(); }