Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2839010480 for ; Mon, 10 Jun 2013 19:07:55 +0000 (UTC) Received: (qmail 31202 invoked by uid 500); 10 Jun 2013 19:07:54 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 31163 invoked by uid 500); 10 Jun 2013 19:07:54 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 31156 invoked by uid 99); 10 Jun 2013 19:07:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jun 2013 19:07:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jun 2013 19:07:53 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 5B0D0238889B; Mon, 10 Jun 2013 19:07:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1491567 - in /commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3: POP3ClientCommandsTest.java POP3ClientTest.java POP3Constants.java POP3ConstructorTest.java TestSetupParameters.java Date: Mon, 10 Jun 2013 19:07:34 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130610190734.5B0D0238889B@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Mon Jun 10 19:07:33 2013 New Revision: 1491567 URL: http://svn.apache.org/r1491567 Log: Rename class - it only provides constants; it is not a test case Added: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java - copied, changed from r1490850, commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java Removed: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java?rev=1491567&r1=1491566&r2=1491567&view=diff ============================================================================== --- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java (original) +++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java Mon Jun 10 19:07:33 2013 @@ -44,10 +44,10 @@ public class POP3ClientCommandsTest exte { POP3Client p = null; - String user = TestSetupParameters.user; - String emptyUser = TestSetupParameters.emptyuser; - String password = TestSetupParameters.password; - String mailhost = TestSetupParameters.mailhost; + String user = POP3Constants.user; + String emptyUser = POP3Constants.emptyuser; + String password = POP3Constants.password; + String mailhost = POP3Constants.mailhost; /** * Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java?rev=1491567&r1=1491566&r2=1491567&view=diff ============================================================================== --- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java (original) +++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java Mon Jun 10 19:07:33 2013 @@ -44,10 +44,10 @@ public class POP3ClientTest extends Test { POP3Client p = null; - String user = TestSetupParameters.user; - String emptyUser = TestSetupParameters.emptyuser; - String password = TestSetupParameters.password; - String mailhost = TestSetupParameters.mailhost; + String user = POP3Constants.user; + String emptyUser = POP3Constants.emptyuser; + String password = POP3Constants.password; + String mailhost = POP3Constants.mailhost; /** * Copied: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java (from r1490850, commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java) URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java?p2=commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java&p1=commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java&r1=1490850&r2=1491567&rev=1491567&view=diff ============================================================================== --- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java (original) +++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java Mon Jun 10 19:07:33 2013 @@ -34,7 +34,7 @@ package org.apache.commons.net.pop3; * Your mileage may vary based on the POP3 server you run the tests against. * Some servers are more standards-compliant than others. */ -public class TestSetupParameters +public class POP3Constants { public static final String user = "test"; public static final String emptyuser = "alwaysempty"; @@ -43,6 +43,6 @@ public class TestSetupParameters public static final String mailhost = "localhost"; //Cannot be instantiated - private TestSetupParameters() + private POP3Constants() {} } Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java?rev=1491567&r1=1491566&r2=1491567&view=diff ============================================================================== --- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java (original) +++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java Mon Jun 10 19:07:33 2013 @@ -39,10 +39,10 @@ import java.io.Reader; */ public class POP3ConstructorTest extends TestCase { - String user = TestSetupParameters.user; - String emptyUser = TestSetupParameters.emptyuser; - String password = TestSetupParameters.password; - String mailhost = TestSetupParameters.mailhost; + String user = POP3Constants.user; + String emptyUser = POP3Constants.emptyuser; + String password = POP3Constants.password; + String mailhost = POP3Constants.mailhost; /** *