commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1491567 - in /commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3: POP3ClientCommandsTest.java POP3ClientTest.java POP3Constants.java POP3ConstructorTest.java TestSetupParameters.java
Date Mon, 10 Jun 2013 19:07:34 GMT
Author: sebb
Date: Mon Jun 10 19:07:33 2013
New Revision: 1491567

URL: http://svn.apache.org/r1491567
Log:
Rename class - it only provides constants; it is not a test case

Added:
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java
      - copied, changed from r1490850, commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java
Removed:
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java
Modified:
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java

Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java?rev=1491567&r1=1491566&r2=1491567&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java
(original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientCommandsTest.java
Mon Jun 10 19:07:33 2013
@@ -44,10 +44,10 @@ public class POP3ClientCommandsTest exte
 {
     POP3Client p = null;
 
-    String user = TestSetupParameters.user;
-    String emptyUser = TestSetupParameters.emptyuser;
-    String password = TestSetupParameters.password;
-    String mailhost = TestSetupParameters.mailhost;
+    String user = POP3Constants.user;
+    String emptyUser = POP3Constants.emptyuser;
+    String password = POP3Constants.password;
+    String mailhost = POP3Constants.mailhost;
 
     /**
      *

Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java?rev=1491567&r1=1491566&r2=1491567&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java
(original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ClientTest.java
Mon Jun 10 19:07:33 2013
@@ -44,10 +44,10 @@ public class POP3ClientTest extends Test
 {
     POP3Client p = null;
 
-    String user = TestSetupParameters.user;
-    String emptyUser = TestSetupParameters.emptyuser;
-    String password = TestSetupParameters.password;
-    String mailhost = TestSetupParameters.mailhost;
+    String user = POP3Constants.user;
+    String emptyUser = POP3Constants.emptyuser;
+    String password = POP3Constants.password;
+    String mailhost = POP3Constants.mailhost;
 
     /**
      *

Copied: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java
(from r1490850, commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java)
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java?p2=commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java&p1=commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java&r1=1490850&r2=1491567&rev=1491567&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/TestSetupParameters.java
(original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3Constants.java
Mon Jun 10 19:07:33 2013
@@ -34,7 +34,7 @@ package org.apache.commons.net.pop3;
  * Your mileage may vary based on the POP3 server you run the tests against.
  * Some servers are more standards-compliant than others.
  */
-public class TestSetupParameters
+public class POP3Constants
 {
     public static final String user = "test";
     public static final String emptyuser = "alwaysempty";
@@ -43,6 +43,6 @@ public class TestSetupParameters
     public static final String mailhost = "localhost";
 
      //Cannot be instantiated
-    private TestSetupParameters()
+    private POP3Constants()
     {}
 }

Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java?rev=1491567&r1=1491566&r2=1491567&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java
(original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java
Mon Jun 10 19:07:33 2013
@@ -39,10 +39,10 @@ import java.io.Reader;
  */
 public class POP3ConstructorTest extends TestCase
 {
-    String user = TestSetupParameters.user;
-    String emptyUser = TestSetupParameters.emptyuser;
-    String password = TestSetupParameters.password;
-    String mailhost = TestSetupParameters.mailhost;
+    String user = POP3Constants.user;
+    String emptyUser = POP3Constants.emptyuser;
+    String password = POP3Constants.password;
+    String mailhost = POP3Constants.mailhost;
 
     /**
      *



Mime
View raw message