commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1489655 - /commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java
Date Tue, 04 Jun 2013 22:15:09 GMT
Author: sebb
Date: Tue Jun  4 22:15:09 2013
New Revision: 1489655

URL: http://svn.apache.org/r1489655
Log:
Don't compare strings using ==

Modified:
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java?rev=1489655&r1=1489654&r2=1489655&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java Tue Jun
 4 22:15:09 2013
@@ -361,7 +361,7 @@ public class Threader {
             String subj = threadable.simplifiedSubject();
 
             // Dont thread together all subjectless messages
-            if (subj == null || subj == "") {
+            if (subj == null || subj.length() == 0) {
                 continue;
             }
 



Mime
View raw message