Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E33C965F for ; Sat, 9 Mar 2013 14:24:58 +0000 (UTC) Received: (qmail 78393 invoked by uid 500); 9 Mar 2013 14:24:58 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 78195 invoked by uid 500); 9 Mar 2013 14:24:57 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 78181 invoked by uid 99); 9 Mar 2013 14:24:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Mar 2013 14:24:57 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Mar 2013 14:24:54 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id AEC15238889B; Sat, 9 Mar 2013 14:24:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1454717 - /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/DualTreeBidiMap.java Date: Sat, 09 Mar 2013 14:24:34 -0000 To: commits@commons.apache.org From: tn@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130309142434.AEC15238889B@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: tn Date: Sat Mar 9 14:24:34 2013 New Revision: 1454717 URL: http://svn.apache.org/r1454717 Log: [COLLECTIONS-445] Clarify that the behavior of IBM JDK is not really a bug, Map.Entry specifies that its behavior is undefined if the backing map is modified. Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/DualTreeBidiMap.java Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/DualTreeBidiMap.java URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/DualTreeBidiMap.java?rev=1454717&r1=1454716&r2=1454717&view=diff ============================================================================== --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/DualTreeBidiMap.java (original) +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/DualTreeBidiMap.java Sat Mar 9 14:24:34 2013 @@ -363,8 +363,9 @@ public class DualTreeBidiMap exten "Cannot use setValue() when the object being set is already in the map"); } final V oldValue = parent.put(last.getKey(), value); - // set also the value in the Map.Entry: - // due to a bug in IBM JDK where the Entry is not in sync with the underlying map + // Map.Entry specifies that the behavior is undefined when the backing map + // has been modified (as we did with the put), so we also set the value + // (especially needed for IBM JDK) last.setValue(value); return oldValue; }