commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brit...@apache.org
Subject svn commit: r1443193 - in /commons/sandbox/beanutils2/trunk/src: changes/ main/java/org/apache/commons/beanutils2/ test/java/org/apache/commons/beanutils2/
Date Wed, 06 Feb 2013 20:34:44 GMT
Author: britter
Date: Wed Feb  6 20:34:43 2013
New Revision: 1443193

URL: http://svn.apache.org/viewvc?rev=1443193&view=rev
Log:
[SANDBOX-439] - Rename ClassLoaderBuilder.loadWithClassLoader to loadWith

Modified:
    commons/sandbox/beanutils2/trunk/src/changes/changes.xml
    commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/ClassLoaderBuilder.java
    commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/DefaultClassLoaderBuilder.java
    commons/sandbox/beanutils2/trunk/src/test/java/org/apache/commons/beanutils2/OnClassNameTestCase.java

Modified: commons/sandbox/beanutils2/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/sandbox/beanutils2/trunk/src/changes/changes.xml?rev=1443193&r1=1443192&r2=1443193&view=diff
==============================================================================
--- commons/sandbox/beanutils2/trunk/src/changes/changes.xml (original)
+++ commons/sandbox/beanutils2/trunk/src/changes/changes.xml Wed Feb  6 20:34:43 2013
@@ -23,6 +23,9 @@
   </properties>
   <body>
   <release version="0.1" date="201?-??-??" description="First release.">
+    <action dev="britter" type="update" issue="SANDBOX-439" due-to="Benedikt Ritter">
+      Rename ClassLoaderBuilder.loadWithClassLoader to loadWith
+    </action>
     <action dev="britter" type="add" issue="SANDBOX-438" due-to="Benedikt Ritter">
       Implement setMapped on DefaultBeanAccessor
     </action>

Modified: commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/ClassLoaderBuilder.java
URL: http://svn.apache.org/viewvc/commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/ClassLoaderBuilder.java?rev=1443193&r1=1443192&r2=1443193&view=diff
==============================================================================
--- commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/ClassLoaderBuilder.java
(original)
+++ commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/ClassLoaderBuilder.java
Wed Feb  6 20:34:43 2013
@@ -20,7 +20,7 @@ package org.apache.commons.beanutils2;
  */
 
 /**
- * Allows to specify a {@link ClassLoader} for loading a classes by name.
+ * Allows to specify a {@link ClassLoader} for loading a class by name.
  */
 public interface ClassLoaderBuilder
 {
@@ -34,8 +34,7 @@ public interface ClassLoaderBuilder
     ClassAccessor<?> loadWithThreadContextClassLoader();
 
     /**
-     * Use the class loader that loaded the {@code org.apache.commons.beanutils2.BeanUtils2}
class to load the
-     * class.
+     * Use the class loader that loaded {@code org.apache.commons.beanutils2.BeanUtils2}
to load the class.
      *
      * @return the {@link ClassAccessor} for the class being loaded.
      */
@@ -44,9 +43,9 @@ public interface ClassLoaderBuilder
     /**
      * Use a custom {@link ClassLoader} for loading the class.
      *
-     * @param classLoader the {@link ClassLoader} to load the class.
+     * @param classLoader the {@link ClassLoader} to load the class. Must not be {@code null}!
      * @return the {@link ClassAccessor} for the class being loaded.
      */
-    ClassAccessor<?> loadWithClassLoader( ClassLoader classLoader );
+    ClassAccessor<?> loadWith( ClassLoader classLoader );
 
 }

Modified: commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/DefaultClassLoaderBuilder.java
URL: http://svn.apache.org/viewvc/commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/DefaultClassLoaderBuilder.java?rev=1443193&r1=1443192&r2=1443193&view=diff
==============================================================================
--- commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/DefaultClassLoaderBuilder.java
(original)
+++ commons/sandbox/beanutils2/trunk/src/main/java/org/apache/commons/beanutils2/DefaultClassLoaderBuilder.java
Wed Feb  6 20:34:43 2013
@@ -38,7 +38,7 @@ final class DefaultClassLoaderBuilder
      */
     public ClassAccessor<?> loadWithThreadContextClassLoader()
     {
-        return loadWithClassLoader( currentThread().getContextClassLoader() );
+        return loadWith( currentThread().getContextClassLoader() );
     }
 
     /**
@@ -46,13 +46,13 @@ final class DefaultClassLoaderBuilder
      */
     public ClassAccessor<?> loadWithBeanUtilsClassLoader()
     {
-        return loadWithClassLoader( getClass().getClassLoader() );
+        return loadWith( getClass().getClassLoader() );
     }
 
     /**
      * {@inheritDoc}
      */
-    public ClassAccessor<?> loadWithClassLoader( ClassLoader classLoader )
+    public ClassAccessor<?> loadWith( ClassLoader classLoader )
     {
         classLoader = checkNotNull( classLoader, "No ClassLoader specified" );
 

Modified: commons/sandbox/beanutils2/trunk/src/test/java/org/apache/commons/beanutils2/OnClassNameTestCase.java
URL: http://svn.apache.org/viewvc/commons/sandbox/beanutils2/trunk/src/test/java/org/apache/commons/beanutils2/OnClassNameTestCase.java?rev=1443193&r1=1443192&r2=1443193&view=diff
==============================================================================
--- commons/sandbox/beanutils2/trunk/src/test/java/org/apache/commons/beanutils2/OnClassNameTestCase.java
(original)
+++ commons/sandbox/beanutils2/trunk/src/test/java/org/apache/commons/beanutils2/OnClassNameTestCase.java
Wed Feb  6 20:34:43 2013
@@ -44,7 +44,7 @@ public class OnClassNameTestCase
     public void onClassNameTestBeanWithClassLoaderNull()
         throws Exception
     {
-        assertNotNull( onClassName( TestBean.class.getName() ).loadWithClassLoader( null
) );
+        assertNotNull( onClassName( TestBean.class.getName() ).loadWith( null ) );
     }
 
     @Test
@@ -65,7 +65,7 @@ public class OnClassNameTestCase
     public void onClassNameTestBeanWithJUnitClassLoader()
         throws Exception
     {
-        assertNotNull( onClassName( TestBean.class.getName() ).loadWithClassLoader( getClass().getClassLoader()
) );
+        assertNotNull( onClassName( TestBean.class.getName() ).loadWith( getClass().getClassLoader()
) );
     }
 
     @Test
@@ -90,7 +90,7 @@ public class OnClassNameTestCase
         throws Exception
     {
         Object instance =
-            onClassName( TestBean.class.getName() ).loadWithClassLoader( getClass().getClassLoader()
).newInstance().get();
+            onClassName( TestBean.class.getName() ).loadWith( getClass().getClassLoader()
).newInstance().get();
         assertTrue( instance instanceof TestBean );
     }
 



Mime
View raw message