Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3234CDE3F for ; Mon, 28 Jan 2013 19:00:08 +0000 (UTC) Received: (qmail 87989 invoked by uid 500); 28 Jan 2013 19:00:08 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 87939 invoked by uid 500); 28 Jan 2013 19:00:07 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 87931 invoked by uid 99); 28 Jan 2013 19:00:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jan 2013 19:00:07 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jan 2013 19:00:06 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id D22592388AA6; Mon, 28 Jan 2013 18:59:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1439565 - in /commons/proper/cli/trunk/src/main/java/org/apache/commons/cli: DefaultParser.java Option.java Parser.java Date: Mon, 28 Jan 2013 18:59:47 -0000 To: commits@commons.apache.org From: tn@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130128185947.D22592388AA6@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: tn Date: Mon Jan 28 18:59:47 2013 New Revision: 1439565 URL: http://svn.apache.org/viewvc?rev=1439565&view=rev Log: Fix Clirr error wrt return type of Option#clone(). Modified: commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/DefaultParser.java commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Parser.java Modified: commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/DefaultParser.java URL: http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/DefaultParser.java?rev=1439565&r1=1439564&r2=1439565&view=diff ============================================================================== --- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/DefaultParser.java (original) +++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/DefaultParser.java Mon Jan 28 18:59:47 2013 @@ -599,7 +599,7 @@ public class DefaultParser implements Co // check the previous option before handling the next one checkRequiredArgs(); - option = option.clone(); + option = (Option) option.clone(); updateRequiredOptions(option); Modified: commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java URL: http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java?rev=1439565&r1=1439564&r2=1439565&view=diff ============================================================================== --- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java (original) +++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Option.java Mon Jan 28 18:59:47 2013 @@ -631,9 +631,11 @@ public class Option implements Cloneable * After calling this method, it is very likely you will want to call * clearValues(). * - * @throws RuntimeException + * @return a clone of this Option instance + * @throws RuntimeException if a {@link CloneNotSupportedException} has been thrown + * by {@link super#clone()} */ - public Option clone() + public Object clone() { try { Modified: commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Parser.java URL: http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Parser.java?rev=1439565&r1=1439564&r2=1439565&view=diff ============================================================================== --- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Parser.java (original) +++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Parser.java Mon Jan 28 18:59:47 2013 @@ -380,7 +380,7 @@ public abstract class Parser implements } // get the option represented by arg - Option opt = getOptions().getOption(arg).clone(); + Option opt = (Option) getOptions().getOption(arg).clone(); // update the required options and groups updateRequiredOptions(opt);