Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 646F6DC0A for ; Wed, 23 Jan 2013 16:06:07 +0000 (UTC) Received: (qmail 31738 invoked by uid 500); 23 Jan 2013 16:06:07 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 31676 invoked by uid 500); 23 Jan 2013 16:06:07 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 31669 invoked by uid 99); 23 Jan 2013 16:06:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jan 2013 16:06:07 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jan 2013 16:06:06 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 12E5323889DE; Wed, 23 Jan 2013 16:05:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1437527 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java Date: Wed, 23 Jan 2013 16:05:47 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130123160547.12E5323889DE@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Wed Jan 23 16:05:46 2013 New Revision: 1437527 URL: http://svn.apache.org/viewvc?rev=1437527&view=rev Log: Add Javadoc and deprecate currently useless methods Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java?rev=1437527&r1=1437526&r2=1437527&view=diff ============================================================================== --- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java (original) +++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java Wed Jan 23 16:05:46 2013 @@ -28,7 +28,7 @@ import org.apache.commons.compress.archi /** * - * @NotThreadSafe + * @NotThreadSafe (parent is not thread-safe) */ public class JarArchiveEntry extends ZipArchiveEntry { @@ -53,12 +53,28 @@ public class JarArchiveEntry extends Zip } + /** + * This method is not implemented and won't ever be. + * The JVM equivalent has a different name {@link java.util.jar.JarEntry#getAttributes()} + * + * @deprecated Do not use; always returns null + * @return Always returns null. + */ + @Deprecated public Attributes getManifestAttributes() { return manifestAttributes; } + /** + * Return a copy of the list of certificates or null if there are none. + * + * @return Always returns null in the current implementation + * + * @deprecated Not currently implemented + */ + @Deprecated public Certificate[] getCertificates() { - if (certificates != null) { + if (certificates != null) { // never true currently Certificate[] certs = new Certificate[certificates.length]; System.arraycopy(certificates, 0, certs, 0, certs.length); return certs;